From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915/fbc: Disable fbc with VT-d also with kbl and cfl Date: Tue, 25 Sep 2018 18:15:52 +0300 Message-ID: <20180925151552.GJ9144@intel.com> References: <20180925133803.23677-1-mika.kuoppala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20180925133803.23677-1-mika.kuoppala@linux.intel.com> Sender: stable-owner@vger.kernel.org To: Mika Kuoppala Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni , Chris Wilson , Rodrigo Vivi , stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Sep 25, 2018 at 04:38:03PM +0300, Mika Kuoppala wrote: > Using fbc with VT-d flickers also on kbl and cfl. > > Cc: Paulo Zanoni > Cc: Ville Syrjälä > Cc: Chris Wilson > Cc: Rodrigo Vivi > Cc: # v4.9+ > Signed-off-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/intel_fbc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c > index 74d425c700ef..a149f08c1b79 100644 > --- a/drivers/gpu/drm/i915/intel_fbc.c > +++ b/drivers/gpu/drm/i915/intel_fbc.c > @@ -1275,9 +1275,10 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv) > > static bool need_fbc_vtd_wa(struct drm_i915_private *dev_priv) > { > - /* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt */ > + /* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt,kbl,cfl */ The hsds seem to be saying that this was fixed in kbl/cnl. I guess the flicker could be due to a different vt-d vs. fbc issue. Is the chicken bit in CHICKEN_PIPESL in the correct position? Hmm. Bspec doesn't list chicken bit for glk. That would seem to suggest that we need this w/a for glk as well. > if (intel_vtd_active() && > - (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))) { > + (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv) || > + IS_KABYLAKE(dev_priv) || IS_COFFEELAKE(dev_priv))) { > DRM_INFO("Disabling framebuffer compression (FBC) to prevent screen flicker with VT-d enabled\n"); > return true; > } > -- > 2.17.1 -- Ville Syrjälä Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com ([192.55.52.136]:6373 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729421AbeIYVYJ (ORCPT ); Tue, 25 Sep 2018 17:24:09 -0400 Date: Tue, 25 Sep 2018 18:15:52 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Mika Kuoppala Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni , Chris Wilson , Rodrigo Vivi , stable@vger.kernel.org Subject: Re: [PATCH] drm/i915/fbc: Disable fbc with VT-d also with kbl and cfl Message-ID: <20180925151552.GJ9144@intel.com> References: <20180925133803.23677-1-mika.kuoppala@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180925133803.23677-1-mika.kuoppala@linux.intel.com> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Sep 25, 2018 at 04:38:03PM +0300, Mika Kuoppala wrote: > Using fbc with VT-d flickers also on kbl and cfl. > > Cc: Paulo Zanoni > Cc: Ville Syrj�l� > Cc: Chris Wilson > Cc: Rodrigo Vivi > Cc: # v4.9+ > Signed-off-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/intel_fbc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c > index 74d425c700ef..a149f08c1b79 100644 > --- a/drivers/gpu/drm/i915/intel_fbc.c > +++ b/drivers/gpu/drm/i915/intel_fbc.c > @@ -1275,9 +1275,10 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv) > > static bool need_fbc_vtd_wa(struct drm_i915_private *dev_priv) > { > - /* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt */ > + /* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt,kbl,cfl */ The hsds seem to be saying that this was fixed in kbl/cnl. I guess the flicker could be due to a different vt-d vs. fbc issue. Is the chicken bit in CHICKEN_PIPESL in the correct position? Hmm. Bspec doesn't list chicken bit for glk. That would seem to suggest that we need this w/a for glk as well. > if (intel_vtd_active() && > - (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))) { > + (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv) || > + IS_KABYLAKE(dev_priv) || IS_COFFEELAKE(dev_priv))) { > DRM_INFO("Disabling framebuffer compression (FBC) to prevent screen flicker with VT-d enabled\n"); > return true; > } > -- > 2.17.1 -- Ville Syrj�l� Intel