From: Rob Herring <robh@kernel.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: mchehab@kernel.org, mark.rutland@arm.com, kernel@pengutronix.de,
devicetree@vger.kernel.org, p.zabel@pengutronix.de,
javierm@redhat.com, laurent.pinchart@ideasonboard.com,
sakari.ailus@linux.intel.com, afshin.nasser@gmail.com,
linux-media@vger.kernel.org
Subject: Re: [PATCH v3 1/9] partial revert of "[media] tvp5150: add HW input connectors support"
Date: Tue, 25 Sep 2018 10:20:24 -0500 [thread overview]
Message-ID: <20180925152024.GA18900@bogus> (raw)
In-Reply-To: <20180918131453.21031-2-m.felsch@pengutronix.de>
On Tue, Sep 18, 2018 at 03:14:45PM +0200, Marco Felsch wrote:
> From: Javier Martinez Canillas <javierm@redhat.com>
>
> Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support")
> added input signals support for the tvp5150, but the approach was found
> to be incorrect so the corresponding DT binding commit 82c2ffeb217a
> ("[media] tvp5150: document input connectors DT bindings") was reverted.
>
> This left the driver with an undocumented (and wrong) DT parsing logic,
> so lets get rid of this code as well until the input connectors support
> is implemented properly.
>
> It's a partial revert due other patches added on top of mentioned commit
> not allowing the commit to be reverted cleanly anymore. But all the code
> related to the DT parsing logic and input entities creation are removed.
>
> Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> [m.felsch@pengutronix.de: rm TVP5150_INPUT_NUM define]
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> ---
> drivers/media/i2c/tvp5150.c | 141 ----------------------------
> include/dt-bindings/media/tvp5150.h | 2 -
> 2 files changed, 143 deletions(-)
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2018-09-25 15:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 13:14 [PATCH v3 0/9] TVP5150 fixes and new features Marco Felsch
2018-09-18 13:14 ` [PATCH v3 1/9] partial revert of "[media] tvp5150: add HW input connectors support" Marco Felsch
2018-09-25 15:20 ` Rob Herring [this message]
2018-09-18 13:14 ` [PATCH v3 2/9] media: tvp5150: fix irq_request error path during probe Marco Felsch
2018-10-30 23:21 ` Laurent Pinchart
2018-09-18 13:14 ` [PATCH v3 3/9] media: tvp5150: add input source selection of_graph support Marco Felsch
2018-09-18 13:14 ` [PATCH v3 4/9] media: dt-bindings: tvp5150: Add input port connectors DT bindings Marco Felsch
2018-09-26 22:49 ` Rob Herring
2018-09-18 13:14 ` [PATCH v3 5/9] media: v4l2-subdev: add stubs for v4l2_subdev_get_try_* Marco Felsch
2018-09-18 13:14 ` [PATCH v3 6/9] media: v4l2-subdev: fix v4l2_subdev_get_try_* dependency Marco Felsch
2018-09-19 10:45 ` Sakari Ailus
2018-09-19 12:37 ` Marco Felsch
2018-09-18 13:14 ` [PATCH v3 7/9] media: tvp5150: add FORMAT_TRY support for get/set selection handlers Marco Felsch
2018-09-18 13:14 ` [PATCH v3 8/9] media: tvp5150: initialize subdev before parsing device tree Marco Felsch
2018-09-18 13:14 ` [PATCH v3 9/9] media: tvp5150: add s_power callback Marco Felsch
2018-10-29 18:41 ` [PATCH v3 0/9] TVP5150 fixes and new features Marco Felsch
2018-11-09 13:46 ` Marco Felsch
2018-12-05 9:57 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925152024.GA18900@bogus \
--to=robh@kernel.org \
--cc=afshin.nasser@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=javierm@redhat.com \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.