From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 1/2] dt-bindings: Documentation for qcom,eud Date: Tue, 25 Sep 2018 14:25:07 -0500 Message-ID: <20180925192507.GA19360@bogus> References: <1536096853-30473-1-git-send-email-pheragu@codeaurora.org> <1536096853-30473-2-git-send-email-pheragu@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1536096853-30473-2-git-send-email-pheragu@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Prakruthi Deepak Heragu Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ckadabi@codeaurora.org, tsoni@codeaurora.org, rnayak@codeaurora.org, bryanh@codeaurora.org, psodagud@codeaurora.org, Satya Durga Srinivasu Prabhala List-Id: linux-arm-msm@vger.kernel.org On Tue, Sep 04, 2018 at 02:34:12PM -0700, Prakruthi Deepak Heragu wrote: > Documentation for Embedded USB Debugger (EUD) device tree bindings. > > Signed-off-by: Satya Durga Srinivasu Prabhala > Signed-off-by: Prakruthi Deepak Heragu > --- > .../devicetree/bindings/soc/qcom/qcom,msm-eud.txt | 41 ++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,msm-eud.txt > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,msm-eud.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,msm-eud.txt > new file mode 100644 > index 0000000..a03021a > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,msm-eud.txt > @@ -0,0 +1,41 @@ > +* Qualcomm Technologies Inc Embedded USB Debugger (EUD) > + > +The EUD (Embedded USB Debugger) is a mini-USB hub implemented > +on chip to support the USB-based debug and trace capabilities. Is it just for debug and normally bypassed? > + > +Required properties: > + > + - compatible: Should be "qcom,msm-eud" Needs to be SoC specific (though a fallback is fine). > + - interrupts: Interrupt number > + - reg: Should be address and size of EUD register space > + > +Driver notifies clients for VBUS attach/detach and charger enable/disable Bindings are for h/w blocks, not drivers. > +events. The link between client and EUD is established via a directed > +graph. EUD driver has one endpoint of the graph link mentioning EUD as an > +output link and clients registered for these notifications from the EUD > +should have the other endpoint of the graph link as an input link. OF graph is for describing data flows (i.e. h/w connections), not clients wanting some event. > Each of > +these endpoints should contain a 'remote-endpoint' phandle property that > +points to the corresponding endpoint in the port of the remote device. You don't need to describe how the graph binding works. Just what the port assignments are. I worry this is going to collide with using the graph binding for USB connectors. > + > +An example for EUD device node: > + > + eud: qcom,msm-eud@88e0000 { > + compatible = "qcom,msm-eud"; > + interrupts = ; > + reg = <0x88e0000 0x4000>; > + port { > + eud_output: endpoint { > + remote-endpoint = <&usb3_input>; > + }; > + }; > + }; > + > +An example for EUD client: What are possible clients? Could we want to switch clients at runtime? > + > + usb3 { > + port { > + usb3_input: endpoint { > + remote-endpoint = <&eud_output>; > + }; > + }; > + }; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,1/2] dt-bindings: Documentation for qcom,eud From: Rob Herring Message-Id: <20180925192507.GA19360@bogus> Date: Tue, 25 Sep 2018 14:25:07 -0500 To: Prakruthi Deepak Heragu Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ckadabi@codeaurora.org, tsoni@codeaurora.org, rnayak@codeaurora.org, bryanh@codeaurora.org, psodagud@codeaurora.org, Satya Durga Srinivasu Prabhala List-ID: T24gVHVlLCBTZXAgMDQsIDIwMTggYXQgMDI6MzQ6MTJQTSAtMDcwMCwgUHJha3J1dGhpIERlZXBh ayBIZXJhZ3Ugd3JvdGU6Cj4gRG9jdW1lbnRhdGlvbiBmb3IgRW1iZWRkZWQgVVNCIERlYnVnZ2Vy IChFVUQpIGRldmljZSB0cmVlIGJpbmRpbmdzLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFNhdHlhIER1 cmdhIFNyaW5pdmFzdSBQcmFiaGFsYSA8c2F0eWFwQGNvZGVhdXJvcmEub3JnPgo+IFNpZ25lZC1v ZmYtYnk6IFByYWtydXRoaSBEZWVwYWsgSGVyYWd1IDxwaGVyYWd1QGNvZGVhdXJvcmEub3JnPgo+ IC0tLQo+ICAuLi4vZGV2aWNldHJlZS9iaW5kaW5ncy9zb2MvcWNvbS9xY29tLG1zbS1ldWQudHh0 ICB8IDQxICsrKysrKysrKysrKysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDQxIGluc2Vy dGlvbnMoKykKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i aW5kaW5ncy9zb2MvcWNvbS9xY29tLG1zbS1ldWQudHh0Cj4gCj4gZGlmZiAtLWdpdCBhL0RvY3Vt ZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9zb2MvcWNvbS9xY29tLG1zbS1ldWQudHh0IGIv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3NvYy9xY29tL3Fjb20sbXNtLWV1ZC50 eHQKPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+IGluZGV4IDAwMDAwMDAuLmEwMzAyMWEKPiAtLS0g L2Rldi9udWxsCj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3NvYy9x Y29tL3Fjb20sbXNtLWV1ZC50eHQKPiBAQCAtMCwwICsxLDQxIEBACj4gKyogUXVhbGNvbW0gVGVj aG5vbG9naWVzIEluYyBFbWJlZGRlZCBVU0IgRGVidWdnZXIgKEVVRCkKPiArCj4gK1RoZSBFVUQg KEVtYmVkZGVkIFVTQiBEZWJ1Z2dlcikgaXMgYSBtaW5pLVVTQiBodWIgaW1wbGVtZW50ZWQKPiAr b24gY2hpcCB0byBzdXBwb3J0IHRoZSBVU0ItYmFzZWQgZGVidWcgYW5kIHRyYWNlIGNhcGFiaWxp dGllcy4KCklzIGl0IGp1c3QgZm9yIGRlYnVnIGFuZCBub3JtYWxseSBieXBhc3NlZD8gCgo+ICsK PiArUmVxdWlyZWQgcHJvcGVydGllczoKPiArCj4gKyAtIGNvbXBhdGlibGU6ICBTaG91bGQgYmUg InFjb20sbXNtLWV1ZCIKCk5lZWRzIHRvIGJlIFNvQyBzcGVjaWZpYyAodGhvdWdoIGEgZmFsbGJh Y2sgaXMgZmluZSkuCgo+ICsgLSBpbnRlcnJ1cHRzOiAgSW50ZXJydXB0IG51bWJlcgo+ICsgLSBy ZWc6IFNob3VsZCBiZSBhZGRyZXNzIGFuZCBzaXplIG9mIEVVRCByZWdpc3RlciBzcGFjZQo+ICsK PiArRHJpdmVyIG5vdGlmaWVzIGNsaWVudHMgZm9yIFZCVVMgYXR0YWNoL2RldGFjaCBhbmQgY2hh cmdlciBlbmFibGUvZGlzYWJsZQoKQmluZGluZ3MgYXJlIGZvciBoL3cgYmxvY2tzLCBub3QgZHJp dmVycy4KCj4gK2V2ZW50cy4gVGhlIGxpbmsgYmV0d2VlbiBjbGllbnQgYW5kIEVVRCBpcyBlc3Rh Ymxpc2hlZCB2aWEgYSBkaXJlY3RlZAo+ICtncmFwaC4gRVVEIGRyaXZlciBoYXMgb25lIGVuZHBv aW50IG9mIHRoZSBncmFwaCBsaW5rIG1lbnRpb25pbmcgRVVEIGFzIGFuCj4gK291dHB1dCBsaW5r IGFuZCBjbGllbnRzIHJlZ2lzdGVyZWQgZm9yIHRoZXNlIG5vdGlmaWNhdGlvbnMgZnJvbSB0aGUg RVVECj4gK3Nob3VsZCBoYXZlIHRoZSBvdGhlciBlbmRwb2ludCBvZiB0aGUgZ3JhcGggbGluayBh cyBhbiBpbnB1dCBsaW5rLiAKCk9GIGdyYXBoIGlzIGZvciBkZXNjcmliaW5nIGRhdGEgZmxvd3Mg KGkuZS4gaC93IGNvbm5lY3Rpb25zKSwgbm90IApjbGllbnRzIHdhbnRpbmcgc29tZSBldmVudC4K Cj4gRWFjaCBvZgo+ICt0aGVzZSBlbmRwb2ludHMgc2hvdWxkIGNvbnRhaW4gYSAncmVtb3RlLWVu ZHBvaW50JyBwaGFuZGxlIHByb3BlcnR5IHRoYXQKPiArcG9pbnRzIHRvIHRoZSBjb3JyZXNwb25k aW5nIGVuZHBvaW50IGluIHRoZSBwb3J0IG9mIHRoZSByZW1vdGUgZGV2aWNlLgoKWW91IGRvbid0 IG5lZWQgdG8gZGVzY3JpYmUgaG93IHRoZSBncmFwaCBiaW5kaW5nIHdvcmtzLiBKdXN0IHdoYXQg dGhlIApwb3J0IGFzc2lnbm1lbnRzIGFyZS4KCkkgd29ycnkgdGhpcyBpcyBnb2luZyB0byBjb2xs aWRlIHdpdGggdXNpbmcgdGhlIGdyYXBoIGJpbmRpbmcgZm9yIFVTQiAKY29ubmVjdG9ycy4KCj4g Kwo+ICtBbiBleGFtcGxlIGZvciBFVUQgZGV2aWNlIG5vZGU6Cj4gKwo+ICsJZXVkOiBxY29tLG1z bS1ldWRAODhlMDAwMCB7Cj4gKwkJY29tcGF0aWJsZSA9ICJxY29tLG1zbS1ldWQiOwo+ICsJCWlu dGVycnVwdHMgPSA8R0lDX1NQSSA0OTIgSVJRX1RZUEVfTEVWRUxfSElHSD47Cj4gKwkJcmVnID0g PDB4ODhlMDAwMCAweDQwMDA+Owo+ICsJCXBvcnQgewo+ICsgICAgICAgICAgICAgICAgCWV1ZF9v dXRwdXQ6IGVuZHBvaW50IHsKPiArICAgICAgICAgICAgICAgICAgICAgICAgCXJlbW90ZS1lbmRw b2ludCA9IDwmdXNiM19pbnB1dD47Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgIH07Cj4gKyAg ICAgICAgCX07Cj4gKwl9Owo+ICsKPiArQW4gZXhhbXBsZSBmb3IgRVVEIGNsaWVudDoKCldoYXQg YXJlIHBvc3NpYmxlIGNsaWVudHM/IENvdWxkIHdlIHdhbnQgdG8gc3dpdGNoIGNsaWVudHMgYXQg cnVudGltZT8KCj4gKwo+ICsJdXNiMyB7Cj4gKwkJcG9ydCB7Cj4gKyAgICAgICAgICAgICAgICAJ dXNiM19pbnB1dDogZW5kcG9pbnQgewo+ICsgICAgICAgICAgICAgICAgICAgICAgICAJcmVtb3Rl LWVuZHBvaW50ID0gPCZldWRfb3V0cHV0PjsKPiArICAgICAgICAgICAgICAgICAgICAgICAgfTsK PiArICAgICAgICAJfTsKPiArCX07Cj4gLS0gCj4gVGhlIFF1YWxjb21tIElubm92YXRpb24gQ2Vu dGVyLCBJbmMuIGlzIGEgbWVtYmVyIG9mIHRoZSBDb2RlIEF1cm9yYSBGb3J1bSwKPiBhIExpbnV4 IEZvdW5kYXRpb24gQ29sbGFib3JhdGl2ZSBQcm9qZWN0Cj4K