From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH, for-4.19] dma-mapping: add the missing ARCH_HAS_SYNC_DMA_FOR_CPU_ALL declaration Date: Tue, 25 Sep 2018 22:05:43 +0200 Message-ID: <20180925200542.GA8200@lst.de> References: <20180911090049.10747-1-hch@lst.de> <20180921061052.GA13705@lst.de> <20180921194218.at7ejkmmiucmawzo@pburton-laptop> <62B54A6B-6E10-4A40-8E61-C1D23A853816@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <62B54A6B-6E10-4A40-8E61-C1D23A853816-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Florian Fainelli Cc: "linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org" , Kevin Cernekee , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , Paul Burton , "robin.murphy-5wv7dgnIgG8@public.gmane.org" , Christoph Hellwig List-Id: iommu@lists.linux-foundation.org On Sat, Sep 22, 2018 at 12:24:33PM -0700, Florian Fainelli wrote: > >My thought would be that it would be ideal to fix in 4.19 since that's > >where the breakage is, but having said that I don't have much insight > >into how bad the breakage is for the affected systems. > > > AFAIR, DMA corruption is typically what you would observe, which could prove difficult if you are not exactly looking for it. In any case, I don't have a BMIPS system running 4.19 right now to exercise this on, but this looks correct: Well, I originally intended it for 4.19, but without reviews from the affected maintainers I'd fell bad about it. Now that we've got agreement I'll queue it for 4.19. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 25 Sep 2018 22:05:51 +0200 (CEST) Received: from verein.lst.de ([213.95.11.211]:52522 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23993941AbeIYUFndd7Fk (ORCPT ); Tue, 25 Sep 2018 22:05:43 +0200 Received: by newverein.lst.de (Postfix, from userid 2407) id 1C5EA68AEF; Tue, 25 Sep 2018 22:05:43 +0200 (CEST) Date: Tue, 25 Sep 2018 22:05:43 +0200 From: Christoph Hellwig To: Florian Fainelli Cc: Paul Burton , Christoph Hellwig , Kevin Cernekee , "linux-mips@linux-mips.org" , "robin.murphy@arm.com" , "iommu@lists.linux-foundation.org" Subject: Re: [PATCH, for-4.19] dma-mapping: add the missing ARCH_HAS_SYNC_DMA_FOR_CPU_ALL declaration Message-ID: <20180925200542.GA8200@lst.de> References: <20180911090049.10747-1-hch@lst.de> <20180921061052.GA13705@lst.de> <20180921194218.at7ejkmmiucmawzo@pburton-laptop> <62B54A6B-6E10-4A40-8E61-C1D23A853816@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <62B54A6B-6E10-4A40-8E61-C1D23A853816@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 66559 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: hch@lst.de Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Sat, Sep 22, 2018 at 12:24:33PM -0700, Florian Fainelli wrote: > >My thought would be that it would be ideal to fix in 4.19 since that's > >where the breakage is, but having said that I don't have much insight > >into how bad the breakage is for the affected systems. > > > AFAIR, DMA corruption is typically what you would observe, which could prove difficult if you are not exactly looking for it. In any case, I don't have a BMIPS system running 4.19 right now to exercise this on, but this looks correct: Well, I originally intended it for 4.19, but without reviews from the affected maintainers I'd fell bad about it. Now that we've got agreement I'll queue it for 4.19.