All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@infradead.org (Christoph Hellwig)
Subject: nvmet: Kernel v4.19-rc4 circular locking complaint
Date: Tue, 25 Sep 2018 16:27:45 -0700	[thread overview]
Message-ID: <20180925232745.GA28388@infradead.org> (raw)
In-Reply-To: <1537465780.224533.19.camel@acm.org>

On Thu, Sep 20, 2018@10:49:40AM -0700, Bart Van Assche wrote:
> Hello,
> 
> Here is another complaint that appeared while running the nvmeof-mp tests.
> Sagi, I have Cc-ed you because I think that this complaint may be related
> to the flush_scheduled_work() call that was inserted in
> nvmet_rdma_queue_connect() by commit 777dc82395de ("nvmet-rdma: occasionally
> flush ongoing controller teardown"). It seems weird to me that work is
> flushed from the context of an RDMA/CM handler, which is running in the
> context of a work item itself.

Yes, this seems pretty dangerous.  For now I'm tempted to revert the
commit.  Sagi?

  reply	other threads:[~2018-09-25 23:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-20 17:49 nvmet: Kernel v4.19-rc4 circular locking complaint Bart Van Assche
2018-09-25 23:27 ` Christoph Hellwig [this message]
2018-09-26  5:38 ` Sagi Grimberg
2018-09-27 15:42   ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180925232745.GA28388@infradead.org \
    --to=hch@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.