From: Paul Mackerras <paulus@ozlabs.org>
To: kvm-ppc@vger.kernel.org
Subject: Re: [RFC PATCH 12/32] powerpc: Provide dummy versions of plpar_hcall functions when !CONFIG_PPC_PSER
Date: Wed, 26 Sep 2018 11:21:06 +0000 [thread overview]
Message-ID: <20180926112106.GD29799@fergus> (raw)
In-Reply-To: <1537524123-9578-13-git-send-email-paulus@ozlabs.org>
On Wed, Sep 26, 2018 at 01:30:40PM +1000, David Gibson wrote:
> On Fri, Sep 21, 2018 at 08:01:43PM +1000, Paul Mackerras wrote:
> > This will reduce the number of instances where we require ifdefs in
> > code which needs to call a hypercall on a pseries platform or do
> > something different on a powernv platform.
> >
> > Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
>
> Wouldn't it make more sense for these to BUG_ON() or at least
> WARN_ON() before returning H_FUNCTION, since calling a hypercall on a
> non pseries platform is definitely a kernel bug?
Not BUG_ON, since at this level we have no indication that the kernel
can't continue executing without whatever it was that it expected the
hcall to do. I could come at a WARN_ON (or WARN_ON_ONCE) -- I'll talk
to mpe and see what he thinks.
Paul.
prev parent reply other threads:[~2018-09-26 11:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 10:01 [RFC PATCH 12/32] powerpc: Provide dummy versions of plpar_hcall functions when !CONFIG_PPC_PSERIES Paul Mackerras
2018-09-26 3:30 ` [RFC PATCH 12/32] powerpc: Provide dummy versions of plpar_hcall functions when !CONFIG_PPC_PSER David Gibson
2018-09-26 11:21 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180926112106.GD29799@fergus \
--to=paulus@ozlabs.org \
--cc=kvm-ppc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.