From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rapoport Subject: Re: [PATCH 14/30] memblock: add align parameter to memblock_alloc_node() Date: Wed, 26 Sep 2018 16:43:35 +0300 Message-ID: <20180926134335.GF4628@rapoport-lnx> References: <1536927045-23536-1-git-send-email-rppt@linux.vnet.ibm.com> <1536927045-23536-15-git-send-email-rppt@linux.vnet.ibm.com> <20180926093127.GO6278@dhcp22.suse.cz> <20180926093648.GP6278@dhcp22.suse.cz> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20180926093648.GP6278@dhcp22.suse.cz> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michal Hocko Cc: linux-mm@kvack.org, Andrew Morton , Catalin Marinas , Chris Zankel , "David S. Miller" , Geert Uytterhoeven , Greentime Hu , Greg Kroah-Hartman , Guan Xuetao , Ingo Molnar , "James E.J. Bottomley" , Jonas Bonn , Jonathan Corbet , Ley Foon Tan , Mark Salter , Martin Schwidefsky , Matt Turner , Michael Ellerman , Michal Simek , Palmer Dabbelt , Paul Burton

On Wed, Sep 26, 2018 at 11:36:48AM +0200, Michal Hocko wrote: > On Wed 26-09-18 11:31:27, Michal Hocko wrote: > > On Fri 14-09-18 15:10:29, Mike Rapoport wrote: > > > With the align parameter memblock_alloc_node() can be used as drop in > > > replacement for alloc_bootmem_pages_node() and __alloc_bootmem_node(), > > > which is done in the following patches. > > > > /me confused. Why do we need this patch at all? Maybe it should be > > folded into the later patch you are refereing here? > > OK, I can see 1536927045-23536-17-git-send-email-rppt@linux.vnet.ibm.com > now. If you are going to repost for whatever reason please merge those > two. Also I would get rid of the implicit "0 implies SMP_CACHE_BYTES" > behavior. It is subtle and you have to dig deep to find that out. Why > not make it explicit? Agree. I'd just prefer to make it a separate patch rather then resend the whole series. > -- > Michal Hocko > SUSE Labs > -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rapoport Date: Wed, 26 Sep 2018 13:43:35 +0000 Subject: Re: [PATCH 14/30] memblock: add align parameter to memblock_alloc_node() Message-Id: <20180926134335.GF4628@rapoport-lnx> List-Id: References: <1536927045-23536-1-git-send-email-rppt@linux.vnet.ibm.com> <1536927045-23536-15-git-send-email-rppt@linux.vnet.ibm.com> <20180926093127.GO6278@dhcp22.suse.cz> <20180926093648.GP6278@dhcp22.suse.cz> In-Reply-To: <20180926093648.GP6278@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michal Hocko Cc: linux-mm@kvack.org, Andrew Morton , Catalin Marinas , Chris Zankel , "David S. Miller" , Geert Uytterhoeven , Greentime Hu , Greg Kroah-Hartman , Guan Xuetao , Ingo Molnar , "James E.J. Bottomley" , Jonas Bonn , Jonathan Corbet , Ley Foon Tan , Mark Salter , Martin Schwidefsky , Matt Turner , Michael Ellerman , Michal Simek , Palmer Dabbelt , Paul Burton , Richard Kuo , Richard Weinberger , Rich Felker , Russell King , Serge Semin , Thomas Gleixner , Tony Luck , Vineet Gupta , Yoshinori Sato , linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@linux-mips.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, nios2-dev@lists.rocketboards.org, openrisc@lists.librecores.org, sparclinux@vger.kernel.org, uclinux-h8-devel@lists.sourceforge.jp On Wed, Sep 26, 2018 at 11:36:48AM +0200, Michal Hocko wrote: > On Wed 26-09-18 11:31:27, Michal Hocko wrote: > > On Fri 14-09-18 15:10:29, Mike Rapoport wrote: > > > With the align parameter memblock_alloc_node() can be used as drop in > > > replacement for alloc_bootmem_pages_node() and __alloc_bootmem_node(), > > > which is done in the following patches. > > > > /me confused. Why do we need this patch at all? Maybe it should be > > folded into the later patch you are refereing here? > > OK, I can see 1536927045-23536-17-git-send-email-rppt@linux.vnet.ibm.com > now. If you are going to repost for whatever reason please merge those > two. Also I would get rid of the implicit "0 implies SMP_CACHE_BYTES" > behavior. It is subtle and you have to dig deep to find that out. Why > not make it explicit? Agree. I'd just prefer to make it a separate patch rather then resend the whole series. > -- > Michal Hocko > SUSE Labs > -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 26 Sep 2018 15:44:01 +0200 (CEST) Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:38626 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S23991082AbeIZNn64sYXs (ORCPT ); Wed, 26 Sep 2018 15:43:58 +0200 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w8QDdJDo058599 for ; Wed, 26 Sep 2018 09:43:57 -0400 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0b-001b2d01.pphosted.com with ESMTP id 2mr9qnn756-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 26 Sep 2018 09:43:57 -0400 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 26 Sep 2018 14:43:54 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 26 Sep 2018 14:43:41 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w8QDheYJ66191598 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 26 Sep 2018 13:43:41 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6C388AE051; Wed, 26 Sep 2018 16:42:40 +0100 (BST) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2AC3AAE04D; Wed, 26 Sep 2018 16:42:37 +0100 (BST) Received: from rapoport-lnx (unknown [9.148.8.124]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Wed, 26 Sep 2018 16:42:37 +0100 (BST) Date: Wed, 26 Sep 2018 16:43:35 +0300 From: Mike Rapoport To: Michal Hocko Cc: linux-mm@kvack.org, Andrew Morton , Catalin Marinas , Chris Zankel , "David S. Miller" , Geert Uytterhoeven , Greentime Hu , Greg Kroah-Hartman , Guan Xuetao , Ingo Molnar , "James E.J. Bottomley" , Jonas Bonn , Jonathan Corbet , Ley Foon Tan , Mark Salter , Martin Schwidefsky , Matt Turner , Michael Ellerman , Michal Simek , Palmer Dabbelt , Paul Burton , Richard Kuo , Richard Weinberger , Rich Felker , Russell King , Serge Semin , Thomas Gleixner , Tony Luck , Vineet Gupta , Yoshinori Sato , linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@linux-mips.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, nios2-dev@lists.rocketboards.org, openrisc@lists.librecores.org, sparclinux@vger.kernel.org, uclinux-h8-devel@lists.sourceforge.jp Subject: Re: [PATCH 14/30] memblock: add align parameter to memblock_alloc_node() References: <1536927045-23536-1-git-send-email-rppt@linux.vnet.ibm.com> <1536927045-23536-15-git-send-email-rppt@linux.vnet.ibm.com> <20180926093127.GO6278@dhcp22.suse.cz> <20180926093648.GP6278@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180926093648.GP6278@dhcp22.suse.cz> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 18092613-0016-0000-0000-0000020ADB24 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18092613-0017-0000-0000-00003261FAEB Message-Id: <20180926134335.GF4628@rapoport-lnx> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-09-26_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=864 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809260134 Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 66580 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: rppt@linux.vnet.ibm.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Wed, Sep 26, 2018 at 11:36:48AM +0200, Michal Hocko wrote: > On Wed 26-09-18 11:31:27, Michal Hocko wrote: > > On Fri 14-09-18 15:10:29, Mike Rapoport wrote: > > > With the align parameter memblock_alloc_node() can be used as drop in > > > replacement for alloc_bootmem_pages_node() and __alloc_bootmem_node(), > > > which is done in the following patches. > > > > /me confused. Why do we need this patch at all? Maybe it should be > > folded into the later patch you are refereing here? > > OK, I can see 1536927045-23536-17-git-send-email-rppt@linux.vnet.ibm.com > now. If you are going to repost for whatever reason please merge those > two. Also I would get rid of the implicit "0 implies SMP_CACHE_BYTES" > behavior. It is subtle and you have to dig deep to find that out. Why > not make it explicit? Agree. I'd just prefer to make it a separate patch rather then resend the whole series. > -- > Michal Hocko > SUSE Labs > -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rapoport Subject: Re: [PATCH 14/30] memblock: add align parameter to memblock_alloc_node() Date: Wed, 26 Sep 2018 16:43:35 +0300 Message-ID: <20180926134335.GF4628@rapoport-lnx> References: <1536927045-23536-1-git-send-email-rppt@linux.vnet.ibm.com> <1536927045-23536-15-git-send-email-rppt@linux.vnet.ibm.com> <20180926093127.GO6278@dhcp22.suse.cz> <20180926093648.GP6278@dhcp22.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-mm@kvack.org, Andrew Morton , Catalin Marinas , Chris Zankel , "David S. Miller" , Geert Uytterhoeven , Greentime Hu , Greg Kroah-Hartman , Guan Xuetao , Ingo Molnar , "James E.J. Bottomley" , Jonas Bonn , Jonathan Corbet , Ley Foon Tan , Mark Salter , Martin Schwidefsky , Matt Turner , Michael Ellerman , Michal Simek , Palmer Dabbelt , Paul Burton

Return-path: In-Reply-To: <20180926093648.GP6278@dhcp22.suse.cz> List-ID: List-Id: linux-parisc.vger.kernel.org On Wed, Sep 26, 2018 at 11:36:48AM +0200, Michal Hocko wrote: > On Wed 26-09-18 11:31:27, Michal Hocko wrote: > > On Fri 14-09-18 15:10:29, Mike Rapoport wrote: > > > With the align parameter memblock_alloc_node() can be used as drop in > > > replacement for alloc_bootmem_pages_node() and __alloc_bootmem_node(), > > > which is done in the following patches. > > > > /me confused. Why do we need this patch at all? Maybe it should be > > folded into the later patch you are refereing here? > > OK, I can see 1536927045-23536-17-git-send-email-rppt@linux.vnet.ibm.com > now. If you are going to repost for whatever reason please merge those > two. Also I would get rid of the implicit "0 implies SMP_CACHE_BYTES" > behavior. It is subtle and you have to dig deep to find that out. Why > not make it explicit? Agree. I'd just prefer to make it a separate patch rather then resend the whole series. > -- > Michal Hocko > SUSE Labs > -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 From: rppt@linux.vnet.ibm.com (Mike Rapoport) Date: Wed, 26 Sep 2018 16:43:35 +0300 Subject: [PATCH 14/30] memblock: add align parameter to memblock_alloc_node() In-Reply-To: <20180926093648.GP6278@dhcp22.suse.cz> References: <1536927045-23536-1-git-send-email-rppt@linux.vnet.ibm.com> <1536927045-23536-15-git-send-email-rppt@linux.vnet.ibm.com> <20180926093127.GO6278@dhcp22.suse.cz> <20180926093648.GP6278@dhcp22.suse.cz> Message-ID: <20180926134335.GF4628@rapoport-lnx> To: linux-riscv@lists.infradead.org List-Id: linux-riscv.lists.infradead.org On Wed, Sep 26, 2018 at 11:36:48AM +0200, Michal Hocko wrote: > On Wed 26-09-18 11:31:27, Michal Hocko wrote: > > On Fri 14-09-18 15:10:29, Mike Rapoport wrote: > > > With the align parameter memblock_alloc_node() can be used as drop in > > > replacement for alloc_bootmem_pages_node() and __alloc_bootmem_node(), > > > which is done in the following patches. > > > > /me confused. Why do we need this patch at all? Maybe it should be > > folded into the later patch you are refereing here? > > OK, I can see 1536927045-23536-17-git-send-email-rppt at linux.vnet.ibm.com > now. If you are going to repost for whatever reason please merge those > two. Also I would get rid of the implicit "0 implies SMP_CACHE_BYTES" > behavior. It is subtle and you have to dig deep to find that out. Why > not make it explicit? Agree. I'd just prefer to make it a separate patch rather then resend the whole series. > -- > Michal Hocko > SUSE Labs > -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B386C43382 for ; Wed, 26 Sep 2018 13:46:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5198208E4 for ; Wed, 26 Sep 2018 13:46:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eixhGmY3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5198208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:In-Reply-To:MIME-Version: References:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ucFJuEdDwCeKwJS6f4lTVA1CRr724nWGMLHQUgUlCqU=; b=eixhGmY301n3HE 42wR2kMBZ8rPnDwBxPgqXgPmRTw1Z4r+Xm0YXQrRrdu23njfaKzaLJOk6o5S/FLojqmIMC1xaS4Yp rIw2KteinX2+FOxu53Mtk2DhZVi3dbXd5bzyJrsyVNp5Icu4R4hruwW7n051+K0Lm4QeBTt/+pCDP oHf6Hq0TSoT+bx/B2jQhXgdB1jhU+H+IDBUeHaGrXnlPueNFrVphEo2cXtJ5X0q3TWfbisUkc/Ld2 x3e0xx1FDIkItoxRY/0Az9ctdZ6raLRXvKCUfsFCfbZvJPLLEp2UsGXqyE0n5QOlTVFuOX8WKkAHS TrEpxE+gphO2hJweQp4A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1g5A9U-0000x0-KG; Wed, 26 Sep 2018 13:46:52 +0000 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5] helo=mx0a-001b2d01.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1g5A7B-0006zN-1V for linux-riscv@lists.infradead.org; Wed, 26 Sep 2018 13:44:38 +0000 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w8QDdIkA134003 for ; Wed, 26 Sep 2018 09:43:58 -0400 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0a-001b2d01.pphosted.com with ESMTP id 2mr9vumnn6-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 26 Sep 2018 09:43:58 -0400 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 26 Sep 2018 14:43:54 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 26 Sep 2018 14:43:41 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w8QDheYJ66191598 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 26 Sep 2018 13:43:41 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6C388AE051; Wed, 26 Sep 2018 16:42:40 +0100 (BST) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2AC3AAE04D; Wed, 26 Sep 2018 16:42:37 +0100 (BST) Received: from rapoport-lnx (unknown [9.148.8.124]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Wed, 26 Sep 2018 16:42:37 +0100 (BST) Date: Wed, 26 Sep 2018 16:43:35 +0300 From: Mike Rapoport To: Michal Hocko Subject: Re: [PATCH 14/30] memblock: add align parameter to memblock_alloc_node() References: <1536927045-23536-1-git-send-email-rppt@linux.vnet.ibm.com> <1536927045-23536-15-git-send-email-rppt@linux.vnet.ibm.com> <20180926093127.GO6278@dhcp22.suse.cz> <20180926093648.GP6278@dhcp22.suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180926093648.GP6278@dhcp22.suse.cz> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 18092613-0016-0000-0000-0000020ADB24 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18092613-0017-0000-0000-00003261FAEB Message-Id: <20180926134335.GF4628@rapoport-lnx> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-09-26_06:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=875 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809260134 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180926_064429_248599_16F61D09 X-CRM114-Status: GOOD ( 24.97 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mips@linux-mips.org, Rich Felker , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Catalin Marinas , Palmer Dabbelt , Russell King , linux-mm@kvack.org, sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-riscv@lists.infradead.org, Jonas Bonn , linux-s390@vger.kernel.org, linux-c6x-dev@linux-c6x.org, Yoshinori Sato , Jonathan Corbet , Michael Ellerman , "James E.J. Bottomley" , Ingo Molnar , Geert Uytterhoeven , Mark Salter , Matt Turner , linux-snps-arc@lists.infradead.org, uclinux-h8-devel@lists.sourceforge.jp, linux-alpha@vger.kernel.org, linux-um@lists.infradead.org, linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org, Greentime Hu , nios2-dev@lists.rocketboards.org, Thomas Gleixner , Guan Xuetao , linux-arm-kernel@lists.infradead.org, Chris Zankel , Michal Simek , Tony Luck , linux-parisc@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Serge Semin , Richard Kuo , Paul Burton , Vineet Gupta , Richard Weinberger , Martin Schwidefsky , Ley Foon Tan , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org Message-ID: <20180926134335.HmE9-NRHkkbzt8irdcQ03WzfDQdJzexERaqV56qSdWI@z> On Wed, Sep 26, 2018 at 11:36:48AM +0200, Michal Hocko wrote: > On Wed 26-09-18 11:31:27, Michal Hocko wrote: > > On Fri 14-09-18 15:10:29, Mike Rapoport wrote: > > > With the align parameter memblock_alloc_node() can be used as drop in > > > replacement for alloc_bootmem_pages_node() and __alloc_bootmem_node(), > > > which is done in the following patches. > > > > /me confused. Why do we need this patch at all? Maybe it should be > > folded into the later patch you are refereing here? > > OK, I can see 1536927045-23536-17-git-send-email-rppt@linux.vnet.ibm.com > now. If you are going to repost for whatever reason please merge those > two. Also I would get rid of the implicit "0 implies SMP_CACHE_BYTES" > behavior. It is subtle and you have to dig deep to find that out. Why > not make it explicit? Agree. I'd just prefer to make it a separate patch rather then resend the whole series. > -- > Michal Hocko > SUSE Labs > -- Sincerely yours, Mike. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 From: rppt@linux.vnet.ibm.com (Mike Rapoport) Date: Wed, 26 Sep 2018 16:43:35 +0300 Subject: [PATCH 14/30] memblock: add align parameter to memblock_alloc_node() In-Reply-To: <20180926093648.GP6278@dhcp22.suse.cz> References: <1536927045-23536-1-git-send-email-rppt@linux.vnet.ibm.com> <1536927045-23536-15-git-send-email-rppt@linux.vnet.ibm.com> <20180926093127.GO6278@dhcp22.suse.cz> <20180926093648.GP6278@dhcp22.suse.cz> List-ID: Message-ID: <20180926134335.GF4628@rapoport-lnx> To: linux-snps-arc@lists.infradead.org On Wed, Sep 26, 2018@11:36:48AM +0200, Michal Hocko wrote: > On Wed 26-09-18 11:31:27, Michal Hocko wrote: > > On Fri 14-09-18 15:10:29, Mike Rapoport wrote: > > > With the align parameter memblock_alloc_node() can be used as drop in > > > replacement for alloc_bootmem_pages_node() and __alloc_bootmem_node(), > > > which is done in the following patches. > > > > /me confused. Why do we need this patch at all? Maybe it should be > > folded into the later patch you are refereing here? > > OK, I can see 1536927045-23536-17-git-send-email-rppt at linux.vnet.ibm.com > now. If you are going to repost for whatever reason please merge those > two. Also I would get rid of the implicit "0 implies SMP_CACHE_BYTES" > behavior. It is subtle and you have to dig deep to find that out. Why > not make it explicit? Agree. I'd just prefer to make it a separate patch rather then resend the whole series. > -- > Michal Hocko > SUSE Labs > -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rapoport Date: Wed, 26 Sep 2018 16:43:35 +0300 Subject: [OpenRISC] [PATCH 14/30] memblock: add align parameter to memblock_alloc_node() In-Reply-To: <20180926093648.GP6278@dhcp22.suse.cz> References: <1536927045-23536-1-git-send-email-rppt@linux.vnet.ibm.com> <1536927045-23536-15-git-send-email-rppt@linux.vnet.ibm.com> <20180926093127.GO6278@dhcp22.suse.cz> <20180926093648.GP6278@dhcp22.suse.cz> Message-ID: <20180926134335.GF4628@rapoport-lnx> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: openrisc@lists.librecores.org On Wed, Sep 26, 2018 at 11:36:48AM +0200, Michal Hocko wrote: > On Wed 26-09-18 11:31:27, Michal Hocko wrote: > > On Fri 14-09-18 15:10:29, Mike Rapoport wrote: > > > With the align parameter memblock_alloc_node() can be used as drop in > > > replacement for alloc_bootmem_pages_node() and __alloc_bootmem_node(), > > > which is done in the following patches. > > > > /me confused. Why do we need this patch at all? Maybe it should be > > folded into the later patch you are refereing here? > > OK, I can see 1536927045-23536-17-git-send-email-rppt at linux.vnet.ibm.com > now. If you are going to repost for whatever reason please merge those > two. Also I would get rid of the implicit "0 implies SMP_CACHE_BYTES" > behavior. It is subtle and you have to dig deep to find that out. Why > not make it explicit? Agree. I'd just prefer to make it a separate patch rather then resend the whole series. > -- > Michal Hocko > SUSE Labs > -- Sincerely yours, Mike.