From: Thierry Reding <thierry.reding@gmail.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: linux-tegra@vger.kernel.org, Mikko Perttunen <cyndis@kapsi.fi>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] gpu: host1x: Remove redundant of_dma_configure() call
Date: Wed, 26 Sep 2018 16:13:40 +0200 [thread overview]
Message-ID: <20180926141340.GB12980@ulmo> (raw)
In-Reply-To: <20180926141054.GA12980@ulmo>
[-- Attachment #1.1: Type: text/plain, Size: 975 bytes --]
On Wed, Sep 26, 2018 at 04:10:54PM +0200, Thierry Reding wrote:
> On Wed, Sep 12, 2018 at 05:47:54PM +0100, Robin Murphy wrote:
> > Now that the Host1x bus_type implements a .dma_configure callback,
> > subdevices should automatically get configured for DMA as their drivers
> > bind, so there's no need to also force it at device creation time.
> >
> > CC: Thierry Reding <thierry.reding@gmail.com>
> > CC: Mikko Perttunen <cyndis@kapsi.fi>
> > Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> > ---
> >
> > I *believe* my reasoning is correct here, but please shout if it's not.
> >
> > drivers/gpu/host1x/bus.c | 2 --
> > 1 file changed, 2 deletions(-)
>
> Applied, thanks.
Actually I was a little too quick on the trigger there. I don't think we
can remove this here because the of_dma_configure() in this call
configures the logical "compound" child device, whereas the
.dma_configure callback configures the physical device.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-09-26 14:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 16:47 [PATCH] gpu: host1x: Remove redundant of_dma_configure() call Robin Murphy
2018-09-26 14:10 ` Thierry Reding
2018-09-26 14:13 ` Thierry Reding [this message]
2018-09-26 14:29 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180926141340.GB12980@ulmo \
--to=thierry.reding@gmail.com \
--cc=cyndis@kapsi.fi \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.