From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1,1/7] dt-bindings: stm32-dma: Add DMA/MDMA chaining support bindings From: Rob Herring Message-Id: <20180926202112.GA6426@bogus> Date: Wed, 26 Sep 2018 15:21:12 -0500 To: Pierre-Yves MORDRET Cc: Vinod Koul , Mark Rutland , Alexandre Torgue , Maxime Coquelin , Dan Williams , devicetree@vger.kernel.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-ID: T24gVHVlLCBTZXAgMTEsIDIwMTggYXQgMDk6MjY6NTRBTSArMDIwMCwgUGllcnJlLVl2ZXMgTU9S RFJFVCB3cm90ZToKPiBUaGlzIHBhdGNoIGFkZHMgZG1hIGJpbmRpbmdzIHRvIHN1cHBvcnQgRE1B L01ETUEgY2hhaW5pbmcgdHJhbnNmZXIuCj4gMSBiaXQgaXMgdG8gbWFuYWdlIGJvdGggRE1BIEZJ Rk8gVGhyZXNob2xkCj4gMSBiaXQgaXMgdG8gbWFuYWdlIERNQS9NRE1BIENoYWluaW5nIGZlYXR1 cmVzLgo+IDIgYml0cyBhcmUgdXNlZCB0byBzcGVjaWZ5IFNEUkFNIHNpemUgdG8gdXNlIGZvciBE TUEvTURNQSBjaGFpbmluZy4KPiBUaGUgc2l6ZSBpbiBieXRlcyBvZiBhIGNlcnRhaW4gb3JkZXIg aXMgZ2l2ZW4gYnkgdGhlIGZvcm11bGE6Cj4gICAgICgyIF4gb3JkZXIpICogUEFHRV9TSVpFLgo+ IFRoZSBvcmRlciBpcyBnaXZlbiBieSB0aG9zZSAyIGJpdHMuCj4gRm9yIGN5Y2xpYywgd2hldGhl ciBjaGFpbmluZyBpcyBjaG9zZW4sIGFueSB2YWx1ZSBhYm92ZSAxIGNhbiBiZSBzZXQgOgo+IFNS QU0gYnVmZmVyIHNpemUgd2lsbCByZWx5IG9uIHBlcmlvZCBzaXplIGFuZCBub3Qgb24gdGhpcyBE VCB2YWx1ZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBQaWVycmUtWXZlcyBNT1JEUkVUIDxwaWVycmUt eXZlcy5tb3JkcmV0QHN0LmNvbT4KPiAtLS0KPiAgIFZlcnNpb24gaGlzdG9yeToKPiAgICAgdjE6 Cj4gICAgICAgICogSW5pdGlhbAo+IC0tLQo+IC0tLQo+ICAuLi4vZGV2aWNldHJlZS9iaW5kaW5n cy9kbWEvc3RtMzItZG1hLnR4dCAgICAgICAgICB8IDMyICsrKysrKysrKysrKysrKysrKystLS0K PiAgMSBmaWxlIGNoYW5nZWQsIDI4IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gCj4g ZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kbWEvc3RtMzIt ZG1hLnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kbWEvc3RtMzItZG1h LnR4dAo+IGluZGV4IGM1ZjUxOTAuLjE2M2JlMDkgMTAwNjQ0Cj4gLS0tIGEvRG9jdW1lbnRhdGlv bi9kZXZpY2V0cmVlL2JpbmRpbmdzL2RtYS9zdG0zMi1kbWEudHh0Cj4gKysrIGIvRG9jdW1lbnRh dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2RtYS9zdG0zMi1kbWEudHh0Cj4gQEAgLTE3LDYgKzE3 LDEyIEBAIE9wdGlvbmFsIHByb3BlcnRpZXM6Cj4gIC0gcmVzZXRzOiBSZWZlcmVuY2UgdG8gYSBy ZXNldCBjb250cm9sbGVyIGFzc2VydGluZyB0aGUgRE1BIGNvbnRyb2xsZXIKPiAgLSBzdCxtZW0y bWVtOiBib29sZWFuOyBpZiBkZWZpbmVkLCBpdCBpbmRpY2F0ZXMgdGhhdCB0aGUgY29udHJvbGxl ciBzdXBwb3J0cwo+ICAgIG1lbW9yeS10by1tZW1vcnkgdHJhbnNmZXIKPiArLSBkbWFzOiBBIGxp c3Qgb2YgZWlnaHQgZG1hIHNwZWNpZmllcnMsIG9uZSBmb3IgZWFjaCBlbnRyeSBpbiBkbWEtbmFt ZXMuCj4gKyAgUmVmZXIgdG8gc3RtMzItbWRtYS50eHQgZm9yIG1vcmUgZGV0YWlscy4KPiArLSBk bWEtbmFtZXM6IHNob3VsZCBjb250YWluICJjaDAiLCAiY2gxIiwgImNoMiIsICJjaDMiLCAiY2g0 IiwgImNoNSIsICJjaDYiIGFuZAo+ICsgICJjaDciIGFuZCByZXByZXNlbnRzIGVhY2ggU1RNMzIg RE1BIGNoYW5uZWwgY29ubmVjdGVkIHRvIGEgU1RNMzIgTURNQSBvbmUuCj4gKy0gbWVtb3J5LXJl Z2lvbiA6IHBoYW5kbGUgdG8gYSBub2RlIGRlc2NyaWJpbmcgbWVtb3J5IHRvIGJlIHVzZWQgZm9y Cj4gKyAgTTJNIGludGVybWVkaWF0ZSB0cmFuc2ZlciBiZXR3ZWVuIERNQSBhbmQgTURNQS4KPiAg Cj4gIEV4YW1wbGU6Cj4gIAo+IEBAIC0zNiw2ICs0MiwxNiBAQCBFeGFtcGxlOgo+ICAJCXN0LG1l bTJtZW07Cj4gIAkJcmVzZXRzID0gPCZyY2MgMTUwPjsKPiAgCQlkbWEtcmVxdWVzdHMgPSA8OD47 Cj4gKwkJZG1hcyA9IDwmbWRtYTEgOCAweDEwIDB4MTIwMDAwMGEgMHg0MDAyNjQwOCAweDAwMDAw MDIwIDE+LAo+ICsJCSAgICAgICA8Jm1kbWExIDkgMHgxMCAweDEyMDAwMDBhIDB4NDAwMjY0MDgg MHgwMDAwMDgwMCAxPiwKPiArCQkgICAgICAgPCZtZG1hMSAxMCAweDEwIDB4MTIwMDAwMGEgMHg0 MDAyNjQwOCAweDAwMjAwMDAwIDE+LAo+ICsJCSAgICAgICA8Jm1kbWExIDExIDB4MTAgMHgxMjAw MDAwYSAweDQwMDI2NDA4IDB4MDgwMDAwMDAgMT4sCj4gKwkJICAgICAgIDwmbWRtYTEgMTIgMHgx MCAweDEyMDAwMDBhIDB4NDAwMjY0MEMgMHgwMDAwMDAyMCAxPiwKPiArCQkgICAgICAgPCZtZG1h MSAxMyAweDEwIDB4MTIwMDAwMGEgMHg0MDAyNjQwQyAweDAwMDAwODAwIDE+LAo+ICsJCSAgICAg ICA8Jm1kbWExIDE0IDB4MTAgMHgxMjAwMDAwYSAweDQwMDI2NDBDIDB4MDAyMDAwMDAgMT4sCj4g KwkJICAgICAgIDwmbWRtYTEgMTUgMHgxMCAweDEyMDAwMDBhIDB4NDAwMjY0MEMgMHgwODAwMDAw MCAxPjsKPiArCQlkbWEtbmFtZXMgPSAiY2gwIiwgImNoMSIsICJjaDIiLCAiY2gzIiwgImNoNCIs ICJjaDUiLCAiY2g2IiwgImNoNyI7Cj4gKwkJbWVtb3J5LXJlZ2lvbiA9IDwmc3JhbV9kbWFwb29s PjsKPiAgCX07Cj4gIAo+ICAqIERNQSBjbGllbnQKPiBAQCAtNjIsMTMgKzc4LDIxIEBAIGNoYW5u ZWw6IGEgcGhhbmRsZSB0byB0aGUgRE1BIGNvbnRyb2xsZXIgcGx1cyB0aGUgZm9sbG93aW5nIGZv dXIgaW50ZWdlciBjZWxsczoKPiAgCTB4MTogbWVkaXVtCj4gIAkweDI6IGhpZ2gKPiAgCTB4Mzog dmVyeSBoaWdoCj4gLTQuIEEgMzJiaXQgYml0ZmllbGQgdmFsdWUgc3BlY2lmeWluZyBETUEgZmVh dHVyZXMgd2hpY2ggYXJlIGRldmljZSBkZXBlbmRlbnQ6Cj4gKzQuIEEgYml0ZmllbGQgdmFsdWUg c3BlY2lmeWluZyBETUEgZmVhdHVyZXMgd2hpY2ggYXJlIGRldmljZSBkZXBlbmRlbnQ6CgpJdCdz IHN0aWxsIGEgMzItYml0IHZhbHVlLCByaWdodD8KCj4gICAtYml0IDAtMTogRE1BIEZJRk8gdGhy ZXNob2xkIHNlbGVjdGlvbgo+ICAJMHgwOiAxLzQgZnVsbCBGSUZPCj4gIAkweDE6IDEvMiBmdWxs IEZJRk8KPiAgCTB4MjogMy80IGZ1bGwgRklGTwo+ICAJMHgzOiBmdWxsIEZJRk8KPiAtCj4gKyAt Yml0IDI6IEludGVybWVkaWF0ZSBNMk0gdHJhbnNmZXIgZnJvbS90byBERFIgdG8vZnJvbSBTUkFN IHRocm91Z2hvdXQgTURNQQo+ICsJMDogTURNQSBub3QgdXNlZCB0byBnZW5lcmF0ZSBhbiBpbnRl cm1lZGlhdGUgTTJNIHRyYW5zZmVyCj4gKwkxOiBNRE1BIHVzZWQgdG8gZ2VuZXJhdGUgYW4gaW50 ZXJtZWRpYXRlIE0yTSB0cmFuc2Zlci4KPiArIC1iaXQgMy00OiBpbmRpY2F0ZWQgU1JBTSBCdWZm ZXIgc2l6ZSBpbiAoMl5vcmRlcikqUEFHRV9TSVpFLgoKV2hhdCdzIFBBR0VfU0laRT8gVGhhdCdz IG5vdCBkZWZpbmVkIGZvciBEVC4KCj4gKwlPcmRlciBpcyBnaXZlbiBieSB0aG9zZSAyIGJpdHMg c3RhcnRpbmcgYXQgMC4KPiArCVZhbGlkIG9ubHkgd2hldGhlciBJbnRlcm1lZGlhdGUgTTJNIHRy YW5zZmVyIGlzIHNldC4KPiArCUZvciBjeWNsaWMsIHdoZXRoZXIgSW50ZXJtZWRpYXRlIE0yTSB0 cmFuc2ZlciBpcyBjaG9zZW4sIGFueSB2YWx1ZSBjYW4KPiArCWJlIHNldDogU1JBTSBidWZmZXIg c2l6ZSB3aWxsIHJlbHkgb24gcGVyaW9kIHNpemUgYW5kIG5vdCBvbiB0aGlzIERUCj4gKwl2YWx1 ZS4KPiAgCj4gIEV4YW1wbGU6Cj4gIAo+IEBAIC03Nyw3ICsxMDEsNyBAQCBFeGFtcGxlOgo+ICAJ CXJlZyA9IDwweDQwMDExMDAwIDB4NDAwPjsKPiAgCQlpbnRlcnJ1cHRzID0gPDM3PjsKPiAgCQlj bG9ja3MgPSA8JmNsa19wY2xrMj47Cj4gLQkJZG1hcyA9IDwmZG1hMiAyIDQgMHgxMDQwMCAweDM+ LAo+IC0JCSAgICAgICA8JmRtYTIgNyA1IDB4MTAyMDAgMHgzPjsKPiArCQlkbWFzID0gPCZkbWEy IDIgNCAweDEwNDAwIDB4MT4sCj4gKwkJICAgICAgIDwmZG1hMiA3IDUgMHgxMDIwMCAweDE+Owo+ ICAJCWRtYS1uYW1lcyA9ICJyeCIsICJ0eCI7Cj4gIAl9Owo+IC0tIAo+IDIuNy40Cj4K From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Wed, 26 Sep 2018 15:21:12 -0500 Subject: [PATCH v1 1/7] dt-bindings: stm32-dma: Add DMA/MDMA chaining support bindings In-Reply-To: <1536650820-16076-2-git-send-email-pierre-yves.mordret@st.com> References: <1536650820-16076-1-git-send-email-pierre-yves.mordret@st.com> <1536650820-16076-2-git-send-email-pierre-yves.mordret@st.com> Message-ID: <20180926202112.GA6426@bogus> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Sep 11, 2018 at 09:26:54AM +0200, Pierre-Yves MORDRET wrote: > This patch adds dma bindings to support DMA/MDMA chaining transfer. > 1 bit is to manage both DMA FIFO Threshold > 1 bit is to manage DMA/MDMA Chaining features. > 2 bits are used to specify SDRAM size to use for DMA/MDMA chaining. > The size in bytes of a certain order is given by the formula: > (2 ^ order) * PAGE_SIZE. > The order is given by those 2 bits. > For cyclic, whether chaining is chosen, any value above 1 can be set : > SRAM buffer size will rely on period size and not on this DT value. > > Signed-off-by: Pierre-Yves MORDRET > --- > Version history: > v1: > * Initial > --- > --- > .../devicetree/bindings/dma/stm32-dma.txt | 32 +++++++++++++++++++--- > 1 file changed, 28 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/stm32-dma.txt b/Documentation/devicetree/bindings/dma/stm32-dma.txt > index c5f5190..163be09 100644 > --- a/Documentation/devicetree/bindings/dma/stm32-dma.txt > +++ b/Documentation/devicetree/bindings/dma/stm32-dma.txt > @@ -17,6 +17,12 @@ Optional properties: > - resets: Reference to a reset controller asserting the DMA controller > - st,mem2mem: boolean; if defined, it indicates that the controller supports > memory-to-memory transfer > +- dmas: A list of eight dma specifiers, one for each entry in dma-names. > + Refer to stm32-mdma.txt for more details. > +- dma-names: should contain "ch0", "ch1", "ch2", "ch3", "ch4", "ch5", "ch6" and > + "ch7" and represents each STM32 DMA channel connected to a STM32 MDMA one. > +- memory-region : phandle to a node describing memory to be used for > + M2M intermediate transfer between DMA and MDMA. > > Example: > > @@ -36,6 +42,16 @@ Example: > st,mem2mem; > resets = <&rcc 150>; > dma-requests = <8>; > + dmas = <&mdma1 8 0x10 0x1200000a 0x40026408 0x00000020 1>, > + <&mdma1 9 0x10 0x1200000a 0x40026408 0x00000800 1>, > + <&mdma1 10 0x10 0x1200000a 0x40026408 0x00200000 1>, > + <&mdma1 11 0x10 0x1200000a 0x40026408 0x08000000 1>, > + <&mdma1 12 0x10 0x1200000a 0x4002640C 0x00000020 1>, > + <&mdma1 13 0x10 0x1200000a 0x4002640C 0x00000800 1>, > + <&mdma1 14 0x10 0x1200000a 0x4002640C 0x00200000 1>, > + <&mdma1 15 0x10 0x1200000a 0x4002640C 0x08000000 1>; > + dma-names = "ch0", "ch1", "ch2", "ch3", "ch4", "ch5", "ch6", "ch7"; > + memory-region = <&sram_dmapool>; > }; > > * DMA client > @@ -62,13 +78,21 @@ channel: a phandle to the DMA controller plus the following four integer cells: > 0x1: medium > 0x2: high > 0x3: very high > -4. A 32bit bitfield value specifying DMA features which are device dependent: > +4. A bitfield value specifying DMA features which are device dependent: It's still a 32-bit value, right? > -bit 0-1: DMA FIFO threshold selection > 0x0: 1/4 full FIFO > 0x1: 1/2 full FIFO > 0x2: 3/4 full FIFO > 0x3: full FIFO > - > + -bit 2: Intermediate M2M transfer from/to DDR to/from SRAM throughout MDMA > + 0: MDMA not used to generate an intermediate M2M transfer > + 1: MDMA used to generate an intermediate M2M transfer. > + -bit 3-4: indicated SRAM Buffer size in (2^order)*PAGE_SIZE. What's PAGE_SIZE? That's not defined for DT. > + Order is given by those 2 bits starting at 0. > + Valid only whether Intermediate M2M transfer is set. > + For cyclic, whether Intermediate M2M transfer is chosen, any value can > + be set: SRAM buffer size will rely on period size and not on this DT > + value. > > Example: > > @@ -77,7 +101,7 @@ Example: > reg = <0x40011000 0x400>; > interrupts = <37>; > clocks = <&clk_pclk2>; > - dmas = <&dma2 2 4 0x10400 0x3>, > - <&dma2 7 5 0x10200 0x3>; > + dmas = <&dma2 2 4 0x10400 0x1>, > + <&dma2 7 5 0x10200 0x1>; > dma-names = "rx", "tx"; > }; > -- > 2.7.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v1 1/7] dt-bindings: stm32-dma: Add DMA/MDMA chaining support bindings Date: Wed, 26 Sep 2018 15:21:12 -0500 Message-ID: <20180926202112.GA6426@bogus> References: <1536650820-16076-1-git-send-email-pierre-yves.mordret@st.com> <1536650820-16076-2-git-send-email-pierre-yves.mordret@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1536650820-16076-2-git-send-email-pierre-yves.mordret@st.com> Sender: linux-kernel-owner@vger.kernel.org To: Pierre-Yves MORDRET Cc: Vinod Koul , Mark Rutland , Alexandre Torgue , Maxime Coquelin , Dan Williams , devicetree@vger.kernel.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On Tue, Sep 11, 2018 at 09:26:54AM +0200, Pierre-Yves MORDRET wrote: > This patch adds dma bindings to support DMA/MDMA chaining transfer. > 1 bit is to manage both DMA FIFO Threshold > 1 bit is to manage DMA/MDMA Chaining features. > 2 bits are used to specify SDRAM size to use for DMA/MDMA chaining. > The size in bytes of a certain order is given by the formula: > (2 ^ order) * PAGE_SIZE. > The order is given by those 2 bits. > For cyclic, whether chaining is chosen, any value above 1 can be set : > SRAM buffer size will rely on period size and not on this DT value. > > Signed-off-by: Pierre-Yves MORDRET > --- > Version history: > v1: > * Initial > --- > --- > .../devicetree/bindings/dma/stm32-dma.txt | 32 +++++++++++++++++++--- > 1 file changed, 28 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/stm32-dma.txt b/Documentation/devicetree/bindings/dma/stm32-dma.txt > index c5f5190..163be09 100644 > --- a/Documentation/devicetree/bindings/dma/stm32-dma.txt > +++ b/Documentation/devicetree/bindings/dma/stm32-dma.txt > @@ -17,6 +17,12 @@ Optional properties: > - resets: Reference to a reset controller asserting the DMA controller > - st,mem2mem: boolean; if defined, it indicates that the controller supports > memory-to-memory transfer > +- dmas: A list of eight dma specifiers, one for each entry in dma-names. > + Refer to stm32-mdma.txt for more details. > +- dma-names: should contain "ch0", "ch1", "ch2", "ch3", "ch4", "ch5", "ch6" and > + "ch7" and represents each STM32 DMA channel connected to a STM32 MDMA one. > +- memory-region : phandle to a node describing memory to be used for > + M2M intermediate transfer between DMA and MDMA. > > Example: > > @@ -36,6 +42,16 @@ Example: > st,mem2mem; > resets = <&rcc 150>; > dma-requests = <8>; > + dmas = <&mdma1 8 0x10 0x1200000a 0x40026408 0x00000020 1>, > + <&mdma1 9 0x10 0x1200000a 0x40026408 0x00000800 1>, > + <&mdma1 10 0x10 0x1200000a 0x40026408 0x00200000 1>, > + <&mdma1 11 0x10 0x1200000a 0x40026408 0x08000000 1>, > + <&mdma1 12 0x10 0x1200000a 0x4002640C 0x00000020 1>, > + <&mdma1 13 0x10 0x1200000a 0x4002640C 0x00000800 1>, > + <&mdma1 14 0x10 0x1200000a 0x4002640C 0x00200000 1>, > + <&mdma1 15 0x10 0x1200000a 0x4002640C 0x08000000 1>; > + dma-names = "ch0", "ch1", "ch2", "ch3", "ch4", "ch5", "ch6", "ch7"; > + memory-region = <&sram_dmapool>; > }; > > * DMA client > @@ -62,13 +78,21 @@ channel: a phandle to the DMA controller plus the following four integer cells: > 0x1: medium > 0x2: high > 0x3: very high > -4. A 32bit bitfield value specifying DMA features which are device dependent: > +4. A bitfield value specifying DMA features which are device dependent: It's still a 32-bit value, right? > -bit 0-1: DMA FIFO threshold selection > 0x0: 1/4 full FIFO > 0x1: 1/2 full FIFO > 0x2: 3/4 full FIFO > 0x3: full FIFO > - > + -bit 2: Intermediate M2M transfer from/to DDR to/from SRAM throughout MDMA > + 0: MDMA not used to generate an intermediate M2M transfer > + 1: MDMA used to generate an intermediate M2M transfer. > + -bit 3-4: indicated SRAM Buffer size in (2^order)*PAGE_SIZE. What's PAGE_SIZE? That's not defined for DT. > + Order is given by those 2 bits starting at 0. > + Valid only whether Intermediate M2M transfer is set. > + For cyclic, whether Intermediate M2M transfer is chosen, any value can > + be set: SRAM buffer size will rely on period size and not on this DT > + value. > > Example: > > @@ -77,7 +101,7 @@ Example: > reg = <0x40011000 0x400>; > interrupts = <37>; > clocks = <&clk_pclk2>; > - dmas = <&dma2 2 4 0x10400 0x3>, > - <&dma2 7 5 0x10200 0x3>; > + dmas = <&dma2 2 4 0x10400 0x1>, > + <&dma2 7 5 0x10200 0x1>; > dma-names = "rx", "tx"; > }; > -- > 2.7.4 >