From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH v4 2/6] drm/i915: Unset reset pch handshake when PCH is not present in one place Date: Wed, 26 Sep 2018 17:15:31 -0700 Message-ID: <20180927001530.GA13484@intel.com> References: <20180918204714.27306-1-jose.souza@intel.com> <20180918204714.27306-2-jose.souza@intel.com> <20180918214813.GU2674@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E5736E03D for ; Thu, 27 Sep 2018 00:18:12 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180918214813.GU2674@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?iso-8859-1?Q?Jos=E9?= Roberto de Souza Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBTZXAgMTgsIDIwMTggYXQgMDI6NDg6MTNQTSAtMDcwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IE9uIFR1ZSwgU2VwIDE4LCAyMDE4IGF0IDAxOjQ3OjEwUE0gLTA3MDAsIEpvc8OpIFJv YmVydG8gZGUgU291emEgd3JvdGU6Cj4gPiBSaWdodCBub3cgUkVTRVRfUENIX0hBTkRTSEFLRV9F TkFCTEUgaXMgZW5hYmxlZCBhbGwgdGhlIHRpbWVzIGluc2lkZQo+ID4gb2YgaW50ZWxfcG93ZXJf ZG9tYWluc19pbml0X2h3KCkgYW5kIGlmIFBDSCBpcyBOT1AgaXQgaXMgdW5zZWQgaW4KPiA+IGk5 MTVfZ2VtX2luaXRfaHcoKS4KPiA+IFNvIG1ha2luZyBza2xfcGNoX3Jlc2V0X2hhbmRzaGFrZSgp IGhhbmRsZSBib3RoIGNhc2VzIGFuZCBjYWxsaW5nCj4gPiBpdCBmb3IgdGhlIG1pc3NpbmcgZ2Vu cyBpbiBpbnRlbF9wb3dlcl9kb21haW5zX2luaXRfaHcoKS4KPiA+IEl2eWJyaWRnZSBoYXZlIGEg ZGlmZmVyZW50IHJlZ2lzdGVyIGFuZCBiaXRzIGJ1dCB3aXRoIHRoZSBzYW1lCj4gPiBvYmplY3Rp dmUgc28gbW92aW5nIGl0IHRvby4KPiA+IAo+ID4gdjIoUm9kcmlnbyk6Cj4gPiAtIGhhbmRsaW5n IElWWUJSSURHRSBjYXNlIGluc2lkZSBpbnRlbF9wY2hfcmVzZXRfaGFuZHNoYWtlKCkKPiA+IAo+ ID4gdjQoUm9kcmlnbyBhbmQgVmlsbGUpOgo+ID4gLSBtb3ZpbmcgdGhlIGVuYWJsZS9kaXNhYmxl IGRlY2lzaW9uIHRvIGNhbGxlcnMKPiA+IAo+ID4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52 aXZpQGludGVsLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IEpvc8OpIFJvYmVydG8gZGUgU291emEg PGpvc2Uuc291emFAaW50ZWwuY29tPgo+IAo+IEkgd2FzIGdvaW5nIHRvIGNvd2FyZGx5IHdhaXQg Zm9yIENJLCBidXQgSSB3aWxsIGVuZCB1cAo+IGZvcmdldHRpbmcgdGhlIHJldmlldyBhbmQgY29k ZSBsb29rcyByaWdodCB0byBteSBodW1hbiBleWVzLAo+IHNvIGJlZm9yZSBJIGZvcmdldDoKPiAK PiBSZXZpZXdlZC1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgoKcHVz aGVkIHRvIGRpbnEuIFRoYW5rcyBmb3IgdGhlIHBhdGNoZXMuCgo+IAo+ID4gLS0tCj4gPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyAgICAgICAgIHwgMTIgLS0tLS0tLS0tLS0KPiA+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMgfCAyOCArKysrKysrKysr KysrKysrKystLS0tLS0tCj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAy MCBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gPiBpbmRleCBh OTRkNWEzMDhjNGQuLjNmZTVkNGYwNThlZSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt LmMKPiA+IEBAIC01Mjk5LDE4ICs1Mjk5LDYgQEAgaW50IGk5MTVfZ2VtX2luaXRfaHcoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gIAkJSTkxNV9XUklURShNSV9QUkVESUNB VEVfUkVTVUxUXzIsIElTX0hTV19HVDMoZGV2X3ByaXYpID8KPiA+ICAJCQkgICBMT1dFUl9TTElD RV9FTkFCTEVEIDogTE9XRVJfU0xJQ0VfRElTQUJMRUQpOwo+ID4gIAo+ID4gLQlpZiAoSEFTX1BD SF9OT1AoZGV2X3ByaXYpKSB7Cj4gPiAtCQlpZiAoSVNfSVZZQlJJREdFKGRldl9wcml2KSkgewo+ ID4gLQkJCXUzMiB0ZW1wID0gSTkxNV9SRUFEKEdFTjdfTVNHX0NUTCk7Cj4gPiAtCQkJdGVtcCAm PSB+KFdBSVRfRk9SX1BDSF9GTFJfQUNLIHwgV0FJVF9GT1JfUENIX1JFU0VUX0FDSyk7Cj4gPiAt CQkJSTkxNV9XUklURShHRU43X01TR19DVEwsIHRlbXApOwo+ID4gLQkJfSBlbHNlIGlmIChJTlRF TF9HRU4oZGV2X3ByaXYpID49IDcpIHsKPiA+IC0JCQl1MzIgdGVtcCA9IEk5MTVfUkVBRChIU1df TkRFX1JTVFdSTl9PUFQpOwo+ID4gLQkJCXRlbXAgJj0gflJFU0VUX1BDSF9IQU5EU0hBS0VfRU5B QkxFOwo+ID4gLQkJCUk5MTVfV1JJVEUoSFNXX05ERV9SU1RXUk5fT1BULCB0ZW1wKTsKPiA+IC0J CX0KPiA+IC0JfQo+ID4gLQo+ID4gIAlpbnRlbF9ndF93b3JrYXJvdW5kc19hcHBseShkZXZfcHJp dik7Cj4gPiAgCj4gPiAgCWk5MTVfZ2VtX2luaXRfc3dpenpsaW5nKGRldl9wcml2KTsKPiA+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMKPiA+IGluZGV4IGFhMGZmNGMwOGJh ZC4uMzA4ZDA2OTcxNDM1IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfcnVudGltZV9wbS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50 aW1lX3BtLmMKPiA+IEBAIC0zMjQyLDE0ICszMjQyLDI1IEBAIHN0YXRpYyB2b2lkIGljbF9tYnVz X2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gIHN0YXRpYyB2b2lk IGludGVsX3BjaF9yZXNldF9oYW5kc2hha2Uoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2LAo+ID4gIAkJCQkgICAgICBib29sIGVuYWJsZSkKPiA+ICB7Cj4gPiAtCXUzMiB2YWwgPSBJ OTE1X1JFQUQoSFNXX05ERV9SU1RXUk5fT1BUKTsKPiA+ICsJaTkxNV9yZWdfdCByZWc7Cj4gPiAr CXUzMiByZXNldF9iaXRzLCB2YWw7Cj4gPiArCj4gPiArCWlmIChJU19JVllCUklER0UoZGV2X3By aXYpKSB7Cj4gPiArCQlyZWcgPSBHRU43X01TR19DVEw7Cj4gPiArCQlyZXNldF9iaXRzID0gV0FJ VF9GT1JfUENIX0ZMUl9BQ0sgfCBXQUlUX0ZPUl9QQ0hfUkVTRVRfQUNLOwo+ID4gKwl9IGVsc2Ug ewo+ID4gKwkJcmVnID0gSFNXX05ERV9SU1RXUk5fT1BUOwo+ID4gKwkJcmVzZXRfYml0cyA9IFJF U0VUX1BDSF9IQU5EU0hBS0VfRU5BQkxFOwo+ID4gKwl9Cj4gPiArCj4gPiArCXZhbCA9IEk5MTVf UkVBRChyZWcpOwo+ID4gIAo+ID4gIAlpZiAoZW5hYmxlKQo+ID4gLQkJdmFsIHw9IFJFU0VUX1BD SF9IQU5EU0hBS0VfRU5BQkxFOwo+ID4gKwkJdmFsIHw9IHJlc2V0X2JpdHM7Cj4gPiAgCWVsc2UK PiA+IC0JCXZhbCAmPSB+UkVTRVRfUENIX0hBTkRTSEFLRV9FTkFCTEU7Cj4gPiArCQl2YWwgJj0g fnJlc2V0X2JpdHM7Cj4gPiAgCj4gPiAtCUk5MTVfV1JJVEUoSFNXX05ERV9SU1RXUk5fT1BULCB2 YWwpOwo+ID4gKwlJOTE1X1dSSVRFKHJlZywgdmFsKTsKPiA+ICB9Cj4gPiAgCj4gPiAgc3RhdGlj IHZvaWQgc2tsX2Rpc3BsYXlfY29yZV9pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdiwKPiA+IEBAIC0zMjYxLDcgKzMyNzIsNyBAQCBzdGF0aWMgdm9pZCBza2xfZGlzcGxheV9j b3JlX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gIAlnZW45X3Nl dF9kY19zdGF0ZShkZXZfcHJpdiwgRENfU1RBVEVfRElTQUJMRSk7Cj4gPiAgCj4gPiAgCS8qIGVu YWJsZSBQQ0ggcmVzZXQgaGFuZHNoYWtlICovCj4gPiAtCWludGVsX3BjaF9yZXNldF9oYW5kc2hh a2UoZGV2X3ByaXYsIHRydWUpOwo+ID4gKwlpbnRlbF9wY2hfcmVzZXRfaGFuZHNoYWtlKGRldl9w cml2LCAhSEFTX1BDSF9OT1AoZGV2X3ByaXYpKTsKPiA+ICAKPiA+ICAJLyogZW5hYmxlIFBHMSBh bmQgTWlzYyBJL08gKi8KPiA+ICAJbXV0ZXhfbG9jaygmcG93ZXJfZG9tYWlucy0+bG9jayk7Cj4g PiBAQCAtMzQ0Nyw3ICszNDU4LDcgQEAgc3RhdGljIHZvaWQgY25sX2Rpc3BsYXlfY29yZV9pbml0 KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgYm9vbCByZXN1bWUKPiA+ICAJZ2Vu OV9zZXRfZGNfc3RhdGUoZGV2X3ByaXYsIERDX1NUQVRFX0RJU0FCTEUpOwo+ID4gIAo+ID4gIAkv KiAxLiBFbmFibGUgUENIIFJlc2V0IEhhbmRzaGFrZSAqLwo+ID4gLQlpbnRlbF9wY2hfcmVzZXRf aGFuZHNoYWtlKGRldl9wcml2LCB0cnVlKTsKPiA+ICsJaW50ZWxfcGNoX3Jlc2V0X2hhbmRzaGFr ZShkZXZfcHJpdiwgIUhBU19QQ0hfTk9QKGRldl9wcml2KSk7Cj4gPiAgCj4gPiAgCS8qIDIuIEVu YWJsZSBDb21wICovCj4gPiAgCXZhbCA9IEk5MTVfUkVBRChDSElDS0VOX01JU0NfMik7Cj4gPiBA QCAtMzUzMCw3ICszNTQxLDcgQEAgc3RhdGljIHZvaWQgaWNsX2Rpc3BsYXlfY29yZV9pbml0KHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ICAJZ2VuOV9zZXRfZGNfc3RhdGUo ZGV2X3ByaXYsIERDX1NUQVRFX0RJU0FCTEUpOwo+ID4gIAo+ID4gIAkvKiAxLiBFbmFibGUgUENI IHJlc2V0IGhhbmRzaGFrZS4gKi8KPiA+IC0JaW50ZWxfcGNoX3Jlc2V0X2hhbmRzaGFrZShkZXZf cHJpdiwgdHJ1ZSk7Cj4gPiArCWludGVsX3BjaF9yZXNldF9oYW5kc2hha2UoZGV2X3ByaXYsICFI QVNfUENIX05PUChkZXZfcHJpdikpOwo+ID4gIAo+ID4gIAlmb3IgKHBvcnQgPSBQT1JUX0E7IHBv cnQgPD0gUE9SVF9COyBwb3J0KyspIHsKPiA+ICAJCS8qIDIuIEVuYWJsZSBEREkgY29tYm8gUEhZ IGNvbXAuICovCj4gPiBAQCAtMzc2Miw3ICszNzczLDggQEAgdm9pZCBpbnRlbF9wb3dlcl9kb21h aW5zX2luaXRfaHcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBib29sIHJlc3Vt ZSkKPiA+ICAJCW11dGV4X2xvY2soJnBvd2VyX2RvbWFpbnMtPmxvY2spOwo+ID4gIAkJdmx2X2Nt bmxhbmVfd2EoZGV2X3ByaXYpOwo+ID4gIAkJbXV0ZXhfdW5sb2NrKCZwb3dlcl9kb21haW5zLT5s b2NrKTsKPiA+IC0JfQo+ID4gKwl9IGVsc2UgaWYgKElTX0lWWUJSSURHRShkZXZfcHJpdikgfHwg SU5URUxfR0VOKGRldl9wcml2KSA+PSA3KQo+ID4gKwkJaW50ZWxfcGNoX3Jlc2V0X2hhbmRzaGFr ZShkZXZfcHJpdiwgIUhBU19QQ0hfTk9QKGRldl9wcml2KSk7Cj4gPiAgCj4gPiAgCS8qCj4gPiAg CSAqIEtlZXAgYWxsIHBvd2VyIHdlbGxzIGVuYWJsZWQgZm9yIGFueSBkZXBlbmRlbnQgSFcgYWNj ZXNzIGR1cmluZwo+ID4gLS0gCj4gPiAyLjE5LjAKPiA+IAo+IF9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IElu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeApfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK