All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org
Subject: Re: [RFC 1/4] mt76x0: print BBP version only for debug
Date: Thu, 27 Sep 2018 11:26:30 +0200	[thread overview]
Message-ID: <20180927092629.GA2489@localhost.localdomain> (raw)
In-Reply-To: <1538037450-18949-2-git-send-email-sgruszka@redhat.com>

> Use dev_dbg to print BBP version.
> 
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> ---
>  drivers/net/wireless/mediatek/mt76/mt76x0/phy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
> index 4fd2c65e196a..ca0a693654a3 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
> @@ -187,7 +187,6 @@ int mt76x0_wait_bbp_ready(struct mt76x0_dev *dev)
>  
>  	do {
>  		val = mt76_rr(dev, MT_BBP(CORE, 0));
> -		printk("BBP version %08x\n", val);
>  		if (val && ~val)
>  			break;
>  	} while (--i);
> @@ -197,6 +196,7 @@ int mt76x0_wait_bbp_ready(struct mt76x0_dev *dev)
>  		return -EIO;
>  	}
>  
> +	dev_dbg(dev->mt76.dev, "BBP version %08x\n", val);
>  	return 0;
>  }

I guess we can drop mt76x0_wait_bbp_ready and use mt76x02_wait_for_mac instead

Regards,
Lorenzo

>  
> -- 
> 1.9.3
> 

  reply	other threads:[~2018-09-27  9:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-27  8:37 [RFC 0/4] mt76x0: phy/rf fixups for PCIe Stanislaw Gruszka
2018-09-27  8:37 ` [RFC 1/4] mt76x0: print BBP version only for debug Stanislaw Gruszka
2018-09-27  9:26   ` Lorenzo Bianconi [this message]
2018-09-27  9:34     ` Lorenzo Bianconi
2018-09-27  9:41       ` Stanislaw Gruszka
2018-09-27  9:37     ` Stanislaw Gruszka
2018-09-27  8:37 ` [RFC 2/4] mt76x0: correct RF access via RF_CSR regiser Stanislaw Gruszka
2018-09-27  8:37 ` [RFC 3/4] mt76: allow to identify bus Stanislaw Gruszka
2018-09-27  8:37 ` [RFC 4/4] mt76x0: correct RF reg pairs write for PCIe Stanislaw Gruszka
2018-09-27 11:47 ` [RFC 0/4] mt76x0: phy/rf fixups " Felix Fietkau
2018-09-30 19:11   ` Lorenzo Bianconi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180927092629.GA2489@localhost.localdomain \
    --to=lorenzo.bianconi@redhat.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@nbd.name \
    --cc=sgruszka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.