From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH v4] drm/panel: add Kingdisplay kd097d04 panel driver
Date: Thu, 27 Sep 2018 14:07:21 +0200
Message-ID: <20180927120721.GF29102@ulmo>
References: <20180817093731.9850-1-heiko@sntech.de>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="7cm2iqirTL37Ot+N"
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20180817093731.9850-1-heiko@sntech.de>
Sender: linux-kernel-owner@vger.kernel.org
To: Heiko Stuebner <heiko@sntech.de>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, seanpaul@chromium.org, briannorris@chromium.org, hl@rock-chips.com, nickey.yang@rock-chips.com, p.zabel@pengutronix.de
List-Id: dri-devel@lists.freedesktop.org


--7cm2iqirTL37Ot+N
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 17, 2018 at 11:37:31AM +0200, Heiko Stuebner wrote:
> From: Nickey Yang <nickey.yang@rock-chips.com>
>=20
> Support Kingdisplay kd097d04 9.7" 1536x2048 TFT LCD panel,
> it is a MIPI dual-DSI panel.
>=20
> v4:
> - address Philipp's comments
>   - real range for usleep_range and
>   - poweroff ordering in kingdisplay_panel_prepare
>   - return value beautification in panel_probe
> - update author naming for full name
> v3:
> - address Thierry's comments
>   - error handling for init dsi writes in init
>   - unconditionally remove the panel
>   - don't use drm_panel_detach
>   - a bit of variable signednes wiggling
> - I did talk to ChromeOS people and the delays really should be as short
>   as possible, so dropped the 100ms from the delay comments
> v2:
> - update timing + cmds from chromeos kernel
> - new backlight API including switch to devm_of_find_backlight
> - fix most of Sean Paul's comments
>   enable/prepare tracking seems something all panels do
> - document origins of the init sequence
> - lanes per dsi interface to 4 (two interfaces). Matches how tegra
>   and pending rockchip dual-dsi handle (dual-)dsi lanes
> - spdx header instead of license boilerplate
>=20
> Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
>  drivers/gpu/drm/panel/Kconfig                 |  11 +
>  drivers/gpu/drm/panel/Makefile                |   1 +
>  .../drm/panel/panel-kingdisplay-kd097d04.c    | 473 ++++++++++++++++++
>  3 files changed, 485 insertions(+)
>  create mode 100644 drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c

This is missing device tree bindings.

Thierry

--7cm2iqirTL37Ot+N
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlusx/kACgkQ3SOs138+
s6GsoBAApY77hwVAyBUvK6uezZix2+j957v3cx5riVNVemIFOzJa5EBhtwHHg0ji
UsZvYL21UEeueG/yiX4CQlrmHP44g3OzFFCSjI/cu69qG893zxuplGUK73qML1LL
pPXNU1eKk5PmfBf/ujwmUbXzhyVe/SdHIYPdU9R/D0HeZqrxTEC6NWp3ZpxPlLxa
C9Ai161nPwOSwzj0nLRKg1UPxwZk+T00VBHcX9+ObbZB6YXkAFb6/LqAbE6recGN
PSF4pE8ZaV9RlyfbXOovpz4b5BJyCQeh6gWEF/w2uMORyUCbTs32KgORz2Mf1KV0
zIz6lO+/PN5kwkHaqEc2PPKtdTdDp0m6dA2FdRMnSdeKpCwknd6ucwqwctnJI0+s
Tm8JX1Lso6H1ab1PSr2SHNAJzv6pbHjnOL9irs3kG9yjJrCBlgOLn2Q8R85HVgL9
EreCq2tAxzNe61VnbFmdGFDwoAE/yuAuncLq4hmX+DMNNoIUwtXt31ofZdOH8r6i
r93xC1vsicz7e0AKlOEc2gnje9QjgZt0pj8BHRvHUrhOedKzNw0Ora/pq87egAit
MsfkE1MTp4U/iiu11sIFBkifOCSNUITd3Tr687VncuWmHcKZGttIy9okScSgekwr
plkefloSB3+pbGq+CiocWxMWpgDRk1M/A+I7fbBdP/aDXlCSXh0=
=4gUX
-----END PGP SIGNATURE-----

--7cm2iqirTL37Ot+N--