From: Ben Boeckel <mathstuf@gmail.com>
To: keyrings@vger.kernel.org
Subject: [PATCH v2 4/7] keyctl_dh_compute_kdf: const-ify input parameters
Date: Thu, 27 Sep 2018 13:14:33 +0000 [thread overview]
Message-ID: <20180927131436.23328-5-mathstuf@gmail.com> (raw)
Signed-off-by: Ben Boeckel <mathstuf@gmail.com>
---
keyutils.c | 5 +++--
keyutils.h | 8 ++++----
man/keyctl_dh_compute.3 | 2 +-
3 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/keyutils.c b/keyutils.c
index fc7dc4d..a087a33 100644
--- a/keyutils.c
+++ b/keyutils.c
@@ -245,8 +245,9 @@ long keyctl_dh_compute(key_serial_t priv, key_serial_t prime,
}
long keyctl_dh_compute_kdf(key_serial_t private, key_serial_t prime,
- key_serial_t base, char *hashname, char *otherinfo,
- size_t otherinfolen, char *buffer, size_t buflen)
+ key_serial_t base, const char *hashname,
+ const char *otherinfo, size_t otherinfolen,
+ char *buffer, size_t buflen)
{
struct keyctl_dh_params params = { .priv = private,
.prime = prime,
diff --git a/keyutils.h b/keyutils.h
index 5f81c62..208c175 100644
--- a/keyutils.h
+++ b/keyutils.h
@@ -115,8 +115,8 @@ struct keyctl_dh_params {
};
struct keyctl_kdf_params {
- char *hashname;
- char *otherinfo;
+ const char *hashname;
+ const char *otherinfo;
uint32_t otherinfolen;
uint32_t __spare[8];
};
@@ -203,8 +203,8 @@ extern long keyctl_get_persistent(uid_t uid, key_serial_t id);
extern long keyctl_dh_compute(key_serial_t priv, key_serial_t prime,
key_serial_t base, char *buffer, size_t buflen);
extern long keyctl_dh_compute_kdf(key_serial_t private, key_serial_t prime,
- key_serial_t base, char *hashname,
- char *otherinfo, size_t otherinfolen,
+ key_serial_t base, const char *hashname,
+ const char *otherinfo, size_t otherinfolen,
char *buffer, size_t buflen);
extern long keyctl_restrict_keyring(key_serial_t keyring, const char *type,
const char *restriction);
diff --git a/man/keyctl_dh_compute.3 b/man/keyctl_dh_compute.3
index 09c5d21..58ad5df 100644
--- a/man/keyctl_dh_compute.3
+++ b/man/keyctl_dh_compute.3
@@ -25,7 +25,7 @@ keyctl_dh_compute_kdf \- Derive key from a Diffie-Hellman shared secret
.BI "key_serial_t " prime ", key_serial_t " base ", void **" _buffer ");"
.sp
.BI "long keyctl_dh_compute_kdf(key_serial_t " private ", key_serial_t " prime ,
-.BI "key_serial_t " base ", char *" hashname ", char *" otherinfo ",
+.BI "key_serial_t " base ", const char *" hashname ", const char *" otherinfo ",
.BI "size_t " otherinfolen ", char *" buffer ", size_t " buflen ");"
.\"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""
.SH DESCRIPTION
--
2.19.0.221.g150f307afc
next reply other threads:[~2018-09-27 13:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 13:14 Ben Boeckel [this message]
2018-11-02 14:50 ` [PATCH v2 4/7] keyctl_dh_compute_kdf: const-ify input parameters David Howells
2018-11-02 15:08 ` David Howells
2018-11-02 16:05 ` Ben Boeckel
2018-11-02 16:20 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927131436.23328-5-mathstuf@gmail.com \
--to=mathstuf@gmail.com \
--cc=keyrings@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.