From: Matthias Kaehlcke <mka@chromium.org>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: Balakrishna Godavarthi <bgodavar@codeaurora.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Marcin Wojtas <mw@semihalf.com>,
Andy Shevchenko Andy Shevchenko <andy.shevchenko@gmail.com>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
Loic Poulain <loic.poulain@linaro.org>,
Brian Norris <briannorris@chromium.org>
Subject: Re: [PATCH v4 1/2] Bluetooth: Add device_get_bd_address()
Date: Thu, 27 Sep 2018 10:13:05 -0700 [thread overview]
Message-ID: <20180927171305.GG22824@google.com> (raw)
In-Reply-To: <e6752d4b-b22a-d951-e9db-1ae7445dc403@codeaurora.org>
On Thu, Sep 27, 2018 at 12:47:06PM -0400, Sinan Kaya wrote:
> On 9/27/2018 12:41 PM, Balakrishna Godavarthi wrote:
> > void bt_sock_reclassify_lock(struct sock *sk, int proto);
> >
> > +int device_get_bd_address(struct device *dev, bdaddr_t *bd_addr);
>
> Maybe change the API name to start with bt_ and get rid of device_?
device_ indicates that we get the BD_ADDR for a 'struct device' and
not for e.g. a 'struct fwnode_handle'.
Anyway with this version of the patch fwnode_get_bd_address() has been
scrapped and it might never be introduced again, so I'm open to change
the name to bt_ if there is a general preference for it.
Cheers
Matthias
next prev parent reply other threads:[~2018-09-27 17:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 0:48 [PATCH v4 0/2] Add API to retrieve the Bluetooth Device Address (BD_ADDR) Matthias Kaehlcke
2018-09-27 0:48 ` [PATCH v4 1/2] Bluetooth: Add device_get_bd_address() Matthias Kaehlcke
2018-09-27 6:50 ` Sakari Ailus
2018-09-27 16:41 ` Balakrishna Godavarthi
2018-09-27 16:47 ` Sinan Kaya
2018-09-27 17:13 ` Matthias Kaehlcke [this message]
2018-10-04 17:33 ` Matthias Kaehlcke
2018-10-15 18:03 ` Matthias Kaehlcke
2018-10-15 18:06 ` Marcel Holtmann
2018-10-15 18:51 ` Matthias Kaehlcke
2018-10-16 6:52 ` Marcel Holtmann
2018-10-16 21:02 ` Matthias Kaehlcke
2018-10-22 21:07 ` Pavel Machek
2018-09-27 0:48 ` [PATCH v4 2/2] Bluetooth: btqcomsmd: Get the BD address with device_get_bd_address() Matthias Kaehlcke
2018-09-27 16:43 ` Balakrishna Godavarthi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927171305.GG22824@google.com \
--to=mka@chromium.org \
--cc=andy.shevchenko@gmail.com \
--cc=bgodavar@codeaurora.org \
--cc=briannorris@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=marcel@holtmann.org \
--cc=mw@semihalf.com \
--cc=okaya@codeaurora.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.