From: Rob Herring <robh@kernel.org>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>, Sakari Ailus <sakari.ailus@iki.fi>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Hans Verkuil <hans.verkuil@cisco.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 3/7] [media] ad5820: DT new optional field enable-gpios
Date: Thu, 27 Sep 2018 13:23:11 -0500 [thread overview]
Message-ID: <20180927182311.GA27227@bogus> (raw)
In-Reply-To: <20180920204751.29117-3-ricardo.ribalda@gmail.com>
On Thu, Sep 20, 2018 at 10:47:47PM +0200, Ricardo Ribalda Delgado wrote:
> Document new enable-gpio field. It can be used to disable the part
enable-gpios
> without turning down its regulator.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> Acked-by: Pavel Machek <pavel@ucw.cz>
> ---
> Documentation/devicetree/bindings/media/i2c/ad5820.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ad5820.txt b/Documentation/devicetree/bindings/media/i2c/ad5820.txt
> index 5940ca11c021..9ccd96d3d5f0 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ad5820.txt
> +++ b/Documentation/devicetree/bindings/media/i2c/ad5820.txt
> @@ -8,6 +8,12 @@ Required Properties:
>
> - VANA-supply: supply of voltage for VANA pin
>
> +Optional properties:
> +
> + - enable-gpios : GPIO spec for the XSHUTDOWN pin. Note that the polarity of
> +the enable GPIO is the opposite of the XSHUTDOWN pin (asserting the enable
> +GPIO deasserts the XSHUTDOWN signal and vice versa).
shutdown-gpios is also standard and seems like it would make more sense
here. Yes, it is a bit redundant to have both, but things just evolved
that way and we don't want to totally abandon the hardware names (just
all the variants).
Rob
next prev parent reply other threads:[~2018-09-27 18:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 20:47 [PATCH v4 1/7] [media] ad5820: Define entity function Ricardo Ribalda Delgado
2018-09-20 20:47 ` [PATCH v4 2/7] [media] ad5820: Add support for enable pin Ricardo Ribalda Delgado
2018-09-20 20:47 ` [PATCH v4 3/7] [media] ad5820: DT new optional field enable-gpios Ricardo Ribalda Delgado
2018-09-27 18:23 ` Rob Herring [this message]
2018-10-01 8:20 ` Ricardo Ribalda Delgado
2018-10-01 12:36 ` Rob Herring
2018-10-01 12:40 ` Ricardo Ribalda Delgado
2018-10-01 15:01 ` Rob Herring
2018-10-01 15:55 ` Laurent Pinchart
2018-10-02 7:18 ` Ricardo Ribalda Delgado
2018-09-20 20:47 ` [PATCH v4 4/7] [media] ad5820: Add support for of-autoload Ricardo Ribalda Delgado
2018-09-27 19:29 ` Sakari Ailus
2018-09-20 20:47 ` [PATCH v4 5/7] [media] ad5820: Add support for acpi autoload Ricardo Ribalda Delgado
2018-09-27 19:32 ` Sakari Ailus
2018-09-20 20:47 ` [PATCH v4 6/7] [media] ad5820: Add support for ad5821 and ad5823 Ricardo Ribalda Delgado
2018-09-27 19:35 ` Sakari Ailus
2018-10-01 8:19 ` Ricardo Ribalda Delgado
2018-09-20 20:47 ` [PATCH v4 7/7] [media] ad5820: DT new compatible devices Ricardo Ribalda Delgado
2018-09-27 18:23 ` Rob Herring
2018-09-27 18:23 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927182311.GA27227@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hans.verkuil@cisco.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=pavel@ucw.cz \
--cc=ricardo.ribalda@gmail.com \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.