From: Ben Boeckel <mathstuf@gmail.com>
To: keyrings@vger.kernel.org
Subject: Re: [PATCH 4/5] keyctl.h: update pointer types
Date: Thu, 27 Sep 2018 18:37:00 +0000 [thread overview]
Message-ID: <20180927183700.GA6356@rotor.kitware.com> (raw)
In-Reply-To: <20180927131450.23458-5-mathstuf@gmail.com>
On Thu, Sep 27, 2018 at 18:08:03 +0100, David Howells wrote:
> Ben Boeckel <mathstuf@gmail.com> wrote:
> > These should be `const` since the kernel should not touch them. In
> > addition `otherinfo` is defined to be opaque, so make it a `void *`.
>
> You're changing the UAPI - and this no longer matches what's in keyutils.h in
> userspace.
Please see patch #5/7 of the keyutils patches on this thread for that change.
> The UAPI change might potentially cause userspace to fail to compile if
> someone was assigning the char * pointer from the struct to another char *
> pointer.
Is this in a released kernel? Isn't the KDF code being added in another
pull request of yours[1]?
--Ben
[1]https://lwn.net/Articles/764227/
prev parent reply other threads:[~2018-09-27 18:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 13:14 [PATCH 4/5] keyctl.h: update pointer types Ben Boeckel
2018-09-27 17:08 ` David Howells
2018-09-27 18:37 ` Ben Boeckel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927183700.GA6356@rotor.kitware.com \
--to=mathstuf@gmail.com \
--cc=keyrings@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.