All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: devicetree@vger.kernel.org,
	Thierry Reding <thierry.reding@gmail.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2 v3] drm/panel: Augment the TPO TPG110 bindings
Date: Thu, 27 Sep 2018 14:49:09 -0500	[thread overview]
Message-ID: <20180927194909.GA18349@bogus> (raw)
In-Reply-To: <20180925143559.19934-1-linus.walleij@linaro.org>

On Tue, 25 Sep 2018 16:35:58 +0200, Linus Walleij wrote:
> The TPO TPG110 bindings were using the DPI bindings (popular
> in the fbdev subsystem) but this misses the finer points
> learned in the DRM subsystem.
> 
> We need to augment the bindings for proper DRM integration:
> the timings are expressed by the hardware, not put into the
> device tree. I.e. this hardware is self-describing and can
> report the resolutions and timings needed. It should not
> be described in the device tree.
> 
> Further the device was incorrectly modeled with GPIO lines
> instead of an SPI child, even though the device was using
> SPI.
> 
> No known deployments of the device using device tree
> exist, so it should be fine to augment the bindings.
> 
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v2->v3:
> - Rewrite to reflect the fact that the display should be
>   an SPI child device using 3WIRE SPI.
> ChangeLog v1->v2:
> - Expand some sections to make it clear what kind of device
>   this is and that the serial protocol it uses is not
>   I2C.
> ---
>  .../bindings/display/panel/tpo,tpg110.txt     | 83 ++++++++++++-------
>  1 file changed, 54 insertions(+), 29 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      parent reply	other threads:[~2018-09-27 19:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-25 14:35 [PATCH 1/2 v3] drm/panel: Augment the TPO TPG110 bindings Linus Walleij
2018-09-25 14:35 ` [PATCH 2/2 v3] drm/panel: Add a driver for the TPO TPG110 Linus Walleij
2018-09-27 19:49 ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180927194909.GA18349@bogus \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linus.walleij@linaro.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.