All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, Tiwei Bie <tiwei.bie@intel.com>,
	Zhihong Wang <zhihong.wang@intel.com>,
	xiao.w.wang@intel.com, Rami Rosen <roszenrami@gmail.com>,
	Wang Haiyue <haiyue.wang@intel.com>
Subject: Re: [PATCH v6 2/2] examples/vdpa: introduce a new sample for vDPA
Date: Fri, 28 Sep 2018 15:32:21 +0800	[thread overview]
Message-ID: <20180928073221.GA37170@intel.com> (raw)
In-Reply-To: <2404f5d8-beed-08fe-06bf-451868e3e9d3@redhat.com>

On 09/27, Maxime Coquelin wrote:
[snip]
>> +	devcnt = 0;
>This isn't needed as it is static.
>
>> +	interactive = 0;
>Ditto
>
>> +	memset(iface, 0, sizeof(iface));
>Ditto
>
>> +	memset(vports, 0, sizeof(vports));
>And this one too when it will be made static.
>
>
>Appart these small comments, it looks good to me.
>When fixed, please apply my:
>
>Reviewed-by: Maxime coquelin <maxime.coquelin@redhat.com>
>

Thanks for your comments, I'll adpot all the static related suggetions.

Thanks,
Xiaolong
>Thanks,
>Maxime

  reply	other threads:[~2018-09-28  0:44 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-20 22:28 [PATCH v3 0/2] introduce vdpa sample Xiaolong Ye
2018-09-20 22:28 ` [PATCH v3 1/2] vhost: introduce API to get vDPA device number Xiaolong Ye
2018-09-20 22:28 ` [PATCH v3 2/2] examples/vdpa: introduce a new sample for vDPA Xiaolong Ye
2018-09-21  5:07   ` Wang, Xiao W
2018-09-22 11:04     ` Ye Xiaolong
2018-09-24  8:42 ` [PATCH v4 0/2] introduce vdpa sample Xiaolong Ye
2018-09-24  8:42   ` [PATCH v4 1/2] vhost: introduce API to get vDPA device number Xiaolong Ye
2018-09-24  8:42   ` [PATCH v4 2/2] examples/vdpa: introduce a new sample for vDPA Xiaolong Ye
2018-09-24  4:12     ` Wang, Xiao W
2018-09-24 21:30       ` Ye Xiaolong
2018-09-25 12:07   ` [PATCH v5 0/2] introduce vdpa sample Xiaolong Ye
2018-09-25 12:07     ` [PATCH v5 1/2] vhost: introduce API to get vDPA device number Xiaolong Ye
2018-09-25 12:07     ` [PATCH v5 2/2] examples/vdpa: introduce a new sample for vDPA Xiaolong Ye
2018-09-25  8:32       ` Wang, Xiao W
2018-09-26  9:06     ` [PATCH v6 0/2] introduce vdpa sample Xiaolong Ye
2018-09-26  3:15       ` Wang, Xiao W
2018-09-26  9:06       ` [PATCH v6 1/2] vhost: introduce API to get vDPA device number Xiaolong Ye
2018-09-26  9:06       ` [PATCH v6 2/2] examples/vdpa: introduce a new sample for vDPA Xiaolong Ye
2018-09-27 16:37         ` Maxime Coquelin
2018-09-28  7:32           ` Ye Xiaolong [this message]
2018-09-28 11:23       ` [PATCH v7 0/2] introduce vdpa sample Xiaolong Ye
2018-09-28 11:23         ` [PATCH v7 1/2] vhost: introduce API to get vDPA device number Xiaolong Ye
2018-09-28 11:23         ` [PATCH v7 2/2] examples/vdpa: introduce a new sample for vDPA Xiaolong Ye
2018-09-28  7:31           ` Maxime Coquelin
2018-09-28 14:33             ` Ye Xiaolong
2018-09-28  7:49               ` Maxime Coquelin
2018-09-28 15:17                 ` Ye Xiaolong
2018-09-28  8:31                   ` Maxime Coquelin
2018-09-28 17:37                     ` Ye Xiaolong
2018-09-28 21:47         ` [PATCH v8 0/2] introduce vdpa sample Xiaolong Ye
2018-09-28 21:47           ` [PATCH v8 1/2] vhost: introduce API to get vDPA device number Xiaolong Ye
2018-10-02 13:19             ` Ferruh Yigit
2018-10-03  5:53               ` Ye Xiaolong
2018-09-28 21:47           ` [PATCH v8 2/2] examples/vdpa: introduce a new sample for vDPA Xiaolong Ye
2018-10-02 14:03             ` Ferruh Yigit
2018-10-03  6:04               ` Ye Xiaolong
2018-10-03  7:48                 ` Ferruh Yigit
2019-01-17 14:37             ` Shahaf Shuler
2019-01-17 15:13               ` Ye Xiaolong
2019-01-17 15:17                 ` Shahaf Shuler
2018-10-02 12:51           ` [PATCH v8 0/2] introduce vdpa sample Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180928073221.GA37170@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=dev@dpdk.org \
    --cc=haiyue.wang@intel.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=roszenrami@gmail.com \
    --cc=tiwei.bie@intel.com \
    --cc=xiao.w.wang@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.