From: Peter Zijlstra <peterz@infradead.org>
To: Song Liu <songliubraving@fb.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Kernel Team <Kernel-team@fb.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Oleg Nesterov <oleg@redhat.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
"Naveen N . Rao" <naveen.n.rao@linux.vnet.ibm.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH RESEND] trace_uprobe: support reference counter in fd-based uprobe
Date: Fri, 28 Sep 2018 09:52:19 +0200 [thread overview]
Message-ID: <20180928075219.GH3439@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <9489EF78-07EA-41AC-8A4D-F3FD3359C826@fb.com>
On Fri, Sep 28, 2018 at 07:23:20AM +0000, Song Liu wrote:
> Hi Peter,
> > #ifdef CONFIG_UPROBE_EVENTS
> > +PMU_FORMAT_ATTR(ref_ctr_offset, "config:63-24");
>
> I guess you meant this part? This is for uprobe only, so I put
> it here.
Ah,.. right you are.
You seem to have the bitfield backwards, does that mean we should write
the bits in backwards too? Seems a tad loopy if you ask me.
Did you instead mean: "config:24-63" ? Also, why 40 bits? 32 seems like
a much more natural amount.
next prev parent reply other threads:[~2018-09-28 7:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 21:12 [PATCH RESEND] trace_uprobe: support reference counter in fd-based uprobe Song Liu
2018-09-25 6:26 ` kbuild test robot
2018-09-25 14:46 ` Song Liu
2018-09-26 16:06 ` Steven Rostedt
2018-09-28 7:18 ` Peter Zijlstra
2018-09-28 7:23 ` Song Liu
2018-09-28 7:52 ` Peter Zijlstra [this message]
2018-09-28 14:50 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180928075219.GH3439@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
--cc=songliubraving@fb.com \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.