From: Niklas Cassel <niklas.cassel@linaro.org>
To: Alex Elder <elder@linaro.org>
Cc: andy.gross@linaro.org, david.brown@linaro.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS
Date: Fri, 28 Sep 2018 14:26:16 +0200 [thread overview]
Message-ID: <20180928122616.GA5249@centauri.lan> (raw)
In-Reply-To: <ec0e7861-4bf0-f135-a881-1a1de4579277@linaro.org>
On Fri, Sep 28, 2018 at 06:41:11AM -0500, Alex Elder wrote:
> Was there something wrong with this patch? I sent it a long time
> ago but it still applies cleanly. I can re-send if you like.
Hello Alex,
This patch does not apply on top of
https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git/log/?h=for-next
When you don't specify a string for a Kconfig, then you won't be able to
select it via menuconfig, only through other Kconfigs, e.g.:
$ git grep QCOM_QMI_HELPERS
drivers/remoteproc/Kconfig: select QCOM_QMI_HELPERS
What Kconfig is it that needs QCOM_QMI_HELPERS?
Why do you need to make is selectable via menuconfig?
Isn't it sufficient to add a "select QCOM_QMI_HELPERS" to that Kconfig?
Kind regards,
Niklas
>
> -Alex
>
> On 04/27/2018 09:03 AM, Alex Elder wrote:
> > Add a prompt to the "tristate" attribute in the Kconfig file in
> > which QCOM_QMI_HELPERS is defined; I find it doesn't get selected
> > without it.
> >
> > Signed-off-by: Alex Elder <elder@linaro.org>
> > ---
> > drivers/soc/qcom/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> > index 5c4535b545cc..81a501765cd9 100644
> > --- a/drivers/soc/qcom/Kconfig
> > +++ b/drivers/soc/qcom/Kconfig
> > @@ -36,7 +36,7 @@ config QCOM_PM
> > low power modes.
> >
> > config QCOM_QMI_HELPERS
> > - tristate
> > + tristate "Qualcomm QMI Helpers"
> > depends on ARCH_QCOM && NET
> > help
> > Helper library for handling QMI encoded messages. QMI encoded
> >
>
next prev parent reply other threads:[~2018-09-28 12:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 14:03 [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS Alex Elder
2018-09-28 11:41 ` Alex Elder
2018-09-28 12:26 ` Niklas Cassel [this message]
2018-09-28 13:23 ` Alex Elder
2018-09-28 14:00 ` Niklas Cassel
2018-09-28 17:21 ` Bjorn Andersson
2018-09-28 17:29 ` Alex Elder
-- strict thread matches above, loose matches on Subject: below --
2021-10-25 16:31 Janusz Dziedzic
2021-10-26 13:42 ` Alex Elder
2021-10-26 18:11 ` Janusz Dziedzic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180928122616.GA5249@centauri.lan \
--to=niklas.cassel@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=elder@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.