From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Fri, 28 Sep 2018 13:10:00 +0000 Subject: Re: [PATCH -next] USB: core: remove set but not used variable 'udev' Message-Id: <20180928131000.GA15118@kroah.com> List-Id: References: <1537597886-136734-1-git-send-email-yuehaibing@huawei.com> In-Reply-To: <1537597886-136734-1-git-send-email-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: YueHaibing Cc: Daniel Drake , Joe Perches , Alan Stern , Mathias Nyman , Felipe Balbi , Martin Liu , linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org On Sat, Sep 22, 2018 at 06:31:26AM +0000, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/usb/core/driver.c: In function 'usb_driver_claim_interface': > drivers/usb/core/driver.c:513:21: warning: > variable 'udev' set but not used [-Wunused-but-set-variable] > > Signed-off-by: YueHaibing > Acked-by: Alan Stern > --- > drivers/usb/core/driver.c | 3 --- > 1 file changed, 3 deletions(-) This patch breaks the build, which is not ok :( From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [-next] USB: core: remove set but not used variable 'udev' From: Greg Kroah-Hartman Message-Id: <20180928131000.GA15118@kroah.com> Date: Fri, 28 Sep 2018 15:10:00 +0200 To: YueHaibing Cc: Daniel Drake , Joe Perches , Alan Stern , Mathias Nyman , Felipe Balbi , Martin Liu , linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org List-ID: T24gU2F0LCBTZXAgMjIsIDIwMTggYXQgMDY6MzE6MjZBTSArMDAwMCwgWXVlSGFpYmluZyB3cm90 ZToKPiBGaXhlcyBnY2MgJy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGUnIHdhcm5pbmc6Cj4gCj4g ZHJpdmVycy91c2IvY29yZS9kcml2ZXIuYzogSW4gZnVuY3Rpb24gJ3VzYl9kcml2ZXJfY2xhaW1f aW50ZXJmYWNlJzoKPiBkcml2ZXJzL3VzYi9jb3JlL2RyaXZlci5jOjUxMzoyMTogd2FybmluZzoK PiAgdmFyaWFibGUgJ3VkZXYnIHNldCBidXQgbm90IHVzZWQgWy1XdW51c2VkLWJ1dC1zZXQtdmFy aWFibGVdCj4gCj4gU2lnbmVkLW9mZi1ieTogWXVlSGFpYmluZyA8eXVlaGFpYmluZ0BodWF3ZWku Y29tPgo+IEFja2VkLWJ5OiBBbGFuIFN0ZXJuIDxzdGVybkByb3dsYW5kLmhhcnZhcmQuZWR1Pgo+ IC0tLQo+ICBkcml2ZXJzL3VzYi9jb3JlL2RyaXZlci5jIHwgMyAtLS0KPiAgMSBmaWxlIGNoYW5n ZWQsIDMgZGVsZXRpb25zKC0pCgpUaGlzIHBhdGNoIGJyZWFrcyB0aGUgYnVpbGQsIHdoaWNoIGlz IG5vdCBvayA6KAo=