From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id DA22CE00A0C; Fri, 28 Sep 2018 10:30:10 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, * medium trust * [198.47.23.249 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's * domain * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id B38FBE009D9 for ; Fri, 28 Sep 2018 10:30:09 -0700 (PDT) Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id w8SHU929092241 for ; Fri, 28 Sep 2018 12:30:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1538155809; bh=sQgzc9pNB1vot3SWivfaivfTfKxbRPfJEp5+UW4tV0k=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=efqAOgXblelKiBCEUpWRJZStOn3+bMOij0PkEh2Qv4URg623q4BXzLo88c5vciWSA CuBOYN4LF0m9KnVtCCT+1ZQHb9NEG43ihQLg+kYrt0j2ToJsjHLiGaoFBEdjO63ima O48JiWwz+LeEfSK2f7edmGFH+/TOBWZEYuH5QLOk= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id w8SHU99g024557 for ; Fri, 28 Sep 2018 12:30:09 -0500 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 28 Sep 2018 12:30:08 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Fri, 28 Sep 2018 12:30:08 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id w8SHU8tH007657; Fri, 28 Sep 2018 12:30:08 -0500 Date: Fri, 28 Sep 2018 13:30:08 -0400 From: Denys Dmytriyenko To: "Radhakrishnan, Mahesh" Message-ID: <20180928173008.GE13888@beryl> References: <1538081009-52859-1-git-send-email-m-radhakrishnan2@ti.com> <1538081009-52859-2-git-send-email-m-radhakrishnan2@ti.com> <20180927213638.GM8582@beryl> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Cc: "meta-ti@yoctoproject.org" Subject: Re: [rocko/master][PATCH v2 01/30] ti-pdk-bbclass: Checking for doxygen support in the correct manner X-BeenThere: meta-ti@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-ti layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Sep 2018 17:30:10 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Fri, Sep 28, 2018 at 10:22:31AM -0400, Radhakrishnan, Mahesh wrote: > > > -----Original Message----- > From: Dmytriyenko, Denys > Sent: Thursday, September 27, 2018 5:37 PM > To: Radhakrishnan, Mahesh > Cc: meta-ti@yoctoproject.org > Subject: Re: [meta-ti] [rocko/master][PATCH v2 01/30] ti-pdk-bbclass: Checking for doxygen support in the correct manner > > On Thu, Sep 27, 2018 at 04:43:00PM -0400, Mahesh Radhakrishnan wrote: > > Signed-off-by: Mahesh Radhakrishnan > > --- > > classes/ti-pdk.bbclass | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/classes/ti-pdk.bbclass b/classes/ti-pdk.bbclass > > index 0716074..f59969f 100644 > > --- a/classes/ti-pdk.bbclass > > +++ b/classes/ti-pdk.bbclass > > @@ -9,8 +9,8 @@ DEPENDS_append_omap-a15 = " ti-cgt-arm-native" > > DEPENDS_remove_ti33x = "ti-cgt6x-native" > > DEPENDS_remove_ti43x = "ti-cgt6x-native" > > DEPENDS_append_omapl1 = " ti-cgt-arm-native" > > -DEPENDS_remove_am65xx-evm = "gcc-arm-none-eabi-native ti-cgt6x-native" > > -DEPENDS_append_am65xx-evm = " ti-cgt-arm-native gcc-linaro-baremetal-aarch64-native" > > +DEPENDS_remove_k3 = "gcc-arm-none-eabi-native ti-cgt6x-native" > > +DEPENDS_append_k3 = " ti-cgt-arm-native gcc-linaro-baremetal-aarch64-native" What about these changes? If you need them, you can send this one patch separately, no need to re-send all 30. > > S = "${WORKDIR}/git" > > B = "${WORKDIR}/build" > > @@ -72,7 +72,7 @@ PARALLEL_XDC = "--jobs=${BB_NUMBER_THREADS}" > > PARALLEL_MAKE = "" > > > > def get_doxygen_support(d): > > - if d.getVar('TI_PDK_DOXYGEN_SUPPORT') == '1': > > + if d.getVar('TI_PDK_DOXYGEN_SUPPORT', True) == '1': > > "Checking for doxygen support in the correct manner" > > Why the change? > > I was thinking it was a bug fix when the doxygen support was added, but I'm wrong . > I see the commit now which explains why this was removed > https://git.yoctoproject.org/cgit/cgit.cgi/meta-ti/commit/classes/ti-pdk.bbclass?h=rocko&id=195d3f7b93b605eccab685b408f354d35a60884e > Apparently meta-processor-sdk-internal's ti-pdk.bbclass didn't catch up with this change. > So, pls ignore this patch. > > > return '' > > return 'DOXYGEN_SUPPORT=no' > > > > -- > > 1.9.1 > > > > -- > > _______________________________________________ > > meta-ti mailing list > > meta-ti@yoctoproject.org > > https://lists.yoctoproject.org/listinfo/meta-ti