All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denys@ti.com>
To: "Xu, Jianzhong" <xuj@ti.com>
Cc: "meta-ti@yoctoproject.org" <meta-ti@yoctoproject.org>
Subject: Re: [PATCH] dsplib/mathlib: remove .metadata folder from packages
Date: Fri, 28 Sep 2018 13:55:57 -0400	[thread overview]
Message-ID: <20180928175557.GH13888@beryl> (raw)
In-Reply-To: <52cc466fc4ff44c397ea6182ec51497b@ti.com>

On Fri, Sep 28, 2018 at 01:38:13PM -0400, Xu, Jianzhong wrote:
> -----Original Message-----
> From: Dmytriyenko, Denys 
> Sent: Friday, September 28, 2018 1:32 PM
> To: Xu, Jianzhong
> Cc: meta-ti@yoctoproject.org
> Subject: Re: [meta-ti] [PATCH] dsplib/mathlib: remove .metadata folder from packages
> 
> On Fri, Sep 28, 2018 at 01:25:48PM -0400, Jianzhong Xu wrote:
> > dsplib/mathlib: remove .metadata folder from dsplib and mathlib packages
> 
> The log says "remove", but that's not what the code does, it seems...
> 
> - Yeah. Maybe "don't add .metadata to packages" is better. Should I resend the patch?

Ok, do not install/deploy .metadata would be clearer.


> > Remove .metadata folder from dsplib and mathlib packages.
> > This folder prevents CCS from finding and installing dsplib and mathlib.
> > 
> > Signed-off-by: Jianzhong Xu <xuj@ti.com>
> > ---
> >  recipes-ti/dsplib/dsplib.inc   | 2 --
> >  recipes-ti/mathlib/mathlib.inc | 2 --
> >  2 files changed, 4 deletions(-)
> > 
> > diff --git a/recipes-ti/dsplib/dsplib.inc b/recipes-ti/dsplib/dsplib.inc
> > index 7180c4a..f369679 100644
> > --- a/recipes-ti/dsplib/dsplib.inc
> > +++ b/recipes-ti/dsplib/dsplib.inc
> > @@ -49,7 +49,6 @@ do_install() {
> >  
> >  	find -name "${DSPLIB_PACKAGE_NAME}.zip" -exec unzip -o {} -d ${D}${DSPLIB_INSTALL_DIR_RECIPE} \;
> >  	mv ${D}${DSPLIB_INSTALL_DIR_RECIPE}/dsplib/* ${D}${DSPLIB_INSTALL_DIR_RECIPE}
> > -	mv ${D}${DSPLIB_INSTALL_DIR_RECIPE}/dsplib/.metadata ${D}${DSPLIB_INSTALL_DIR_RECIPE}
> >  	rm -r ${D}${DSPLIB_INSTALL_DIR_RECIPE}/dsplib
> >  }
> >  
> > @@ -62,7 +61,6 @@ do_deploy() {
> >  	# and place the zip file in ${DEPLOYDIR}
> >  	mkdir ./${DSPLIB_PACKAGE_NAME}
> >  	cp -r ${D}${DSPLIB_INSTALL_DIR_RECIPE}/* ./${DSPLIB_PACKAGE_NAME}
> > -	cp -r ${D}${DSPLIB_INSTALL_DIR_RECIPE}/.metadata ./${DSPLIB_PACKAGE_NAME}
> >  	zip -9 -y -r -q ${DEPLOYDIR}/${DSPLIB_PACKAGE_NAME}.zip ./${DSPLIB_PACKAGE_NAME}
> >  	rm -r ./${DSPLIB_PACKAGE_NAME}
> >  }
> > diff --git a/recipes-ti/mathlib/mathlib.inc b/recipes-ti/mathlib/mathlib.inc
> > index 3e981e4..6aea085 100644
> > --- a/recipes-ti/mathlib/mathlib.inc
> > +++ b/recipes-ti/mathlib/mathlib.inc
> > @@ -48,7 +48,6 @@ do_install() {
> >  
> >  	find -name "${MATHLIB_PACKAGE_NAME}.zip" -exec unzip -o {} -d ${D}${MATHLIB_INSTALL_DIR_RECIPE} \;
> >  	mv ${D}${MATHLIB_INSTALL_DIR_RECIPE}/mathlib/* ${D}${MATHLIB_INSTALL_DIR_RECIPE}
> > -	mv ${D}${MATHLIB_INSTALL_DIR_RECIPE}/mathlib/.metadata ${D}${MATHLIB_INSTALL_DIR_RECIPE}
> >  	rm -r ${D}${MATHLIB_INSTALL_DIR_RECIPE}/mathlib
> >  }
> >  
> > @@ -61,7 +60,6 @@ do_deploy() {
> >  	# and place the zip file in ${DEPLOYDIR}
> >  	mkdir ./${MATHLIB_PACKAGE_NAME}
> >  	cp -r ${D}${MATHLIB_INSTALL_DIR_RECIPE}/* ./${MATHLIB_PACKAGE_NAME}
> > -	cp -r ${D}${MATHLIB_INSTALL_DIR_RECIPE}/.metadata ./${MATHLIB_PACKAGE_NAME}
> >  	zip -9 -y -r -q ${DEPLOYDIR}/${MATHLIB_PACKAGE_NAME}.zip ./${MATHLIB_PACKAGE_NAME}
> >  	rm -r ./${MATHLIB_PACKAGE_NAME}
> >  }
> > -- 
> > 1.9.1
> > 
> > -- 
> > _______________________________________________
> > meta-ti mailing list
> > meta-ti@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-ti


      reply	other threads:[~2018-09-28 17:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-28 17:25 [PATCH] dsplib/mathlib: remove .metadata folder from packages Jianzhong Xu
2018-09-28 17:31 ` Denys Dmytriyenko
2018-09-28 17:38   ` Xu, Jianzhong
2018-09-28 17:55     ` Denys Dmytriyenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180928175557.GH13888@beryl \
    --to=denys@ti.com \
    --cc=meta-ti@yoctoproject.org \
    --cc=xuj@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.