From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Greylist: delayed 512 seconds by postgrey-1.34 at layers.openembedded.org; Fri, 28 Sep 2018 20:19:36 UTC Received: from dent.vctlabs.com (net-cf9a4187.iis.impulse.net [207.154.65.135]) by mail.openembedded.org (Postfix) with ESMTP id 1FB36601D4 for ; Fri, 28 Sep 2018 20:19:36 +0000 (UTC) Received: by dent.vctlabs.com (Postfix, from userid 1000) id F0EDC280599; Fri, 28 Sep 2018 13:14:54 -0700 (PDT) Date: Fri, 28 Sep 2018 13:14:54 -0700 From: "S. Lockwood-Childs" To: Martin Jansa Message-ID: <20180928201454.GW594@vctlabs.com> Mail-Followup-To: "S. Lockwood-Childs" , Martin Jansa , openembedded-devel@lists.openembedded.org References: <20180927140251.4556-1-Martin.Jansa@gmail.com> MIME-Version: 1.0 In-Reply-To: <20180927140251.4556-1-Martin.Jansa@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: openembedded-devel@lists.openembedded.org Subject: Re: [meta-networking][PATCH] libldb: add pam to REQUIRED_DISTRO_FEATURES X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Sep 2018 20:19:37 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Could you explain commit 0db9697dc6b8c a little bit, where libpam became a distro requirement for samba itself? I'm not sure why pam is a hard requirement, rather than being PACKAGECONFIG option. I haven't tried the server ipk built with --without-pam but the client-side pieces are certainly useful. I've got a bbappend to override the pam forcing, and was just wondering if this change might be upstreamable. On Thu, Sep 27, 2018 at 02:02:51PM +0000, Martin Jansa wrote: > * dependency on samba was added recently in: > libldb: Add samba to rdeps for pyldb > so now we need to match samba restriction to prevent: > > ERROR: Nothing RPROVIDES 'samba' (but meta-oe/meta-networking/recipes-support/libldb/libldb_1.4.1.bb RDEPENDS on or otherwise requires it) > samba was skipped: missing required distro feature 'pam' (not in DISTRO_FEATURES) > NOTE: Runtime target 'samba' is unbuildable, removing... > Missing or unbuildable dependency chain was: ['samba'] > ERROR: Required build target 'meta-world-pkgdata' has no buildable providers. > Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'libldb', 'samba'] > > Signed-off-by: Martin Jansa > --- > meta-networking/recipes-support/libldb/libldb_1.4.1.bb | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meta-networking/recipes-support/libldb/libldb_1.4.1.bb b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb > index 99e62f66bb..3c7e5455e9 100644 > --- a/meta-networking/recipes-support/libldb/libldb_1.4.1.bb > +++ b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb > @@ -35,7 +35,8 @@ LIC_FILES_CHKSUM = "file://pyldb.h;endline=24;md5=dfbd238cecad76957f7f860fbe9ada > SRC_URI[md5sum] = "159a1b1a56dcccf410d1bba911be6076" > SRC_URI[sha256sum] = "2df13aa25b376b314ce24182c37691959019523de3cc5356c40c1a333b0890a2" > > -inherit waf-samba > +inherit waf-samba distro_features_check > +REQUIRED_DISTRO_FEATURES = "pam" > > S = "${WORKDIR}/ldb-${PV}" > > -- > 2.17.1 > > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel