From: Tony Lindgren <tony@atomide.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Maciej Purski <m.purski@samsung.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
Carlos Hernandez <ceh@ti.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] regulator: core: Pass max_uV value to regulator_set_voltage_rdev
Date: Fri, 28 Sep 2018 17:27:53 -0700 [thread overview]
Message-ID: <20180929002753.GT5662@atomide.com> (raw)
In-Reply-To: <d14cc796-8644-41a3-5135-299bd8820204@gmail.com>
* Dmitry Osipenko <digetx@gmail.com> [180928 23:55]:
> On 9/29/18 2:17 AM, Dmitry Osipenko wrote:
> > On 9/29/18 1:41 AM, Tony Lindgren wrote:
> >> I'm still getting these errors after init:
> >
> > Thank you very much again, seems I got what's wrong with your case. The ti-abb-regulator driver sets the "abb->current_info_idx = -EINVAL" on probe and that value is getting updated only after the first voltage change, hence _regulator_get_voltage() returns -22.
OK that's starting to make some sense now thanks.
> > Please try this patch:
>
> I've revised the patch and here is the current final version.
Hey cool this one works now :) I suggest you rework the whole series
with these fixes. I recall the series had a problem with git bisect
too between the patches. It will make life easier for other people
who may need to git bisect these patches.
Thanks,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] regulator: core: Pass max_uV value to regulator_set_voltage_rdev
Date: Fri, 28 Sep 2018 17:27:53 -0700 [thread overview]
Message-ID: <20180929002753.GT5662@atomide.com> (raw)
In-Reply-To: <d14cc796-8644-41a3-5135-299bd8820204@gmail.com>
* Dmitry Osipenko <digetx@gmail.com> [180928 23:55]:
> On 9/29/18 2:17 AM, Dmitry Osipenko wrote:
> > On 9/29/18 1:41 AM, Tony Lindgren wrote:
> >> I'm still getting these errors after init:
> >
> > Thank you very much again, seems I got what's wrong with your case. The ti-abb-regulator driver sets the "abb->current_info_idx = -EINVAL" on probe and that value is getting updated only after the first voltage change, hence _regulator_get_voltage() returns -22.
OK that's starting to make some sense now thanks.
> > Please try this patch:
>
> I've revised the patch and here is the current final version.
Hey cool this one works now :) I suggest you rework the whole series
with these fixes. I recall the series had a problem with git bisect
too between the patches. It will make life easier for other people
who may need to git bisect these patches.
Thanks,
Tony
next prev parent reply other threads:[~2018-09-29 0:27 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 22:15 Regression in Linux next again Tony Lindgren
2018-05-29 22:15 ` Tony Lindgren
2018-05-30 9:13 ` Mark Brown
2018-05-30 9:13 ` Mark Brown
2018-05-30 14:03 ` Maciej Purski
2018-05-30 14:03 ` Maciej Purski
2018-05-30 14:33 ` Mark Brown
2018-05-30 14:33 ` Mark Brown
2018-05-30 14:45 ` Tony Lindgren
2018-05-30 14:45 ` Tony Lindgren
2018-06-04 13:59 ` Maciej Purski
2018-06-04 13:59 ` Maciej Purski
2018-06-04 13:59 ` [PATCH 1/7] regulator: core: Add debug messages Maciej Purski
2018-06-04 13:59 ` Maciej Purski
2018-06-04 13:59 ` [PATCH 2/7] regulator: core: Add regulator_set_voltage_rdev() Maciej Purski
2018-06-04 13:59 ` Maciej Purski
2018-06-04 13:59 ` [PATCH 3/7] regulator: core: Use re-entrant locks Maciej Purski
2018-06-04 13:59 ` Maciej Purski
2018-06-04 13:59 ` [PATCH 4/7] regulator: core: Implement voltage balancing algorithm Maciej Purski
2018-06-04 13:59 ` Maciej Purski
2018-06-04 13:59 ` Maciej Purski
2018-06-04 13:59 ` [PATCH 5/7] regulator: core: Lock dependent regulators Maciej Purski
2018-06-04 13:59 ` Maciej Purski
2018-06-04 13:59 ` Maciej Purski
2018-06-04 14:20 ` Lucas Stach
2018-06-04 14:20 ` Lucas Stach
2018-06-18 12:37 ` Maciej Purski
2018-06-18 12:37 ` Maciej Purski
2018-06-04 13:59 ` [PATCH 6/7] regulator: core: Lock dependent regulators on regulator_enable() Maciej Purski
2018-06-04 13:59 ` Maciej Purski
2018-06-04 13:59 ` [PATCH 7/7] regulator: core: Enable voltage balancing Maciej Purski
2018-06-04 13:59 ` Maciej Purski
2018-06-04 23:13 ` kbuild test robot
2018-06-04 23:13 ` kbuild test robot
2018-06-04 23:13 ` kbuild test robot
2018-06-04 23:54 ` kbuild test robot
2018-06-04 23:54 ` kbuild test robot
2018-06-04 23:54 ` kbuild test robot
2018-06-05 4:45 ` Regression in Linux next again Tony Lindgren
2018-06-05 4:45 ` Tony Lindgren
2018-06-13 10:33 ` [PATCH v2] regulator: core: Enable voltage balancing Maciej Purski
2018-06-13 10:33 ` Maciej Purski
2018-06-15 11:29 ` Tony Lindgren
2018-06-15 11:29 ` Tony Lindgren
2018-06-18 13:17 ` Maciej Purski
2018-06-18 13:17 ` Maciej Purski
2018-06-18 14:08 ` [PATCH] regulator: core: Pass max_uV value to regulator_set_voltage_rdev Maciej Purski
2018-06-18 14:08 ` Maciej Purski
2018-07-02 8:05 ` Tony Lindgren
2018-07-02 8:05 ` Tony Lindgren
2018-09-28 20:09 ` Dmitry Osipenko
2018-09-28 20:09 ` Dmitry Osipenko
2018-09-28 20:09 ` Dmitry Osipenko
2018-09-28 20:09 ` Dmitry Osipenko
2018-09-28 20:22 ` Tony Lindgren
2018-09-28 20:22 ` Tony Lindgren
2018-09-28 20:36 ` Dmitry Osipenko
2018-09-28 20:36 ` Dmitry Osipenko
2018-09-28 22:26 ` Dmitry Osipenko
2018-09-28 22:26 ` Dmitry Osipenko
2018-09-28 22:26 ` Dmitry Osipenko
2018-09-28 22:41 ` Tony Lindgren
2018-09-28 22:41 ` Tony Lindgren
2018-09-28 23:17 ` Dmitry Osipenko
2018-09-28 23:17 ` Dmitry Osipenko
2018-09-28 23:17 ` Dmitry Osipenko
2018-09-28 23:51 ` Dmitry Osipenko
2018-09-28 23:51 ` Dmitry Osipenko
2018-09-28 23:51 ` Dmitry Osipenko
2018-09-29 0:27 ` Tony Lindgren [this message]
2018-09-29 0:27 ` Tony Lindgren
2018-09-29 0:44 ` Dmitry Osipenko
2018-09-29 0:44 ` Dmitry Osipenko
2018-10-01 7:25 ` Maciej Purski
2018-10-01 7:25 ` Maciej Purski
2018-10-01 13:34 ` Dmitry Osipenko
2018-10-01 13:34 ` Dmitry Osipenko
2018-05-30 14:53 ` Regression in Linux next again Naresh Kamboju
2018-05-30 14:53 ` Naresh Kamboju
2018-05-31 5:44 ` Naresh Kamboju
2018-05-31 5:44 ` Naresh Kamboju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180929002753.GT5662@atomide.com \
--to=tony@atomide.com \
--cc=broonie@kernel.org \
--cc=ceh@ti.com \
--cc=digetx@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m.purski@samsung.com \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.