From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Hovold Subject: [PATCH 1/2] USB: serial: ftdi_sio: fix gpio name collisions Date: Sun, 30 Sep 2018 14:27:02 +0200 Message-ID: <20180930122703.7115-2-johan@kernel.org> References: <20180930122703.7115-1-johan@kernel.org> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20180930122703.7115-1-johan@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: linux-usb@vger.kernel.org Cc: Karoly Pados , Loic Poulain , Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold List-Id: linux-gpio@vger.kernel.org Drop the gpio line names, which cause gpiolib to complain loudly whenever a second ftdi gpiochip is registered: gpio gpiochip5: Detected name collision for GPIO name 'CBUS0' gpio gpiochip5: Detected name collision for GPIO name 'CBUS1' gpio gpiochip5: Detected name collision for GPIO name 'CBUS2' gpio gpiochip5: Detected name collision for GPIO name 'CBUS3' and also prevents the legacy sysfs interface from being used (as the line names are used as device names whenever they are set): sysfs: cannot create duplicate filename '/class/gpio/CBUS0' Until non-unique names are supported by gpiolib (without warnings and stack dumps), let's leave the gpio lines unnamed. Signed-off-by: Johan Hovold --- drivers/usb/serial/ftdi_sio.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index 6b727ada20cf..be50b2a200aa 100644 --- a/drivers/usb/serial/ftdi_sio.c +++ b/drivers/usb/serial/ftdi_sio.c @@ -1778,10 +1778,6 @@ static void remove_sysfs_attrs(struct usb_serial_port *port) #ifdef CONFIG_GPIOLIB -static const char * const ftdi_ftx_gpio_names[] = { - "CBUS0", "CBUS1", "CBUS2", "CBUS3" -}; - static int ftdi_set_bitmode(struct usb_serial_port *port, u8 mode) { struct ftdi_private *priv = usb_get_serial_port_data(port); @@ -2032,7 +2028,6 @@ static int ftx_gpioconf_init(struct usb_serial_port *port) /* FIXME: FT234XD alone has 1 GPIO, but how to recognize this IC? */ priv->gc.ngpio = 4; - priv->gc.names = ftdi_ftx_gpio_names; /* Determine which pins are configured for CBUS bitbanging */ priv->gpio_altfunc = 0xff; -- 2.19.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/2] USB: serial: ftdi_sio: fix gpio name collisions From: Johan Hovold Message-Id: <20180930122703.7115-2-johan@kernel.org> Date: Sun, 30 Sep 2018 14:27:02 +0200 To: linux-usb@vger.kernel.org Cc: Karoly Pados , Loic Poulain , Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold List-ID: RHJvcCB0aGUgZ3BpbyBsaW5lIG5hbWVzLCB3aGljaCBjYXVzZSBncGlvbGliIHRvIGNvbXBsYWlu IGxvdWRseQp3aGVuZXZlciBhIHNlY29uZCBmdGRpIGdwaW9jaGlwIGlzIHJlZ2lzdGVyZWQ6CgoJ Z3BpbyBncGlvY2hpcDU6IERldGVjdGVkIG5hbWUgY29sbGlzaW9uIGZvciBHUElPIG5hbWUgJ0NC VVMwJwoJZ3BpbyBncGlvY2hpcDU6IERldGVjdGVkIG5hbWUgY29sbGlzaW9uIGZvciBHUElPIG5h bWUgJ0NCVVMxJwoJZ3BpbyBncGlvY2hpcDU6IERldGVjdGVkIG5hbWUgY29sbGlzaW9uIGZvciBH UElPIG5hbWUgJ0NCVVMyJwoJZ3BpbyBncGlvY2hpcDU6IERldGVjdGVkIG5hbWUgY29sbGlzaW9u IGZvciBHUElPIG5hbWUgJ0NCVVMzJwoKYW5kIGFsc28gcHJldmVudHMgdGhlIGxlZ2FjeSBzeXNm cyBpbnRlcmZhY2UgZnJvbSBiZWluZyB1c2VkIChhcyB0aGUKbGluZSBuYW1lcyBhcmUgdXNlZCBh cyBkZXZpY2UgbmFtZXMgd2hlbmV2ZXIgdGhleSBhcmUgc2V0KToKCglzeXNmczogY2Fubm90IGNy ZWF0ZSBkdXBsaWNhdGUgZmlsZW5hbWUgJy9jbGFzcy9ncGlvL0NCVVMwJwoKVW50aWwgbm9uLXVu aXF1ZSBuYW1lcyBhcmUgc3VwcG9ydGVkIGJ5IGdwaW9saWIgKHdpdGhvdXQgd2FybmluZ3MgYW5k CnN0YWNrIGR1bXBzKSwgbGV0J3MgbGVhdmUgdGhlIGdwaW8gbGluZXMgdW5uYW1lZC4KClNpZ25l ZC1vZmYtYnk6IEpvaGFuIEhvdm9sZCA8am9oYW5Aa2VybmVsLm9yZz4KLS0tCiBkcml2ZXJzL3Vz Yi9zZXJpYWwvZnRkaV9zaW8uYyB8IDUgLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA1IGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL3NlcmlhbC9mdGRpX3Npby5jIGIvZHJpdmVy cy91c2Ivc2VyaWFsL2Z0ZGlfc2lvLmMKaW5kZXggNmI3MjdhZGEyMGNmLi5iZTUwYjJhMjAwYWEg MTAwNjQ0Ci0tLSBhL2RyaXZlcnMvdXNiL3NlcmlhbC9mdGRpX3Npby5jCisrKyBiL2RyaXZlcnMv dXNiL3NlcmlhbC9mdGRpX3Npby5jCkBAIC0xNzc4LDEwICsxNzc4LDYgQEAgc3RhdGljIHZvaWQg cmVtb3ZlX3N5c2ZzX2F0dHJzKHN0cnVjdCB1c2Jfc2VyaWFsX3BvcnQgKnBvcnQpCiAKICNpZmRl ZiBDT05GSUdfR1BJT0xJQgogCi1zdGF0aWMgY29uc3QgY2hhciAqIGNvbnN0IGZ0ZGlfZnR4X2dw aW9fbmFtZXNbXSA9IHsKLQkiQ0JVUzAiLCAiQ0JVUzEiLCAiQ0JVUzIiLCAiQ0JVUzMiCi19Owot CiBzdGF0aWMgaW50IGZ0ZGlfc2V0X2JpdG1vZGUoc3RydWN0IHVzYl9zZXJpYWxfcG9ydCAqcG9y dCwgdTggbW9kZSkKIHsKIAlzdHJ1Y3QgZnRkaV9wcml2YXRlICpwcml2ID0gdXNiX2dldF9zZXJp YWxfcG9ydF9kYXRhKHBvcnQpOwpAQCAtMjAzMiw3ICsyMDI4LDYgQEAgc3RhdGljIGludCBmdHhf Z3Bpb2NvbmZfaW5pdChzdHJ1Y3QgdXNiX3NlcmlhbF9wb3J0ICpwb3J0KQogCiAJLyogRklYTUU6 IEZUMjM0WEQgYWxvbmUgaGFzIDEgR1BJTywgYnV0IGhvdyB0byByZWNvZ25pemUgdGhpcyBJQz8g Ki8KIAlwcml2LT5nYy5uZ3BpbyA9IDQ7Ci0JcHJpdi0+Z2MubmFtZXMgPSBmdGRpX2Z0eF9ncGlv X25hbWVzOwogCiAJLyogRGV0ZXJtaW5lIHdoaWNoIHBpbnMgYXJlIGNvbmZpZ3VyZWQgZm9yIENC VVMgYml0YmFuZ2luZyAqLwogCXByaXYtPmdwaW9fYWx0ZnVuYyA9IDB4ZmY7Cg==