All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Borislav Petkov <bp@alien8.de>
Cc: netdev@vger.kernel.org, Pablo Neira Ayuso <pablo@netfilter.org>,
	Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
	Florian Westphal <fw@strlen.de>,
	"David S. Miller" <davem@davemloft.net>,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	linux-kernel@vger.kernel.org
Subject: Re: __nf_register_net_hook jump label splat
Date: Sun, 30 Sep 2018 19:39:30 +0200	[thread overview]
Message-ID: <20180930173930.kyciz5vll23vpjw2@breakpoint.cc> (raw)
In-Reply-To: <20180929230409.GA27207@zn.tnic>

Borislav Petkov <bp@alien8.de> wrote:
> Hi people,
> 
> this is something new I'm triggering with rc5 + tip/master while rc4 +
> tip/master is fine. Any ideas?

No clue.  I don't see any netfilter changes between rc4 & rc5.
I just tried to set up a bridge on rc5 with call-iptables=1
and I see no such splat.

> If I had to guess, it looks like this thing:
> 
> #ifdef HAVE_JUMP_LABEL
>         static_key_slow_inc(&nf_hooks_needed[pf][reg->hooknum]);
> #endif

Strange, these static keys have been there for years.
Any chance you could send your .config or bisect this?

Thanks.

  reply	other threads:[~2018-09-30 17:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-29 23:04 __nf_register_net_hook jump label splat Borislav Petkov
2018-09-30 17:39 ` Florian Westphal [this message]
2018-09-30 18:31   ` Borislav Petkov
2018-10-01 20:57     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180930173930.kyciz5vll23vpjw2@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=bp@alien8.de \
    --cc=coreteam@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.