diff for duplicates of <20180930230953.GA12922@flashbox> diff --git a/a/1.txt b/N1/1.txt index 2d1a477..8df099d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -21,12 +21,12 @@ On Sun, Sep 30, 2018 at 11:31:23PM +0100, Colin King wrote: > MPT_ADAPTER *ioc = (MPT_ADAPTER *)arg; > struct pci_dev *pdev; > -> - if ((ioc = NULL)) +> - if ((ioc == NULL)) > + if (!ioc) > return -1; > > pdev = ioc->pcidev; -> - if ((pdev = NULL)) +> - if ((pdev == NULL)) > + if (!pdev) > return -1; > @@ -37,7 +37,7 @@ On Sun, Sep 30, 2018 at 11:31:23PM +0100, Colin King wrote: Hi Colin, -I already sent a patch that was picked up by Martin a few days ago: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?idded4e2005b1195a5e781009be991e1cd049c10 +I already sent a patch that was picked up by Martin a few days ago: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?id=90ded4e2005b1195a5e781009be991e1cd049c10 I've been sending several warning fixes for Clang over the past few weeks that have been documented on GitHub. You may consider checking diff --git a/a/content_digest b/N1/content_digest index 4d8c4ad..9ca1247 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020180930223123.17907-1-colin.king@canonical.com\0" "From\0Nathan Chancellor <natechancellor@gmail.com>\0" "Subject\0Re: [PATCH] scsi: message: fusion: clean up clang warning on extraneous parentheses\0" - "Date\0Sun, 30 Sep 2018 23:09:53 +0000\0" + "Date\0Sun, 30 Sep 2018 16:09:53 -0700\0" "To\0Colin King <colin.king@canonical.com>\0" "Cc\0Sathya Prakash <sathya.prakash@broadcom.com>" Chaitra P B <chaitra.basappa@broadcom.com> @@ -35,12 +35,12 @@ "> \tMPT_ADAPTER *ioc = (MPT_ADAPTER *)arg;\n" "> \tstruct pci_dev *pdev;\n" "> \n" - "> -\tif ((ioc = NULL))\n" + "> -\tif ((ioc == NULL))\n" "> +\tif (!ioc)\n" "> \t\treturn -1;\n" "> \n" "> \tpdev = ioc->pcidev;\n" - "> -\tif ((pdev = NULL))\n" + "> -\tif ((pdev == NULL))\n" "> +\tif (!pdev)\n" "> \t\treturn -1;\n" "> \n" @@ -51,7 +51,7 @@ "\n" "Hi Colin,\n" "\n" - "I already sent a patch that was picked up by Martin a few days ago: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?id\302\220ded4e2005b1195a5e781009be991e1cd049c10\n" + "I already sent a patch that was picked up by Martin a few days ago: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?id=90ded4e2005b1195a5e781009be991e1cd049c10\n" "\n" "I've been sending several warning fixes for Clang over the past few\n" "weeks that have been documented on GitHub. You may consider checking\n" @@ -62,4 +62,4 @@ "Cheers!\n" Nathan -ba795e33868a82f2c2558344c28fbcedd54f01f72e27c45ff8985c47ce2ff0ae +d6c2f4b4d3f70949ca5a7c2a90505753afe34d70fab7ae16e3b33f0974bc66e1
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.