From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nathan Chancellor Date: Sun, 30 Sep 2018 23:09:53 +0000 Subject: Re: [PATCH] scsi: message: fusion: clean up clang warning on extraneous parentheses Message-Id: <20180930230953.GA12922@flashbox> List-Id: References: <20180930223123.17907-1-colin.king@canonical.com> In-Reply-To: <20180930223123.17907-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1254" Content-Transfer-Encoding: base64 To: Colin King Cc: Sathya Prakash , Chaitra P B , Suganath Prabu Subramani , MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org T24gU3VuLCBTZXAgMzAsIDIwMTggYXQgMTE6MzE6MjNQTSArMDEwMCwgQ29saW4gS2luZyB3cm90 ZToKPiBGcm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPgo+IAo+ IFRoZXJlIGFyZSBleHRyYW5lb3VzIHBhcmFudGhlc2VzIHRoYXQgYXJlIGNhdXNpbmcgY2xhbmcg dG8gcHJvZHVjZSBhCj4gd2FybmluZyBzbyByZW1vdmUgdGhlc2UuIEFsc28gcmVwbGFjZSBwb2lu dGVyIGNvbXBhcmlzb24gd2l0aCBOVUxMCj4gd2l0aCB0aGUgIXB0ciBpZGlvbS4KPiAKPiBDbGVh biB1cCBjbGFuZyB3YXJuaW5nczoKPiBlcXVhbGl0eSBjb21wYXJpc29uIHdpdGggZXh0cmFuZW91 cyBwYXJlbnRoZXNlcyBbLVdwYXJlbnRoZXNlcy1lcXVhbGl0eV0KPiAKPiBTaWduZWQtb2ZmLWJ5 OiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPgo+IC0tLQo+ICBkcml2 ZXJzL21lc3NhZ2UvZnVzaW9uL21wdGJhc2UuYyB8IDQgKystLQo+ICAxIGZpbGUgY2hhbmdlZCwg MiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L21lc3NhZ2UvZnVzaW9uL21wdGJhc2UuYyBiL2RyaXZlcnMvbWVzc2FnZS9mdXNpb24vbXB0YmFz ZS5jCj4gaW5kZXggZGMxZTQzYTAyNTk5Li5iYTU1MWQ4ZGZiYTQgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9tZXNzYWdlL2Z1c2lvbi9tcHRiYXNlLmMKPiArKysgYi9kcml2ZXJzL21lc3NhZ2UvZnVz aW9uL21wdGJhc2UuYwo+IEBAIC0zMzUsMTEgKzMzNSwxMSBAQCBzdGF0aWMgaW50IG1wdF9yZW1v dmVfZGVhZF9pb2NfZnVuYyh2b2lkICphcmcpCj4gIAlNUFRfQURBUFRFUiAqaW9jID0gKE1QVF9B REFQVEVSICopYXJnOwo+ICAJc3RydWN0IHBjaV9kZXYgKnBkZXY7Cj4gIAo+IC0JaWYgKChpb2Mg PSBOVUxMKSkKPiArCWlmICghaW9jKQo+ICAJCXJldHVybiAtMTsKPiAgCj4gIAlwZGV2ID0gaW9j LT5wY2lkZXY7Cj4gLQlpZiAoKHBkZXYgPSBOVUxMKSkKPiArCWlmICghcGRldikKPiAgCQlyZXR1 cm4gLTE7Cj4gIAo+ICAJcGNpX3N0b3BfYW5kX3JlbW92ZV9idXNfZGV2aWNlX2xvY2tlZChwZGV2 KTsKPiAtLSAKPiAyLjE3LjEKPiAKCkhpIENvbGluLAoKSSBhbHJlYWR5IHNlbnQgYSBwYXRjaCB0 aGF0IHdhcyBwaWNrZWQgdXAgYnkgTWFydGluIGEgZmV3IGRheXMgYWdvOiBodHRwczovL2dpdC5r ZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9ta3Avc2NzaS5naXQvY29tbWl0Lz9p ZJBkZWQ0ZTIwMDViMTE5NWE1ZTc4MTAwOWJlOTkxZTFjZDA0OWMxMAoKSSd2ZSBiZWVuIHNlbmRp bmcgc2V2ZXJhbCB3YXJuaW5nIGZpeGVzIGZvciBDbGFuZyBvdmVyIHRoZSBwYXN0IGZldwp3ZWVr cyB0aGF0IGhhdmUgYmVlbiBkb2N1bWVudGVkIG9uIEdpdEh1Yi4gWW91IG1heSBjb25zaWRlciBj aGVja2luZwp0aGVtIG91dCBzaW5jZSBJIGhhdmUgc3RhcnRlZCB0byBzZWUgc29tZSBvdmVybGFw LgoKTGluazogaHR0cHM6Ly9naXRodWIuY29tL0NsYW5nQnVpbHRMaW51eC9saW51eC9pc3N1ZXMK CkNoZWVycyEKTmF0aGFu From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nathan Chancellor Subject: Re: [PATCH] scsi: message: fusion: clean up clang warning on extraneous parentheses Date: Sun, 30 Sep 2018 16:09:53 -0700 Message-ID: <20180930230953.GA12922@flashbox> References: <20180930223123.17907-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180930223123.17907-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org To: Colin King Cc: Sathya Prakash , Chaitra P B , Suganath Prabu Subramani , MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On Sun, Sep 30, 2018 at 11:31:23PM +0100, Colin King wrote: > From: Colin Ian King > > There are extraneous parantheses that are causing clang to produce a > warning so remove these. Also replace pointer comparison with NULL > with the !ptr idiom. > > Clean up clang warnings: > equality comparison with extraneous parentheses [-Wparentheses-equality] > > Signed-off-by: Colin Ian King > --- > drivers/message/fusion/mptbase.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c > index dc1e43a02599..ba551d8dfba4 100644 > --- a/drivers/message/fusion/mptbase.c > +++ b/drivers/message/fusion/mptbase.c > @@ -335,11 +335,11 @@ static int mpt_remove_dead_ioc_func(void *arg) > MPT_ADAPTER *ioc = (MPT_ADAPTER *)arg; > struct pci_dev *pdev; > > - if ((ioc == NULL)) > + if (!ioc) > return -1; > > pdev = ioc->pcidev; > - if ((pdev == NULL)) > + if (!pdev) > return -1; > > pci_stop_and_remove_bus_device_locked(pdev); > -- > 2.17.1 > Hi Colin, I already sent a patch that was picked up by Martin a few days ago: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?id=90ded4e2005b1195a5e781009be991e1cd049c10 I've been sending several warning fixes for Clang over the past few weeks that have been documented on GitHub. You may consider checking them out since I have started to see some overlap. Link: https://github.com/ClangBuiltLinux/linux/issues Cheers! Nathan