From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: nbd@nbd.name, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mt76x0: pci: add mt76x0e_cleanup routine
Date: Mon, 1 Oct 2018 10:22:24 +0200 [thread overview]
Message-ID: <20181001082224.GA3055@localhost.localdomain> (raw)
In-Reply-To: <20181001054239.GA22206@redhat.com>
On Oct 01, Stanislaw Gruszka wrote:
> Hi
>
> On Sat, Sep 29, 2018 at 07:26:41PM +0200, Lorenzo Bianconi wrote:
> > Add mt76x0e_cleanup routine to tidy up the device
> > during netdevice removal
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> > + mt76_wr(dev, MT_H2M_MAILBOX_CID, ~0);
> > + mt76_wr(dev, MT_H2M_MAILBOX_STATUS, ~0);
>
> I don't think this is needed. Those are legacy communication registers,
> most likely not used in new chips and stay in vendor driver, because
> it wasn't cleaned up.
Ack, I will remove them in v2.
Regards,
Lorenzo
>
> Regards
> Stanislaw
>
prev parent reply other threads:[~2018-10-01 8:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-29 17:26 [PATCH] mt76x0: pci: add mt76x0e_cleanup routine Lorenzo Bianconi
2018-10-01 5:42 ` Stanislaw Gruszka
2018-10-01 8:22 ` Lorenzo Bianconi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181001082224.GA3055@localhost.localdomain \
--to=lorenzo.bianconi@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.