From: Kalle Valo <kvalo@codeaurora.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
Govind Singh <govinds@codeaurora.org>,
<linux-kernel@vger.kernel.org>,
Brian Norris <briannorris@chromium.org>
Subject: Re: [PATCH] ath10k: utilize random MAC address if none is provided
Date: Mon, 1 Oct 2018 13:54:18 +0000 (UTC) [thread overview]
Message-ID: <20181001135418.88D9260B7A@smtp.codeaurora.org> (raw)
In-Reply-To: <20180907172157.203785-1-briannorris@chromium.org>
Brian Norris <briannorris@chromium.org> wrote:
> Since commit 9d5804662ce1 ("ath10k: retrieve MAC address from system
> firmware if provided"), we support pulling our MAC address from system
> firmware. Along with this, we should admit that it's possible for system
> firmware to be screwed up as well, omitting the MAC address there.
>
> Provide a fallback, such that we choose a randomly-generated MAC
> address, with the local assignment bit set.
>
> This is not a preferred mode of operation and really should only serve
> the purpose of keeping the system chugging along while someone figures
> out what's wrong with the system. Grepping through other wireless
> drivers shows very similar fallback logic though, so why not?
>
> git grep eth_random_addr drivers/net/wireless/
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
234e4307cf7f ath10k: utilize random MAC address if none is provided
--
https://patchwork.kernel.org/patch/10592411/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2018-10-01 13:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 17:21 [PATCH] ath10k: utilize random MAC address if none is provided Brian Norris
2018-09-07 17:21 ` Brian Norris
2018-10-01 13:54 ` Kalle Valo [this message]
2018-10-01 13:54 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181001135418.88D9260B7A@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=briannorris@chromium.org \
--cc=govinds@codeaurora.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.