From: Ajay Singh <ajay.kathat@microchip.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <linux-wireless@vger.kernel.org>, <devel@driverdev.osuosl.org>,
<venkateswara.kaja@microchip.com>, <gregkh@linuxfoundation.org>,
<ganesh.krishna@microchip.com>, <adham.abozaeid@microchip.com>,
<aditya.shankar@microchip.com>
Subject: Re: [PATCH v3 00/29] staging: wilc1000: avoid static variables and cleanup changes
Date: Mon, 1 Oct 2018 14:29:29 +0530 [thread overview]
Message-ID: <20181001142929.7fc422d0@ajaysk-VirtualBox> (raw)
In-Reply-To: <20181001074734.w766omhed4ri3zuy@mwanda>
Hi Dan,
On Mon, 1 Oct 2018 10:47:34 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Tue, Sep 25, 2018 at 11:53:15AM +0530, Ajay Singh wrote:
> > This patch series contains changes to avoid the use of static
> > variables. Cleanup changes to fix some checkpatch issues and return
> > void for function if their return value is not used.
> > Also deleted 'wilc_debugfs.c' file as it's not used.
> >
> > Changes since v2:
> > Included Joe's suggestion for patch#28
> > - replaced previous patch with an improved version(refactor
> > code)
> >
> > Changes since v1:
> > Address Dan's comment for patch#29
> > - return the correct error for failure in the second iteration
>
> Btw, I hate re-reviewing patches and I know everyone hates sending
> them. If someone complains about a 28/29 or a 29/29, then you can
> just ask Greg to apply the first 27 and redo the others in a follow
> on patchset.
>
Sure, I will keep this point in mind while sending the series updates.
Regards
Ajay
prev parent reply other threads:[~2018-10-01 8:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 6:23 [PATCH v3 00/29] staging: wilc1000: avoid static variables and cleanup changes Ajay Singh
2018-09-25 6:23 ` [PATCH v3 01/29] staging: wilc1000: change return type to 'void' for wilc_frame_register() Ajay Singh
2018-09-25 6:23 ` [PATCH v3 02/29] staging: wilc1000: change return type to 'void' for wilc_wlan_set_bssid() Ajay Singh
2018-09-25 6:23 ` [PATCH v3 03/29] staging: wilc1000: change return type to 'void' for lock init & deinit functions Ajay Singh
2018-09-25 6:23 ` [PATCH v3 04/29] staging: wilc1000: change return type to 'void' for wilc_deinit_host_int() Ajay Singh
2018-09-25 6:23 ` [PATCH v3 05/29] staging: wilc1000: change return type to 'void' for wilc_wfi_deinit_mon_interface() Ajay Singh
2018-09-25 6:23 ` [PATCH v3 06/29] staging: wilc1000: use 'void' return type for host_int_get_assoc_res_info() Ajay Singh
2018-09-25 6:23 ` [PATCH v3 07/29] staging: wilc1000: use 'void' return for wilc_wlan_txq_add_to_head() Ajay Singh
2018-09-25 6:23 ` [PATCH v3 08/29] staging: wilc1000: change return type to 'void' tcp ack filter functions Ajay Singh
2018-09-25 6:23 ` [PATCH v3 09/29] staging: wilc1000: use 'void' return for wilc_wlan_txq_filter_dup_tcp_ack() Ajay Singh
2018-09-25 6:23 ` [PATCH v3 10/29] staging: wilc1000: change return type to 'void' for wilc_wlan_cfg_indicate_rx() Ajay Singh
2018-09-25 6:23 ` [PATCH v3 11/29] staging: wilc1000: refactor wilc_wlan_parse_info_frame() function Ajay Singh
2018-09-25 6:23 ` [PATCH v3 12/29] staging: wilc1000: set default value of cfg response type in wilc_wlan_cfg_indicate_rx() Ajay Singh
2018-09-25 6:23 ` [PATCH v3 13/29] staging: wilc1000: changes 'val' type to u8 in wilc_cfg_byte struct Ajay Singh
2018-09-25 6:23 ` [PATCH v3 14/29] staging: wilc1000: remove unused wid type values Ajay Singh
2018-09-25 6:23 ` [PATCH v3 15/29] staging: wilc1000: remove unused wid from cfg struct Ajay Singh
2018-09-25 6:23 ` [PATCH v3 16/29] staging: wilc1000: refactor code to remove 'mac_status' from 'wilc_mac_cfg' struct Ajay Singh
2018-09-25 6:23 ` [PATCH v3 17/29] staging: wilc1000: refactor code to avoid static variables for config parameters Ajay Singh
2018-09-25 6:23 ` [PATCH v3 18/29] staging: wilc1000: rename 'wilc_mac_cfg' struct to 'wilc_cfg_str_vals' Ajay Singh
2018-09-25 6:23 ` [PATCH v3 19/29] staging: wilc1000: avoid the use of 'hif_driver_comp' completion variable Ajay Singh
2018-09-25 6:23 ` [PATCH v3 20/29] staging: wilc1000: remove use of unnecessary 'wilc_connected_ssid' variable Ajay Singh
2018-09-25 6:23 ` [PATCH v3 21/29] staging: wilc1000: avoid use of 'g_sdio' static variable Ajay Singh
2018-09-25 6:23 ` [PATCH v3 22/29] staging: wilc1000: avoid use of 'g_spi' " Ajay Singh
2018-09-25 6:23 ` [PATCH v3 23/29] staging: wilc1000: remove unnecessary memset in sdio_init() & wilc_spi_init() Ajay Singh
2018-09-25 6:23 ` [PATCH v3 24/29] staging: wilc1000: remove p2p related static variables to wilc_vif struct Ajay Singh
2018-09-25 6:23 ` [PATCH v3 25/29] staging: wilc1000: remove wilc_debugfs.c file as its not used Ajay Singh
2018-09-25 6:23 ` [PATCH v3 26/29] staging: wilc1000: remove unnecessary option used with ccflags-y in Makefile Ajay Singh
2018-09-25 6:23 ` [PATCH v3 27/29] staging: wilc1000: use usleep_range() in place of udelay() Ajay Singh
2018-09-25 6:23 ` [PATCH v3 28/29] staging: wilc1000: refactor wilc_set_multicast_list() function Ajay Singh
2018-09-25 6:23 ` [PATCH v3 29/29] staging: wilc1000: return exact error of register_netdev() from wilc_netdev_init() Ajay Singh
2018-10-01 7:47 ` [PATCH v3 00/29] staging: wilc1000: avoid static variables and cleanup changes Dan Carpenter
2018-10-01 8:59 ` Ajay Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181001142929.7fc422d0@ajaysk-VirtualBox \
--to=ajay.kathat@microchip.com \
--cc=adham.abozaeid@microchip.com \
--cc=aditya.shankar@microchip.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=ganesh.krishna@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-wireless@vger.kernel.org \
--cc=venkateswara.kaja@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.