From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 5/8] mtd: maps: gpio-addr-flash: Replace array with an integer
Date: Mon, 1 Oct 2018 14:32:19 +0200 [thread overview]
Message-ID: <20181001143219.59423ad3@bbrezillon> (raw)
In-Reply-To: <CAPybu_18jdEWEbAbYd4k-GPD+77sCA_5na0RJznixPEXkcs+kQ@mail.gmail.com>
On Mon, 1 Oct 2018 14:10:03 +0200
Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> wrote:
> > > + return;
> > > +
> > > + for (i = 0; i < state->gpio_count; i++) {
> > > + if ((ofs & BIT(i)) == (state->gpio_values & BIT(i)))
> >
> > Parens around the xx & BIT(i) operations are unneeded.
>
> If I remove it:
>
>
> ricardo@neopili:~/curro/kernel-upstream$ make drivers/mtd/maps/gpio-addr-flash.o
> CALL scripts/checksyscalls.sh
> DESCEND objtool
> CC drivers/mtd/maps/gpio-addr-flash.o
> drivers/mtd/maps/gpio-addr-flash.c: In function ‘gf_set_gpios’:
> drivers/mtd/maps/gpio-addr-flash.c:70:20: warning: suggest parentheses
> around comparison in operand of ‘&’ [-Wparentheses]
> if (ofs & BIT(i) == (state->gpio_values & BIT(i)))
Hm, okay. I remember having a similar discussion on one of my patch and
people suggesting to drop it because of the == precedence on x & a.
Anyway, let's just keep it like that.
next prev parent reply other threads:[~2018-10-01 12:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 14:36 [PATCH v2 0/8] gpio-addr-flash: Support for device-tree and cleanup Ricardo Ribalda Delgado
2018-09-05 14:36 ` Ricardo Ribalda Delgado
2018-09-05 14:36 ` [PATCH v2 1/8] mtd: maps: gpio-addr-flash: Replace custom printk Ricardo Ribalda Delgado
2018-09-05 14:36 ` [PATCH v2 2/8] mtd: maps: gpio-addr-flash: Fix ioremapped size Ricardo Ribalda Delgado
2018-09-05 14:36 ` Ricardo Ribalda Delgado
2018-09-05 14:36 ` [PATCH v2 3/8] mtd: maps: gpio-addr-flash: Use devm_* functions Ricardo Ribalda Delgado
2018-09-27 11:35 ` Boris Brezillon
2018-09-29 6:24 ` Ricardo Ribalda Delgado
2018-09-05 14:36 ` [PATCH v2 4/8] mtd: maps: gpio-addr-flash: Use order insted of size Ricardo Ribalda Delgado
2018-09-05 14:36 ` [PATCH v2 5/8] mtd: maps: gpio-addr-flash: Replace array with an integer Ricardo Ribalda Delgado
2018-09-27 11:42 ` Boris Brezillon
2018-10-01 12:10 ` Ricardo Ribalda Delgado
2018-10-01 12:32 ` Boris Brezillon [this message]
2018-09-05 14:36 ` [PATCH v2 6/8] mtd: maps: gpio-addr-flash: Split allocation in two Ricardo Ribalda Delgado
2018-10-01 9:58 ` Ricardo Ribalda Delgado
2018-10-01 11:38 ` Boris Brezillon
2018-10-01 11:40 ` Ricardo Ribalda Delgado
2018-09-05 14:36 ` [PATCH v2 7/8] mtd: maps: gpio-addr-flash: Add support for device-tree devices Ricardo Ribalda Delgado
2018-09-05 14:36 ` Ricardo Ribalda Delgado
2018-09-27 11:39 ` Boris Brezillon
2018-09-05 14:36 ` [PATCH v2 8/8] dt-binding: mtd: Document gpio-addr-flash Ricardo Ribalda Delgado
2018-09-05 14:36 ` Ricardo Ribalda Delgado
2018-09-25 20:48 ` Rob Herring
2018-09-26 6:33 ` Ricardo Ribalda Delgado
2018-09-26 6:39 ` [PATCH v3 " Ricardo Ribalda Delgado
2018-09-27 20:03 ` Rob Herring
2018-09-27 20:03 ` Rob Herring
2018-09-20 19:46 ` [PATCH v2 0/8] gpio-addr-flash: Support for device-tree and cleanup Ricardo Ribalda Delgado
2018-09-27 11:47 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181001143219.59423ad3@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=ricardo.ribalda@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.