From: Niklas Cassel <niklas.cassel@linaro.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Doug Anderson <dianders@chromium.org>
Subject: Re: [PATCH v3 0/3] pinctrl: msm interrupt and muxing fixes
Date: Mon, 1 Oct 2018 21:34:14 +0200 [thread overview]
Message-ID: <20181001193414.GA4441@centauri.lan> (raw)
In-Reply-To: <153841961783.119890.13486677118739554119@swboyd.mtv.corp.google.com>
On Mon, Oct 01, 2018 at 11:46:57AM -0700, Stephen Boyd wrote:
> Quoting Niklas Cassel (2018-09-12 03:34:31)
> > Hello Stephen,
> >
> > I'm getting this warning on dragonboard 820c (msm8996) when booting linux-next:
> >
> > [ 3.211575] WARNING: CPU: 1 PID: 1 at drivers/pinctrl/qcom/pinctrl-msm.c:164 msm_pinmux_set_mux+0xc8/0x150
> > [ 3.212127] l28: ramp_delay not set
>
> Thanks for testing. I think the problem is I messed up the function 0
> and enum 0. Can you try this patch?
Hello Stephen,
This patch does indeed remove the warning.
Thanks!
Kind regards,
Niklas
>
> --8<---
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
> index 1684b2da09d5..b925b8feac95 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -188,7 +188,7 @@ static int msm_pinmux_request_gpio(struct pinctrl_dev *pctldev,
> return 0;
>
> /* For now assume function 0 is GPIO because it always is */
> - return msm_pinmux_set_mux(pctldev, 0, offset);
> + return msm_pinmux_set_mux(pctldev, g->funcs[0], offset);
> }
>
> static const struct pinmux_ops msm_pinmux_ops = {
prev parent reply other threads:[~2018-10-01 19:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 20:06 [PATCH v3 0/3] pinctrl: msm interrupt and muxing fixes Stephen Boyd
2018-08-16 20:06 ` [PATCH v3 1/3] pinctrl: msm: Really mask level interrupts to prevent latching Stephen Boyd
2018-08-16 20:49 ` Doug Anderson
2018-08-23 7:57 ` Linus Walleij
2018-08-27 3:05 ` Bjorn Andersson
2018-08-29 7:40 ` Linus Walleij
2018-08-29 7:44 ` Linus Walleij
2018-08-16 20:06 ` [PATCH v3 2/3] pinctrl: msm: Mux out gpio function with gpio_request() Stephen Boyd
2018-08-27 3:06 ` Bjorn Andersson
2018-08-29 7:42 ` Linus Walleij
2018-08-16 20:06 ` [PATCH v3 3/3] pinctrl: msm: Configure interrupts as input and gpio mode Stephen Boyd
2018-08-27 3:06 ` Bjorn Andersson
2018-08-29 7:43 ` Linus Walleij
2018-09-12 10:34 ` [PATCH v3 0/3] pinctrl: msm interrupt and muxing fixes Niklas Cassel
2018-10-01 18:46 ` Stephen Boyd
2018-10-01 19:34 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181001193414.GA4441@centauri.lan \
--to=niklas.cassel@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.