From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
linux@roeck-us.net, Kees Cook <keescook@chromium.org>,
Ingo Molnar <mingo@redhat.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Jessica Yu <jeyu@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] s390: vmlinux.lds: move JUMP_TABLE_DATA into output section
Date: Mon, 1 Oct 2018 22:25:38 +0200 [thread overview]
Message-ID: <20181001202538.GB4958@osiris> (raw)
In-Reply-To: <20180930164950.3841-1-ard.biesheuvel@linaro.org>
On Sun, Sep 30, 2018 at 06:49:50PM +0200, Ard Biesheuvel wrote:
> Commit e872267b8bcbb179 ("jump_table: move entries into ro_after_init
> region") moved the __jump_table input section into the __ro_after_init
> output section, but inadvertently put the macro in the wrong place in
> the s390 linker script. Let's fix that.
>
> Fixes: e872267b8bcbb179 ("jump_table: move entries into ro_after_init region")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Cc: Jessica Yu <jeyu@kernel.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> arch/s390/kernel/vmlinux.lds.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>
I don't think this is very obvious, but this fixes current build breakage
in linux-next and I assume Thomas should pick this up.
> diff --git a/arch/s390/kernel/vmlinux.lds.S b/arch/s390/kernel/vmlinux.lds.S
> index 4042bbf3f9ad..457713f48734 100644
> --- a/arch/s390/kernel/vmlinux.lds.S
> +++ b/arch/s390/kernel/vmlinux.lds.S
> @@ -64,9 +64,9 @@ SECTIONS
> __start_ro_after_init = .;
> .data..ro_after_init : {
> *(.data..ro_after_init)
> + JUMP_TABLE_DATA
> }
> EXCEPTION_TABLE(16)
> - JUMP_TABLE_DATA
> . = ALIGN(PAGE_SIZE);
> __end_ro_after_init = .;
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2018-10-01 20:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-30 16:49 [PATCH] s390: vmlinux.lds: move JUMP_TABLE_DATA into output section Ard Biesheuvel
2018-09-30 16:55 ` Kees Cook
2018-10-01 20:25 ` Heiko Carstens [this message]
2018-10-02 5:48 ` Ard Biesheuvel
2018-10-02 6:12 ` [tip:core/core] s390/vmlinux.lds: Move " tip-bot for Ard Biesheuvel
-- strict thread matches above, loose matches on Subject: below --
2018-09-30 17:08 [PATCH] s390: vmlinux.lds: move " Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181001202538.GB4958@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=jeyu@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.