From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: EDAC: Don't add devices under /sys/bus/edac From: "Luck, Tony" Message-Id: <20181001224313.GA9487@agluck-desk> Date: Mon, 1 Oct 2018 15:43:13 -0700 To: Borislav Petkov Cc: Mauro Carvalho Chehab , Russ Anderson , Greg KH , Justin Ernst , russ.anderson@hpe.com, Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Aristeu Rozanski Filho List-ID: Tm9ib2R5KCopIHVzZXMgdGhlbS4gIERyb3BwaW5nIHRoaXMgd2lsbCBhbGxvdyB1cyB0byBtYWtl IHRoZSB0b3RhbApudW1iZXIgb2YgbWVtb3J5IGNvbnRyb2xsZXJzIGNvbmZpZ3VyYWJsZSAoYXMg d2Ugd29uJ3QgaGF2ZSB0bwp3b3JyeSBhYm91dCBkdXBsaWNhdGVkIGRldmljZSBuYW1lcyB1bmRl ciB0aGlzIGRpcmVjdG9yeSkuCgooKikgaHR0cHM6Ly9tYXJjLmluZm8vP2w9bGludXgtZWRhYyZt PTE1MzgwOTcwOTkwMzk4NyZ3PTIKClNpZ25lZC1vZmYtYnk6IFRvbnkgTHVjayA8dG9ueS5sdWNr QGludGVsLmNvbT4KLS0tCgpCb3JpczogQXBwbHkgdGhpcywgdGhlbiB5b3VyIGVhcmxpZXIgcGF0 Y2ggdG8gZ2V0IHJpZCBvZiB0aGUKaGFyZCBjb2RlZCBsaW1pdCBvbiB0aGUgbnVtYmVyIG9mIG1l bW9yeSBjb250cm9sbGVyczoKICBodHRwczovL21hcmMuaW5mby8/bD1saW51eC1lZGFjJm09MTUz Nzk3NTY3NjI4OTQ3Jnc9Mgp0aGUgY29tYmluYXRpb24gd29ya3Mgb24gbXkgNCBzb2NrZXQgbWFj aGluZS4gUGVyaGFwcyBIUEUKY2FuIHRlc3Qgb24gdGhlaXIgc3VwZXJkb21lLgoKIGRyaXZlcnMv ZWRhYy9lZGFjX21jX3N5c2ZzLmMgfCAzIC0tLQogMSBmaWxlIGNoYW5nZWQsIDMgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9lZGFjL2VkYWNfbWNfc3lzZnMuYyBiL2RyaXZlcnMv ZWRhYy9lZGFjX21jX3N5c2ZzLmMKaW5kZXggMjAzNzRiODI0OGYwLi40YzFiZWU1OWMyZTYgMTAw NjQ0Ci0tLSBhL2RyaXZlcnMvZWRhYy9lZGFjX21jX3N5c2ZzLmMKKysrIGIvZHJpdmVycy9lZGFj L2VkYWNfbWNfc3lzZnMuYwpAQCAtNDA1LDcgKzQwNSw2IEBAIHN0YXRpYyBpbnQgZWRhY19jcmVh dGVfY3Nyb3dfb2JqZWN0KHN0cnVjdCBtZW1fY3RsX2luZm8gKm1jaSwKIAkJCQkgICAgc3RydWN0 IGNzcm93X2luZm8gKmNzcm93LCBpbnQgaW5kZXgpCiB7CiAJY3Nyb3ctPmRldi50eXBlID0gJmNz cm93X2F0dHJfdHlwZTsKLQljc3Jvdy0+ZGV2LmJ1cyA9IG1jaS0+YnVzOwogCWNzcm93LT5kZXYu Z3JvdXBzID0gY3Nyb3dfZGV2X2dyb3VwczsKIAlkZXZpY2VfaW5pdGlhbGl6ZSgmY3Nyb3ctPmRl dik7CiAJY3Nyb3ctPmRldi5wYXJlbnQgPSAmbWNpLT5kZXY7CkBAIC02MzYsNyArNjM1LDYgQEAg c3RhdGljIGludCBlZGFjX2NyZWF0ZV9kaW1tX29iamVjdChzdHJ1Y3QgbWVtX2N0bF9pbmZvICpt Y2ksCiAJZGltbS0+bWNpID0gbWNpOwogCiAJZGltbS0+ZGV2LnR5cGUgPSAmZGltbV9hdHRyX3R5 cGU7Ci0JZGltbS0+ZGV2LmJ1cyA9IG1jaS0+YnVzOwogCWRldmljZV9pbml0aWFsaXplKCZkaW1t LT5kZXYpOwogCiAJZGltbS0+ZGV2LnBhcmVudCA9ICZtY2ktPmRldjsKQEAgLTk0MCw3ICs5Mzgs NiBAQCBpbnQgZWRhY19jcmVhdGVfc3lzZnNfbWNpX2RldmljZShzdHJ1Y3QgbWVtX2N0bF9pbmZv ICptY2ksCiAJZGV2aWNlX2luaXRpYWxpemUoJm1jaS0+ZGV2KTsKIAogCW1jaS0+ZGV2LnBhcmVu dCA9IG1jaV9wZGV2OwotCW1jaS0+ZGV2LmJ1cyA9IG1jaS0+YnVzOwogCW1jaS0+ZGV2Lmdyb3Vw cyA9IGdyb3VwczsKIAlkZXZfc2V0X25hbWUoJm1jaS0+ZGV2LCAibWMlZCIsIG1jaS0+bWNfaWR4 KTsKIAlkZXZfc2V0X2RydmRhdGEoJm1jaS0+ZGV2LCBtY2kpOwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AF64C43143 for ; Mon, 1 Oct 2018 22:43:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E87372084C for ; Mon, 1 Oct 2018 22:43:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E87372084C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726618AbeJBFXR (ORCPT ); Tue, 2 Oct 2018 01:23:17 -0400 Received: from mga14.intel.com ([192.55.52.115]:2168 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725878AbeJBFXR (ORCPT ); Tue, 2 Oct 2018 01:23:17 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Oct 2018 15:43:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,329,1534834800"; d="scan'208";a="267577834" Received: from agluck-desk.sc.intel.com (HELO agluck-desk) ([10.3.52.160]) by fmsmga005.fm.intel.com with ESMTP; 01 Oct 2018 15:43:13 -0700 Date: Mon, 1 Oct 2018 15:43:13 -0700 From: "Luck, Tony" To: Borislav Petkov Cc: Mauro Carvalho Chehab , Russ Anderson , Greg KH , Justin Ernst , russ.anderson@hpe.com, Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Aristeu Rozanski Filho Subject: [PATCH] EDAC: Don't add devices under /sys/bus/edac Message-ID: <20181001224313.GA9487@agluck-desk> References: <20180926130340.6b22918b@coco.lan> <20180926161749.GI5584@zn.tnic> <20180926181035.GA1132@agluck-desk> <20180926182317.patqjso7nzw2oxiz@hpe.com> <20180926230257.GA5666@agluck-desk> <20180927045244.GA30912@zn.tnic> <20180927214400.GA2249@agluck-desk> <20180927220355.GF19687@zn.tnic> <20180927221054.580220e5@coco.lan> <20181001124754.GD7269@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181001124754.GD7269@zn.tnic> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nobody(*) uses them. Dropping this will allow us to make the total number of memory controllers configurable (as we won't have to worry about duplicated device names under this directory). (*) https://marc.info/?l=linux-edac&m=153809709903987&w=2 Signed-off-by: Tony Luck --- Boris: Apply this, then your earlier patch to get rid of the hard coded limit on the number of memory controllers: https://marc.info/?l=linux-edac&m=153797567628947&w=2 the combination works on my 4 socket machine. Perhaps HPE can test on their superdome. drivers/edac/edac_mc_sysfs.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c index 20374b8248f0..4c1bee59c2e6 100644 --- a/drivers/edac/edac_mc_sysfs.c +++ b/drivers/edac/edac_mc_sysfs.c @@ -405,7 +405,6 @@ static int edac_create_csrow_object(struct mem_ctl_info *mci, struct csrow_info *csrow, int index) { csrow->dev.type = &csrow_attr_type; - csrow->dev.bus = mci->bus; csrow->dev.groups = csrow_dev_groups; device_initialize(&csrow->dev); csrow->dev.parent = &mci->dev; @@ -636,7 +635,6 @@ static int edac_create_dimm_object(struct mem_ctl_info *mci, dimm->mci = mci; dimm->dev.type = &dimm_attr_type; - dimm->dev.bus = mci->bus; device_initialize(&dimm->dev); dimm->dev.parent = &mci->dev; @@ -940,7 +938,6 @@ int edac_create_sysfs_mci_device(struct mem_ctl_info *mci, device_initialize(&mci->dev); mci->dev.parent = mci_pdev; - mci->dev.bus = mci->bus; mci->dev.groups = groups; dev_set_name(&mci->dev, "mc%d", mci->mc_idx); dev_set_drvdata(&mci->dev, mci); -- 2.17.1