From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 2 Oct 2018 03:31:06 +0300 From: Jarkko Sakkinen To: Jethro Beekman CC: Dave Hansen , Andy Lutomirski , "Christopherson, Sean J" , Andrew Lutomirski , "X86 ML" , Platform Driver , "nhorman@redhat.com" , "npmccallum@redhat.com" , "Ayoun, Serge" , "shay.katz-zamir@intel.com" , "linux-sgx@vger.kernel.org" , Andy Shevchenko , Dave Hansen , Peter Zijlstra , "Thomas Gleixner" , Ingo Molnar , "Borislav Petkov" , "H. Peter Anvin" , LKML Subject: Re: [PATCH v14 09/19] x86/mm: x86/sgx: Signal SEGV_SGXERR for #PFs w/ PF_SGX Message-ID: <20181002003106.GC21814@linux.intel.com> References: <20180926173516.GA10920@linux.intel.com> <2D60780F-ADB4-48A4-AB74-15683493D369@amacapital.net> <9835e288-ba98-2f9e-ac73-504db9512bb9@intel.com> <20180926204400.GA11446@linux.intel.com> <992b1d6d-cc0f-776f-d938-2a1f7cad52c8@intel.com> <20180927135603.GF8242@linux.intel.com> Content-Type: text/plain; charset="us-ascii" In-Reply-To: Sender: Return-Path: platform-driver-x86-owner@vger.kernel.org MIME-Version: 1.0 List-ID: On Mon, Oct 01, 2018 at 09:42:48PM +0000, Jethro Beekman wrote: > 1) Even though the vDSO function exists, userspace may still call > `ENCLU[EENTER]` manually, so the fault handling as described in the current > patch should also be maintained. You mean the way it was is in v13 and not the way it is in v14? > 2) All the information that would normally be provided through the signal > handler (x86 fault number, reason) should be provided to userspace. As I've understood it, this should be just a change in the delivery path. /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH v14 09/19] x86/mm: x86/sgx: Signal SEGV_SGXERR for #PFs w/ PF_SGX Date: Tue, 2 Oct 2018 03:31:06 +0300 Message-ID: <20181002003106.GC21814@linux.intel.com> References: <20180926173516.GA10920@linux.intel.com> <2D60780F-ADB4-48A4-AB74-15683493D369@amacapital.net> <9835e288-ba98-2f9e-ac73-504db9512bb9@intel.com> <20180926204400.GA11446@linux.intel.com> <992b1d6d-cc0f-776f-d938-2a1f7cad52c8@intel.com> <20180927135603.GF8242@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Jethro Beekman Cc: Dave Hansen , Andy Lutomirski , "Christopherson, Sean J" , Andrew Lutomirski , X86 ML , Platform Driver , "nhorman@redhat.com" , "npmccallum@redhat.com" , "Ayoun, Serge" , "shay.katz-zamir@intel.com" , "linux-sgx@vger.kernel.org" , Andy Shevchenko , Dave Hansen , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" List-Id: platform-driver-x86.vger.kernel.org On Mon, Oct 01, 2018 at 09:42:48PM +0000, Jethro Beekman wrote: > 1) Even though the vDSO function exists, userspace may still call > `ENCLU[EENTER]` manually, so the fault handling as described in the current > patch should also be maintained. You mean the way it was is in v13 and not the way it is in v14? > 2) All the information that would normally be provided through the signal > handler (x86 fault number, reason) should be provided to userspace. As I've understood it, this should be just a change in the delivery path. /Jarkko