diff for duplicates of <20181002074837.GA26512@fergus> diff --git a/a/1.txt b/N1/1.txt index 86014c2..4188da1 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -229,7 +229,7 @@ OK. > > + long ref; > > + > > + spin_lock(&kvm->mmu_lock); -> > + if (gp = kvm->arch.nested_guests[lpid]) { +> > + if (gp == kvm->arch.nested_guests[lpid]) { > > This is to protect against a race with another remove, yes? Since kvm > and lpid are read before you take the lock. Is that right? @@ -239,7 +239,7 @@ and another CPU could have done kvmhv_remove_nested() in the meanwhile. > > + kvm->arch.nested_guests[lpid] = NULL; -> > + if (lpid = kvm->arch.max_nested_lpid) { +> > + if (lpid == kvm->arch.max_nested_lpid) { > > + while (--lpid >= 0 && !kvm->arch.nested_guests[lpid]) > > + ; > > + kvm->arch.max_nested_lpid = lpid; @@ -248,7 +248,7 @@ meanwhile. > > + } > > + ref = gp->refcnt; > > + spin_unlock(&kvm->mmu_lock); -> > + if (ref = 0) +> > + if (ref == 0) > > + kvmhv_release_nested(gp); > > +} > diff --git a/a/content_digest b/N1/content_digest index b687fe6..f77872d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\020181002060152.GI1886@umbus.fritz.box\0" "From\0Paul Mackerras <paulus@ozlabs.org>\0" "Subject\0Re: [PATCH v2 18/33] KVM: PPC: Book3S HV: Framework and hcall stubs for nested virtualization\0" - "Date\0Tue, 02 Oct 2018 07:48:37 +0000\0" + "Date\0Tue, 2 Oct 2018 17:48:37 +1000\0" "To\0David Gibson <david@gibson.dropbear.id.au>\0" "Cc\0linuxppc-dev@ozlabs.org" kvm-ppc@vger.kernel.org @@ -241,7 +241,7 @@ "> > +\tlong ref;\n" "> > +\n" "> > +\tspin_lock(&kvm->mmu_lock);\n" - "> > +\tif (gp = kvm->arch.nested_guests[lpid]) {\n" + "> > +\tif (gp == kvm->arch.nested_guests[lpid]) {\n" "> \n" "> This is to protect against a race with another remove, yes? Since kvm\n" "> and lpid are read before you take the lock. Is that right?\n" @@ -251,7 +251,7 @@ "meanwhile.\n" "\n" "> > +\t\tkvm->arch.nested_guests[lpid] = NULL;\n" - "> > +\t\tif (lpid = kvm->arch.max_nested_lpid) {\n" + "> > +\t\tif (lpid == kvm->arch.max_nested_lpid) {\n" "> > +\t\t\twhile (--lpid >= 0 && !kvm->arch.nested_guests[lpid])\n" "> > +\t\t\t\t;\n" "> > +\t\t\tkvm->arch.max_nested_lpid = lpid;\n" @@ -260,7 +260,7 @@ "> > +\t}\n" "> > +\tref = gp->refcnt;\n" "> > +\tspin_unlock(&kvm->mmu_lock);\n" - "> > +\tif (ref = 0)\n" + "> > +\tif (ref == 0)\n" "> > +\t\tkvmhv_release_nested(gp);\n" "> > +}\n" "> \n" @@ -301,4 +301,4 @@ "\n" Paul. -80732ce63bb64f594b71cba9c533a701c36cdbd2d18a06f9ff6bd2d5d4c1822e +a3482c92a735fcd2bb557c65d943f5be2ffac9d4daf6749db4e48cba1a70cf5e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.