From: Ingo Molnar <mingo@kernel.org>
To: Masayoshi Mizuma <msys.mizuma@gmail.com>
Cc: linux-mm@kvack.org, Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Pavel Tatashin <pavel.tatashin@microsoft.com>,
Michal Hocko <mhocko@kernel.org>,
Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH v2 1/3] Revert "x86/e820: put !E820_TYPE_RAM regions into memblock.reserved"
Date: Tue, 2 Oct 2018 11:39:40 +0200 [thread overview]
Message-ID: <20181002093940.GA98058@gmail.com> (raw)
In-Reply-To: <20180925153532.6206-2-msys.mizuma@gmail.com>
* Masayoshi Mizuma <msys.mizuma@gmail.com> wrote:
> From: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
>
> commit 124049decbb1 ("x86/e820: put !E820_TYPE_RAM regions into
> memblock.reserved") breaks movable_node kernel option because it
> changed the memory gap range to reserved memblock. So, the node
> is marked as Normal zone even if the SRAT has Hot plaggable affinity.
>
> =====================================================================
> kernel: BIOS-e820: [mem 0x0000180000000000-0x0000180fffffffff] usable
> kernel: BIOS-e820: [mem 0x00001c0000000000-0x00001c0fffffffff] usable
> ...
> kernel: reserved[0x12]#011[0x0000181000000000-0x00001bffffffffff], 0x000003f000000000 bytes flags: 0x0
> ...
> kernel: ACPI: SRAT: Node 2 PXM 6 [mem 0x180000000000-0x1bffffffffff] hotplug
> kernel: ACPI: SRAT: Node 3 PXM 7 [mem 0x1c0000000000-0x1fffffffffff] hotplug
> ...
> kernel: Movable zone start for each node
> kernel: Node 3: 0x00001c0000000000
> kernel: Early memory node ranges
> ...
> =====================================================================
>
> Naoya's v1 patch [*] fixes the original issue and this movable_node
> issue doesn't occur.
> Let's revert commit 124049decbb1 ("x86/e820: put !E820_TYPE_RAM
> regions into memblock.reserved") and apply the v1 patch.
>
> [*] https://lkml.org/lkml/2018/6/13/27
>
> Signed-off-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
> Reviewed-by: Pavel Tatashin <pavel.tatashin@microsoft.com>
> ---
> arch/x86/kernel/e820.c | 15 +++------------
> 1 file changed, 3 insertions(+), 12 deletions(-)
Bad ordering which introduces the bug and thus breaks bisection of related issues: the fixes
should come first, then the revert of the unnecessary or bad fix.
Thanks,
Ingo
next prev parent reply other threads:[~2018-10-02 9:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 15:35 [PATCH v2 0/3] mm: Fix for movable_node boot option Masayoshi Mizuma
2018-09-25 15:35 ` [PATCH v2 1/3] Revert "x86/e820: put !E820_TYPE_RAM regions into memblock.reserved" Masayoshi Mizuma
2018-10-02 9:39 ` Ingo Molnar [this message]
2018-10-02 13:51 ` Masayoshi Mizuma
2018-09-25 15:35 ` [PATCH v2 2/3] mm: zero remaining unavailable struct pages Masayoshi Mizuma
2018-09-25 15:35 ` [PATCH v2 3/3] mm: return zero_resv_unavail optimization Masayoshi Mizuma
2018-09-28 0:19 ` Naoya Horiguchi
2018-09-28 15:36 ` Masayoshi Mizuma
2018-09-27 20:41 ` [PATCH v2 0/3] mm: Fix for movable_node boot option Thomas Gleixner
2018-10-02 14:01 ` Michal Hocko
2018-10-05 18:57 ` Pavel Tatashin
2018-10-05 19:02 ` Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181002093940.GA98058@gmail.com \
--to=mingo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.mizuma@jp.fujitsu.com \
--cc=mhocko@kernel.org \
--cc=msys.mizuma@gmail.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=pavel.tatashin@microsoft.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.