From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH ethtool v2] ethtool: Fix uninitialized variable use at
 qsfp dump
Date: Tue, 2 Oct 2018 14:50:57 +0200
Message-ID: <20181002125057.GE9155@lunn.ch>
References: <1538465059-24645-1-git-send-email-eranbe@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org,
        "John W. Linville" <linville@tuxdriver.com>,
        Chris Preimesberger <chrisp@transition.com>,
        Neil Horman <nhorman@tuxdriver.com>,
        Vidya Sagar Ravipati <vidya@cumulusnetworks.com>
To: Eran Ben Elisha <eranbe@mellanox.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:51959 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727528AbeJBTeO (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 2 Oct 2018 15:34:14 -0400
Content-Disposition: inline
In-Reply-To: <1538465059-24645-1-git-send-email-eranbe@mellanox.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, Oct 02, 2018 at 10:24:19AM +0300, Eran Ben Elisha wrote:
> Struct sff_diags can be used uninitialized at sff8636_show_dom, this
> caused the tool to show unreported fields (supports_alarms) by the lower
> level driver.
> 
> In addition, make sure the same struct is being initialized at
> sff8472_parse_eeprom function, to avoid the same issue here.
> 
> Fixes: a5e73bb05ee4 ("ethtool:QSFP Plus/QSFP28 Diagnostics Information Support")
> Signed-off-by: Eran Ben Elisha <eranbe@mellanox.com>

Hi Eran

Thanks for fixing both cases.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew