All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Mamta Shukla <mamtashukla555@gmail.com>,
	outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: rts5208: Replace udelay() with usleep_range()
Date: Tue, 2 Oct 2018 06:13:06 -0700	[thread overview]
Message-ID: <20181002131306.GA32586@kroah.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1810021505480.3460@hadrien>

On Tue, Oct 02, 2018 at 03:07:14PM +0200, Julia Lawall wrote:
> 
> 
> On Tue, 2 Oct 2018, Mamta Shukla wrote:
> 
> >     udelay(unsigned long usec) replaced with usleep_range(unsigned long
> >     min, unsigned long max) to prevent trigger by interrupt in specified
> >     duration.Also provides better scheduling,power management for drivers.
> 
> Thanks for the patch.  A few picky comments.  In English, it is more
> readable to put some space after punctuation.  It is also not necessary to
> indent the log message.
> 
> Also, it would be good to explain how you chose the upper limit.

It is _required_ to explain this.  This change comes up every so often,
and I keep rejecting it as no one knows what value to put here that will
correctly work.  So I recommend just leaving it alone unless you hav the
hardware and can test this type of change properly.

thanks,

greg k-h


  reply	other threads:[~2018-10-02 13:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-02 13:01 [PATCH] staging: rts5208: Replace udelay() with usleep_range() Mamta Shukla
2018-10-02 13:07 ` [Outreachy kernel] " Julia Lawall
2018-10-02 13:13   ` Greg KH [this message]
2018-10-02 14:54     ` Mamta Shukla
2018-10-02 16:36       ` Greg KH
2018-10-02 20:10       ` Himanshu Jha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181002131306.GA32586@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=julia.lawall@lip6.fr \
    --cc=mamtashukla555@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.