From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 03/10] drm/i915: Do not get aux power for disconnected DP ports Date: Tue, 2 Oct 2018 23:49:06 +0300 Message-ID: <20181002204906.GI9144@intel.com> References: <20181002175054.15010-1-jose.souza@intel.com> <20181002175054.15010-3-jose.souza@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id B7F108961D for ; Tue, 2 Oct 2018 20:50:09 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181002175054.15010-3-jose.souza@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?iso-8859-1?Q?Jos=E9?= Roberto de Souza Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBPY3QgMDIsIDIwMTggYXQgMTA6NTA6NDdBTSAtMDcwMCwgSm9zw6kgUm9iZXJ0byBk ZSBTb3V6YSB3cm90ZToKPiBGb3IgSUNMIHR5cGUtYyBwb3J0cyB0aGVyZSBpcyBhIGF1eCBwb3dl ciByZXN0cmljdGlvbiwgaXQgY2FuIG9ubHkgYmUKPiBlbmFibGVkIHdoaWxlIHRoZXJlIGlzIHNp bmsgY29ubmVjdGVkLgo+IAo+IEJTcGVjOiAyMTc1MAo+IAo+IHYyOgo+IC0gcmViYXNlZCBvbiB0 b3Agb2YgdGhlIHJlZmFjdG9yZWQgdmVyc2lvbiBvZiBpbnRlbF9kcF9kZXRlY3QoKQo+IC0gZml4 aW5nIENJIGVycm9ycyBieSBnZXR0aW5nIHJ1bnRpbWVfcG0oKSwgZm9yIFZMVi9DSFYgaXQgaXMg YWxzbwo+IG5lY2Vzc2FyeSBnZXQgdGhlIERQSU8gcG93ZXIgd2VsbCByZWZlcmVuY2UKPiAKPiBD YzogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGxpbnV4LmludGVsLmNvbT4KPiBDYzogVmlsbGUg U3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBDYzogSW1yZSBEZWFr IDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEpvc8OpIFJvYmVydG8gZGUg U291emEgPGpvc2Uuc291emFAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kcC5jIHwgMzIgKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0KPiAgMSBm aWxlIGNoYW5nZWQsIDI4IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcC5jCj4gaW5kZXggNWE4NGE5MjliYzdkLi4yY2QyZGM1NjQxODEgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBAQCAtNDk5NiwxMCArNDk5NiwyOCBAQCBib29sIGlu dGVsX2RpZ2l0YWxfcG9ydF9jb25uZWN0ZWQoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIp Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGVuY29kZXIt PmJhc2UuZGV2KTsKPiAgCj4gIAlpZiAoSEFTX0dNQ0hfRElTUExBWShkZXZfcHJpdikpIHsKPiAr CQllbnVtIGludGVsX2Rpc3BsYXlfcG93ZXJfZG9tYWluIGRvbWFpbiA9IDA7Cj4gKwkJYm9vbCBy ZXQ7Cj4gKwo+ICsJCS8qCj4gKwkJICogT2RkbHkgVkxWL0NIViBuZWVkcyB0aGUgRFBJTyBwb3dl ciB3ZWxsIG9uIHRvIGJlIGFibGUgdG8KPiArCQkgKiByZWFkIHRoZSBob3RwbHVnIHN0YXR1cywg b3RoZXJ3aXNlIGl0IHdpbGwgcmVhZCBhIGJvZ3VzIHZhbHVlCj4gKwkJICogYW5kIHRocm93IGEg dW5jbGFpbWVkIHJlZ2lzdGVyIHdhcm5pbmcKPiArCQkgKi8KPiArCQlpZiAoSVNfVkFMTEVZVklF VyhkZXZfcHJpdikgfHwgSVNfQ0hFUlJZVklFVyhkZXZfcHJpdikpIHsKPiArCQkJZG9tYWluID0g aW50ZWxfcG9ydF90b19wb3dlcl9kb21haW4oZW5jb2Rlci0+cG9ydCk7Cj4gKwkJCWludGVsX2Rp c3BsYXlfcG93ZXJfZ2V0KGRldl9wcml2LCBkb21haW4pOwo+ICsJCX0KPiArCj4gIAkJaWYgKElT X0dNNDUoZGV2X3ByaXYpKQo+IC0JCQlyZXR1cm4gZ200NV9kaWdpdGFsX3BvcnRfY29ubmVjdGVk KGVuY29kZXIpOwo+ICsJCQlyZXQgPSBnbTQ1X2RpZ2l0YWxfcG9ydF9jb25uZWN0ZWQoZW5jb2Rl cik7Cj4gIAkJZWxzZQo+IC0JCQlyZXR1cm4gZzR4X2RpZ2l0YWxfcG9ydF9jb25uZWN0ZWQoZW5j b2Rlcik7Cj4gKwkJCXJldCA9IGc0eF9kaWdpdGFsX3BvcnRfY29ubmVjdGVkKGVuY29kZXIpOwo+ ICsKPiArCQlpZiAoSVNfVkFMTEVZVklFVyhkZXZfcHJpdikgfHwgSVNfQ0hFUlJZVklFVyhkZXZf cHJpdikpCj4gKwkJCWludGVsX2Rpc3BsYXlfcG93ZXJfcHV0KGRldl9wcml2LCBkb21haW4pOwo+ ICsKPiArCQlyZXR1cm4gcmV0Owo+ICAJfQo+ICAKPiAgCWlmIChJU19HRU41KGRldl9wcml2KSkK PiBAQCAtNTA3NSw3ICs1MDkzLDcgQEAgaW50ZWxfZHBfZGV0ZWN0KHN0cnVjdCBkcm1fY29ubmVj dG9yICpjb25uZWN0b3IsCj4gIAkJICAgICAgY29ubmVjdG9yLT5iYXNlLmlkLCBjb25uZWN0b3It Pm5hbWUpOwo+ICAJV0FSTl9PTighZHJtX21vZGVzZXRfaXNfbG9ja2VkKCZkZXZfcHJpdi0+ZHJt Lm1vZGVfY29uZmlnLmNvbm5lY3Rpb25fbXV0ZXgpKTsKPiAgCj4gLQlpbnRlbF9kaXNwbGF5X3Bv d2VyX2dldChkZXZfcHJpdiwgaW50ZWxfZHAtPmF1eF9wb3dlcl9kb21haW4pOwo+ICsJaW50ZWxf cnVudGltZV9wbV9nZXQoZGV2X3ByaXYpOwoKSSBzdGlsbCBtYWludGFpbiB0aGF0IGl0IGNhbid0 IGJlIHRoZSAiaXMgdGhlcmUgYSBzaW5rIG9yIG5vdD8iIHRoaW5nCnRoYXQgbWFrZXMgdGhpcyBm YWlsLiBUaGUgb25seSB0aGluZyB0aGF0IG1ha2VzIHNlbnNlIHRvIG1lIGlzIHRoZQpwb3J0IHRi dCB2cy4gdGMgKG9yIHdoYXRldmVyIGl0IHdhcykga25vYi4gT3RoZXJ3aXNlIHdlIGNhbiByYWNl CndpdGggZGlzcGxheSBob3RwbHVnIGFsbCBkYXkgbG9uZy4KCkFsc28gdGhpcyBpcyBoYXJkbHkg dGhlIG9ubHkgcGxhY2Ugd2hlcmUgd2UgZ3JhYiB0aGUgcG93ZXIgcmVmZXJlbmNlCnNvIHdlJ2Qg bmVlZCB0aGUgZHVjdCB0YXBlIGFwcGxpZWQgcXVpdGUgYSBiaXQgbW9yZSBsaWJlcmFsbHkgaWYg d2UKd2FudGVkIGl0IHRvIHdvcmsuCgpTbyB0aGVyZSBzZWVtcyB0byBiZSBhIGZ1bmRlbWVudGFs IHByb2JsZW0gd2l0aCB0aGUgd2hvbGUgdGJ0IHZzLiB0Ywptb2RlIHRoaW5nIGluIHRoZSBjdXJy ZW50IGNvZGUuIFdlIHNob3VsZCBmaXggdGhhdCBiZWZvcmUgd2UgYWRkCnBpbGVzIG9mIGR1Y3Qg dGFwZToKLSBjb3JyZWN0bHkgdHJhY2sgd2hpY2ggbW9kZSB0aGUgcG9ydCBpcyB1c2VkIGluCi0g cHJvYmFibHkgc3BsaXQgdGhlIGNvbm5lY3RvciBpbnRvIHRidCB2cy4gdGMgdmFyaWFudHMgKHRv IG1ha2UgaXQKICBjbGVhciB3aGljaCBtb2RlIGlzIGJlaW5nIHVzZWQpCi0gbWFrZSBzdXJlIGl0 IHN0YXlzIGluIHRoYXQgbW9kZSB1bnRpbCBjdXJyZW50IHVzZXJzIGFyZSBkb25lCi0gYmxvY2sv cmVqZWN0IG90aGVyIHVzZXMgb2YgdGhlIHBvcnQgd2hpbGUgaXQncyBpbiB0aGUgd3JvbmcgbW9k ZQotIGRvIHRoZSBhcHByb3JpYXRlIGZsb3dzIHdoZW4gYWNxdWlyaW5nL3JlcWxpbmd1aXNoaW5n IGNvbnRyb2wKICBvZiB0aGUgcG9ydAotIHRlc3QgdGhlIGhlY2sgb3V0IG9mIGl0IHdpdGggZWcu IGdlbmNvbm5lY3RvciwgZm9yY2VkIGNvbm5jdG9yCiAgc3RhdHVzLCAvZGV2L2F1eCB0aGluZywg aTJjLCBldGMuCgo+ICAKPiAgCS8qIElzIHBvcnQgY29ubmVjdGVkPyBlRFAgY2FuJ3QgYmUgZGlz Y29ubmVjdGVkICovCj4gIAlpZiAoIWludGVsX2RwX2lzX2VkcChpbnRlbF9kcCkgJiYKPiBAQCAt NTA4NCw2ICs1MTAyLDggQEAgaW50ZWxfZHBfZGV0ZWN0KHN0cnVjdCBkcm1fY29ubmVjdG9yICpj b25uZWN0b3IsCj4gIAkJZ290byBwb3J0X2Rpc2Nvbm5lY3RlZDsKPiAgCX0KPiAgCj4gKwlpbnRl bF9kaXNwbGF5X3Bvd2VyX2dldChkZXZfcHJpdiwgaW50ZWxfZHAtPmF1eF9wb3dlcl9kb21haW4p Owo+ICsKPiAgCWlmIChpbnRlbF9kcF9pc19lZHAoaW50ZWxfZHApKQo+ICAJCXN0YXR1cyA9IGVk cF9kZXRlY3QoaW50ZWxfZHApOwo+ICAJZWxzZQo+IEBAIC01MTE2LDYgKzUxMzYsNyBAQCBpbnRl bF9kcF9kZXRlY3Qoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiAgCQkgKiB3aXRo IEVESUQgb24gaXQKPiAgCQkgKi8KPiAgCQlpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1dChkZXZfcHJp diwgaW50ZWxfZHAtPmF1eF9wb3dlcl9kb21haW4pOwo+ICsJCWludGVsX3J1bnRpbWVfcG1fcHV0 KGRldl9wcml2KTsKPiAgCQlyZXR1cm4gY29ubmVjdG9yX3N0YXR1c19kaXNjb25uZWN0ZWQ7Cj4g IAl9Cj4gIAo+IEBAIC01MTMwLDYgKzUxNTEsNyBAQCBpbnRlbF9kcF9kZXRlY3Qoc3RydWN0IGRy bV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiAgCQlpZiAocmV0KSB7Cj4gIAkJCWludGVsX2Rpc3Bs YXlfcG93ZXJfcHV0KGRldl9wcml2LAo+ICAJCQkJCQlpbnRlbF9kcC0+YXV4X3Bvd2VyX2RvbWFp bik7Cj4gKwkJCWludGVsX3J1bnRpbWVfcG1fcHV0KGRldl9wcml2KTsKPiAgCQkJcmV0dXJuIHJl dDsKPiAgCQl9Cj4gIAl9Cj4gQEAgLTUxNTMsOSArNTE3NSwxMSBAQCBpbnRlbF9kcF9kZXRlY3Qo c3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiAgCWludGVsX2RwX2NoZWNrX3NlcnZp Y2VfaXJxKGludGVsX2RwKTsKPiAgCj4gIAlpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1dChkZXZfcHJp diwgaW50ZWxfZHAtPmF1eF9wb3dlcl9kb21haW4pOwo+ICsJaW50ZWxfcnVudGltZV9wbV9wdXQo ZGV2X3ByaXYpOwo+ICAJcmV0dXJuIHN0YXR1czsKPiAgCj4gIHBvcnRfbm90X2RldGVjdGVkOgo+ ICsJaW50ZWxfZGlzcGxheV9wb3dlcl9wdXQoZGV2X3ByaXYsIGludGVsX2RwLT5hdXhfcG93ZXJf ZG9tYWluKTsKPiAgcG9ydF9kaXNjb25uZWN0ZWQ6Cj4gIAltZW1zZXQoJmludGVsX2RwLT5jb21w bGlhbmNlLCAwLCBzaXplb2YoaW50ZWxfZHAtPmNvbXBsaWFuY2UpKTsKPiAgCj4gQEAgLTUxNjgs NyArNTE5Miw3IEBAIGludGVsX2RwX2RldGVjdChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVj dG9yLAo+ICAJfSBlbHNlCj4gIAkJaW50ZWxfZHBfdW5zZXRfZWRpZChpbnRlbF9kcCk7Cj4gIAo+ IC0JaW50ZWxfZGlzcGxheV9wb3dlcl9wdXQoZGV2X3ByaXYsIGludGVsX2RwLT5hdXhfcG93ZXJf ZG9tYWluKTsKPiArCWludGVsX3J1bnRpbWVfcG1fcHV0KGRldl9wcml2KTsKPiAgCXJldHVybiBz dGF0dXM7Cj4gIH0KPiAgCj4gLS0gCj4gMi4xOS4wCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVs Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=