From: Lance Roy <ldr709@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: "Paul E. McKenney" <paulmck@linux.ibm.com>, Lance Roy <ldr709@gmail.com>
Subject: Using lockdep instead of spin_is_locked()
Date: Tue, 2 Oct 2018 22:38:46 -0700 [thread overview]
Message-ID: <20181003053902.6910-1-ldr709@gmail.com> (raw)
One of the main uses of spin_is_locked() is to require that a lock is held when
a function is called, for debugging, but lockdep_assert_held() is better for
this purpose since it won't make a mistake when someone else is holding the
lock. This patch series replaces all of this kind of use of spin_is_locked()
with calls to lockdep_assert_held(). An ulterior motive is to reduce the number
of uses of spin_is_locked() from the kernel, to work towards possibly
eliminating it.
Thanks,
Lance
arch/x86/pci/i386.c | 2 +-
drivers/hv/hv_balloon.c | 2 +-
drivers/misc/sgi-xp/xpc_channel.c | 6 +++---
drivers/misc/sgi-xp/xpc_sn2.c | 2 +-
drivers/misc/sgi-xp/xpc_uv.c | 2 +-
drivers/net/ethernet/intel/i40e/i40e_main.c | 3 +--
drivers/net/ethernet/intel/igbvf/mbx.c | 4 ++--
drivers/net/ethernet/sfc/efx.c | 2 +-
drivers/net/ethernet/smsc/smsc911x.h | 2 +-
drivers/net/wireless/zydas/zd1211rw/zd_mac.c | 2 +-
drivers/scsi/snic/snic_scsi.c | 4 ++--
fs/userfaultfd.c | 2 +-
kernel/futex.c | 4 ++--
kernel/locking/mutex-debug.c | 4 ++--
mm/khugepaged.c | 4 ++--
mm/swap.c | 3 +--
net/netfilter/ipset/ip_set_hash_gen.h | 2 +-
security/apparmor/file.c | 2 +-
virt/kvm/arm/vgic/vgic.c | 12 ++++++------
19 files changed, 31 insertions(+), 33 deletions(-)
next reply other threads:[~2018-10-03 5:39 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 5:38 Lance Roy [this message]
2018-10-03 5:38 ` [PATCH 01/16] x86/PCI: Replace spin_is_locked() with lockdep Lance Roy
2018-10-03 16:00 ` Bjorn Helgaas
2018-10-04 6:50 ` Lance Roy
2018-10-03 5:38 ` [PATCH 02/16] hv_balloon: " Lance Roy
2018-10-03 13:20 ` Vitaly Kuznetsov
2018-10-03 5:38 ` [PATCH 03/16] sgi-xp: " Lance Roy
2018-10-03 5:38 ` [Intel-wired-lan] [PATCH 04/16] i40e: " Lance Roy
2018-10-03 5:38 ` Lance Roy
2018-10-04 18:24 ` [Intel-wired-lan] " Bowers, AndrewX
2018-10-04 18:56 ` Bowers, AndrewX
2018-10-03 5:38 ` [Intel-wired-lan] [PATCH 05/16] igbvf: " Lance Roy
2018-10-03 5:38 ` Lance Roy
2018-10-13 0:11 ` [Intel-wired-lan] " Brown, Aaron F
2018-10-13 0:11 ` Brown, Aaron F
2018-10-03 5:38 ` [PATCH 06/16] sfc: " Lance Roy
2018-10-03 5:38 ` [PATCH 07/16] smsc: " Lance Roy
2018-10-03 5:38 ` [PATCH 08/16] wireless: " Lance Roy
2018-10-03 9:06 ` Kalle Valo
2018-10-04 6:57 ` Lance Roy
2018-10-04 10:05 ` Kalle Valo
2018-10-05 8:35 ` [PATCH 08/16] zd1211rw: " Kalle Valo
2018-10-03 5:38 ` [PATCH 09/16] scsi: " Lance Roy
2018-10-03 13:53 ` Bart Van Assche
2018-10-11 2:37 ` Martin K. Petersen
2018-10-03 5:38 ` [PATCH 10/16] userfaultfd: " Lance Roy
2018-10-03 5:38 ` [PATCH 11/16] futex: " Lance Roy
2018-10-09 11:21 ` [tip:locking/core] " tip-bot for Lance Roy
2018-10-03 5:38 ` [PATCH 12/16] locking/mutex: " Lance Roy
2018-10-09 12:18 ` Will Deacon
2018-10-09 13:36 ` Paul E. McKenney
2018-10-03 5:38 ` [PATCH 13/16] mm: " Lance Roy
2018-10-03 7:37 ` Vlastimil Babka
2018-10-03 5:39 ` [PATCH 14/16] netfilter: " Lance Roy
2018-10-03 8:29 ` Jozsef Kadlecsik
2018-10-03 5:39 ` [PATCH 15/16] apparmor: " Lance Roy
2018-10-03 5:56 ` John Johansen
2018-10-03 5:39 ` [PATCH 16/16] KVM: arm/arm64: vgic: " Lance Roy
2018-10-03 5:39 ` Lance Roy
2018-11-02 18:45 ` Christoffer Dall
2018-11-02 18:45 ` Christoffer Dall
2018-11-02 19:42 ` Paul E. McKenney
2018-11-02 19:42 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181003053902.6910-1-ldr709@gmail.com \
--to=ldr709@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.