From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 03/13] drm/i915: Make
 intel_set_pipe_timings/src_size take a pointer to crtc_state
Date: Wed, 3 Oct 2018 17:01:34 +0300
Message-ID: <20181003140134.GV9144@intel.com>
References: <20181003133715.3713-1-maarten.lankhorst@linux.intel.com>
 <20181003133715.3713-4-maarten.lankhorst@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by gabe.freedesktop.org (Postfix) with ESMTPS id A392289B78
 for <intel-gfx@lists.freedesktop.org>; Wed,  3 Oct 2018 14:03:20 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20181003133715.3713-4-maarten.lankhorst@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCBPY3QgMDMsIDIwMTggYXQgMDM6Mzc6MDVQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y
c3Qgd3JvdGU6Cj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFu
a2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfZGlzcGxheS5jIHwgNDEgKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUg
Y2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwgMjEgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp
dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IDcwMWNhYWI0ZTM4Mi4uY2E1ZTRkNzJkNDc2
IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsr
KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC0xNDIsOCArMTQy
LDggQEAgc3RhdGljIGludCBpbnRlbF9mcmFtZWJ1ZmZlcl9pbml0KHN0cnVjdCBpbnRlbF9mcmFt
ZWJ1ZmZlciAqaWZiLAo+ICAJCQkJICBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqLAo+
ICAJCQkJICBzdHJ1Y3QgZHJtX21vZGVfZmJfY21kMiAqbW9kZV9jbWQpOwo+ICBzdGF0aWMgdm9p
ZCBpOXh4X3NldF9waXBlY29uZihzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSk7
Cj4gLXN0YXRpYyB2b2lkIGludGVsX3NldF9waXBlX3RpbWluZ3Moc3RydWN0IGludGVsX2NydGMg
KmludGVsX2NydGMpOwo+IC1zdGF0aWMgdm9pZCBpbnRlbF9zZXRfcGlwZV9zcmNfc2l6ZShzdHJ1
Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0Yyk7Cj4gK3N0YXRpYyB2b2lkIGludGVsX3NldF9waXBl
X3RpbWluZ3MoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpOwo+ICtz
dGF0aWMgdm9pZCBpbnRlbF9zZXRfcGlwZV9zcmNfc2l6ZShjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0
Y19zdGF0ZSAqY3J0Y19zdGF0ZSk7Cj4gIHN0YXRpYyB2b2lkIGludGVsX2NwdV90cmFuc2NvZGVy
X3NldF9tX24oc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gIAkJCQkJIHN0cnVjdCBpbnRlbF9s
aW5rX21fbiAqbV9uLAo+ICAJCQkJCSBzdHJ1Y3QgaW50ZWxfbGlua19tX24gKm0yX24yKTsKPiBA
QCAtNTU5Niw4ICs1NTk2LDggQEAgc3RhdGljIHZvaWQgaXJvbmxha2VfY3J0Y19lbmFibGUoc3Ry
dWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnLAo+ICAJaWYgKGludGVsX2NydGNfaGFz
X2RwX2VuY29kZXIoaW50ZWxfY3J0Yy0+Y29uZmlnKSkKPiAgCQlpbnRlbF9kcF9zZXRfbV9uKGlu
dGVsX2NydGMsIE0xX04xKTsKPiAgCj4gLQlpbnRlbF9zZXRfcGlwZV90aW1pbmdzKGludGVsX2Ny
dGMpOwo+IC0JaW50ZWxfc2V0X3BpcGVfc3JjX3NpemUoaW50ZWxfY3J0Yyk7Cj4gKwlpbnRlbF9z
ZXRfcGlwZV90aW1pbmdzKHBpcGVfY29uZmlnKTsKPiArCWludGVsX3NldF9waXBlX3NyY19zaXpl
KHBpcGVfY29uZmlnKTsKPiAgCj4gIAlpZiAoaW50ZWxfY3J0Yy0+Y29uZmlnLT5oYXNfcGNoX2Vu
Y29kZXIpIHsKPiAgCQlpbnRlbF9jcHVfdHJhbnNjb2Rlcl9zZXRfbV9uKGludGVsX2NydGMsCj4g
QEAgLTU3MjEsOSArNTcyMSw5IEBAIHN0YXRpYyB2b2lkIGhhc3dlbGxfY3J0Y19lbmFibGUoc3Ry
dWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnLAo+ICAJCWludGVsX2RwX3NldF9tX24o
aW50ZWxfY3J0YywgTTFfTjEpOwo+ICAKPiAgCWlmICghdHJhbnNjb2Rlcl9pc19kc2koY3B1X3Ry
YW5zY29kZXIpKQo+IC0JCWludGVsX3NldF9waXBlX3RpbWluZ3MoaW50ZWxfY3J0Yyk7Cj4gKwkJ
aW50ZWxfc2V0X3BpcGVfdGltaW5ncyhwaXBlX2NvbmZpZyk7Cj4gIAo+IC0JaW50ZWxfc2V0X3Bp
cGVfc3JjX3NpemUoaW50ZWxfY3J0Yyk7Cj4gKwlpbnRlbF9zZXRfcGlwZV9zcmNfc2l6ZShwaXBl
X2NvbmZpZyk7Cj4gIAo+ICAJaWYgKGNwdV90cmFuc2NvZGVyICE9IFRSQU5TQ09ERVJfRURQICYm
Cj4gIAkgICAgIXRyYW5zY29kZXJfaXNfZHNpKGNwdV90cmFuc2NvZGVyKSkgewo+IEBAIC02MDYy
LDEyICs2MDYyLDEwIEBAIHN0YXRpYyB2b2lkIHZhbGxleXZpZXdfY3J0Y19lbmFibGUoc3RydWN0
IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnLAo+ICAJaWYgKGludGVsX2NydGNfaGFzX2Rw
X2VuY29kZXIoaW50ZWxfY3J0Yy0+Y29uZmlnKSkKPiAgCQlpbnRlbF9kcF9zZXRfbV9uKGludGVs
X2NydGMsIE0xX04xKTsKPiAgCj4gLQlpbnRlbF9zZXRfcGlwZV90aW1pbmdzKGludGVsX2NydGMp
Owo+IC0JaW50ZWxfc2V0X3BpcGVfc3JjX3NpemUoaW50ZWxfY3J0Yyk7Cj4gKwlpbnRlbF9zZXRf
cGlwZV90aW1pbmdzKHBpcGVfY29uZmlnKTsKPiArCWludGVsX3NldF9waXBlX3NyY19zaXplKHBp
cGVfY29uZmlnKTsKPiAgCj4gIAlpZiAoSVNfQ0hFUlJZVklFVyhkZXZfcHJpdikgJiYgcGlwZSA9
PSBQSVBFX0IpIHsKPiAtCQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19p
OTE1KGRldik7Cj4gLQo+ICAJCUk5MTVfV1JJVEUoQ0hWX0JMRU5EKHBpcGUpLCBDSFZfQkxFTkRf
TEVHQUNZKTsKPiAgCQlJOTE1X1dSSVRFKENIVl9DQU5WQVMocGlwZSksIDApOwo+ICAJfQo+IEBA
IC02MTM0LDggKzYxMzIsOCBAQCBzdGF0aWMgdm9pZCBpOXh4X2NydGNfZW5hYmxlKHN0cnVjdCBp
bnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZywKPiAgCWlmIChpbnRlbF9jcnRjX2hhc19kcF9l
bmNvZGVyKGludGVsX2NydGMtPmNvbmZpZykpCj4gIAkJaW50ZWxfZHBfc2V0X21fbihpbnRlbF9j
cnRjLCBNMV9OMSk7Cj4gIAo+IC0JaW50ZWxfc2V0X3BpcGVfdGltaW5ncyhpbnRlbF9jcnRjKTsK
PiAtCWludGVsX3NldF9waXBlX3NyY19zaXplKGludGVsX2NydGMpOwo+ICsJaW50ZWxfc2V0X3Bp
cGVfdGltaW5ncyhwaXBlX2NvbmZpZyk7Cj4gKwlpbnRlbF9zZXRfcGlwZV9zcmNfc2l6ZShwaXBl
X2NvbmZpZyk7Cj4gIAo+ICAJaTl4eF9zZXRfcGlwZWNvbmYocGlwZV9jb25maWcpOwo+ICAKPiBA
QCAtNzMzMSwxMiArNzMyOSwxMyBAQCBzdGF0aWMgdm9pZCBpOHh4X2NvbXB1dGVfZHBsbChzdHJ1
Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiAgCWNydGNfc3RhdGUtPmRwbGxfaHdfc3RhdGUuZHBsbCA9
IGRwbGw7Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkIGludGVsX3NldF9waXBlX3RpbWluZ3Moc3Ry
dWN0IGludGVsX2NydGMgKmludGVsX2NydGMpCj4gK3N0YXRpYyB2b2lkIGludGVsX3NldF9waXBl
X3RpbWluZ3MoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gIHsK
PiArCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjID0gdG9faW50ZWxfY3J0YyhjcnRjX3N0
YXRlLT5iYXNlLmNydGMpOwoKTW9yZSBlYXN5IHMvaW50ZWxfY3J0Yy9jcnRjLyBjYW5kaWRhdGVz
IGluIHRoaXMgcGF0Y2guCgpBbmQgbWlzc2luZyBhIGNvbW1pdCBtZXNzYWdlLiBPdGhlcndpc2Ug
bGd0bQpSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4Lmlu
dGVsLmNvbT4KCj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1
KGludGVsX2NydGMtPmJhc2UuZGV2KTsKPiAgCWVudW0gcGlwZSBwaXBlID0gaW50ZWxfY3J0Yy0+
cGlwZTsKPiAtCWVudW0gdHJhbnNjb2RlciBjcHVfdHJhbnNjb2RlciA9IGludGVsX2NydGMtPmNv
bmZpZy0+Y3B1X3RyYW5zY29kZXI7Cj4gLQljb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAq
YWRqdXN0ZWRfbW9kZSA9ICZpbnRlbF9jcnRjLT5jb25maWctPmJhc2UuYWRqdXN0ZWRfbW9kZTsK
PiArCWVudW0gdHJhbnNjb2RlciBjcHVfdHJhbnNjb2RlciA9IGNydGNfc3RhdGUtPmNwdV90cmFu
c2NvZGVyOwo+ICsJY29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKmFkanVzdGVkX21vZGUg
PSAmY3J0Y19zdGF0ZS0+YmFzZS5hZGp1c3RlZF9tb2RlOwo+ICAJdWludDMyX3QgY3J0Y192dG90
YWwsIGNydGNfdmJsYW5rX2VuZDsKPiAgCWludCB2c3luY3NoaWZ0ID0gMDsKPiAgCj4gQEAgLTcz
NTAsNyArNzM0OSw3IEBAIHN0YXRpYyB2b2lkIGludGVsX3NldF9waXBlX3RpbWluZ3Moc3RydWN0
IGludGVsX2NydGMgKmludGVsX2NydGMpCj4gIAkJY3J0Y192dG90YWwgLT0gMTsKPiAgCQljcnRj
X3ZibGFua19lbmQgLT0gMTsKPiAgCj4gLQkJaWYgKGludGVsX2NydGNfaGFzX3R5cGUoaW50ZWxf
Y3J0Yy0+Y29uZmlnLCBJTlRFTF9PVVRQVVRfU0RWTykpCj4gKwkJaWYgKGludGVsX2NydGNfaGFz
X3R5cGUoY3J0Y19zdGF0ZSwgSU5URUxfT1VUUFVUX1NEVk8pKQo+ICAJCQl2c3luY3NoaWZ0ID0g
KGFkanVzdGVkX21vZGUtPmNydGNfaHRvdGFsIC0gMSkgLyAyOwo+ICAJCWVsc2UKPiAgCQkJdnN5
bmNzaGlmdCA9IGFkanVzdGVkX21vZGUtPmNydGNfaHN5bmNfc3RhcnQgLQo+IEBAIC03MzkyLDE4
ICs3MzkxLDE4IEBAIHN0YXRpYyB2b2lkIGludGVsX3NldF9waXBlX3RpbWluZ3Moc3RydWN0IGlu
dGVsX2NydGMgKmludGVsX2NydGMpCj4gIAo+ICB9Cj4gIAo+IC1zdGF0aWMgdm9pZCBpbnRlbF9z
ZXRfcGlwZV9zcmNfc2l6ZShzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YykKPiArc3RhdGlj
IHZvaWQgaW50ZWxfc2V0X3BpcGVfc3JjX3NpemUoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3Rh
dGUgKmNydGNfc3RhdGUpCj4gIHsKPiAtCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBpbnRlbF9j
cnRjLT5iYXNlLmRldjsKPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRv
X2k5MTUoZGV2KTsKPiArCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjID0gdG9faW50ZWxf
Y3J0YyhjcnRjX3N0YXRlLT5iYXNlLmNydGMpOwo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg
KmRldl9wcml2ID0gdG9faTkxNShpbnRlbF9jcnRjLT5iYXNlLmRldik7Cj4gIAllbnVtIHBpcGUg
cGlwZSA9IGludGVsX2NydGMtPnBpcGU7Cj4gIAo+ICAJLyogcGlwZXNyYyBjb250cm9scyB0aGUg
c2l6ZSB0aGF0IGlzIHNjYWxlZCBmcm9tLCB3aGljaCBzaG91bGQKPiAgCSAqIGFsd2F5cyBiZSB0
aGUgdXNlcidzIHJlcXVlc3RlZCBzaXplLgo+ICAJICovCj4gIAlJOTE1X1dSSVRFKFBJUEVTUkMo
cGlwZSksCj4gLQkJICAgKChpbnRlbF9jcnRjLT5jb25maWctPnBpcGVfc3JjX3cgLSAxKSA8PCAx
NikgfAo+IC0JCSAgIChpbnRlbF9jcnRjLT5jb25maWctPnBpcGVfc3JjX2ggLSAxKSk7Cj4gKwkJ
ICAgKChjcnRjX3N0YXRlLT5waXBlX3NyY193IC0gMSkgPDwgMTYpIHwKPiArCQkgICAoY3J0Y19z
dGF0ZS0+cGlwZV9zcmNfaCAtIDEpKTsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgaW50ZWxfZ2V0
X3BpcGVfdGltaW5ncyhzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiAtLSAKPiAyLjE5LjAKPiAK
PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVs
LWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0
cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0t
IApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl
ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu
Zm8vaW50ZWwtZ2Z4Cg==