All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jiri Kosina <jikos@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	ksummit <Ksummit-discuss@lists.linuxfoundation.org>
Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Moving debugfs file systems into sysfs
Date: Wed, 3 Oct 2018 07:33:54 -0700	[thread overview]
Message-ID: <20181003143354.GB29980@kroah.com> (raw)
In-Reply-To: <20181003143233.GA29980@kroah.com>

On Wed, Oct 03, 2018 at 07:32:33AM -0700, Greg Kroah-Hartman wrote:
> On Wed, Oct 03, 2018 at 03:44:37PM +0200, Jiri Kosina wrote:
> > On Wed, 3 Oct 2018, Greg Kroah-Hartman wrote:
> > 
> > > > Not really. We need those configs to be enabled to be able to troubleshoot
> > > > customer's problems - e.g., asking customer to enable some trace points or
> > > > show some stats from debugfs is pretty common...
> > > 
> > > trace points should not be in debugfs.  And what stats are in debugfs
> > > that are not availble in other tools?  If you rely on them, shouldn't we
> > > move them to a "stable" location so that they can always be accessed?
> > 
> > So I for example quite often make use of the HID debugfs entries both for 
> > reading the descriptor, and also for analyzing the parsed events (which 
> > appear there as well).
> 
> for descriptors, both usb and pci expose them through other means that
> are always present, perhaps you want to do the same thing for hid?
> 
> > Surely it can be moved whereever else (where?), but it seems to fit to 
> > debugfs (it's used solely to debug dysfunctional devices / linux with 
> > those devices), and provides exactly the data you need from the owner of 
> > the system to provide in order to be able to debug remotely.
> 
> hidfs might be needed to match usbfs :)

Why not put the raw descriptors in sysfs?  That's what pci and usb do,
there's no reason you can't do the same here.  You already have a sysfs
device.  Oh wait, you do, 'report_descriptor' right?  Why do you also
need it in debugfs?

thanks,

greg k-h

  reply	other threads:[~2018-10-03 14:33 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-01 18:04 [Ksummit-discuss] [MAINTAINERS SUMMIT] Moving debugfs file systems into sysfs Steven Rostedt
2018-10-02  1:18 ` Greg KH
2018-10-02  1:26   ` Greg KH
2018-10-02 13:07   ` Steven Rostedt
2018-10-02 14:59     ` Olof Johansson
2018-10-02 16:00       ` Shuah Khan
2018-10-02 16:17         ` Greg Kroah-Hartman
2018-10-02 16:30           ` Greg Kroah-Hartman
2018-10-02 21:37             ` Mauro Carvalho Chehab
2018-10-02 21:57               ` Shuah Khan
2018-10-02 22:22                 ` Greg Kroah-Hartman
2018-10-03 12:59                   ` Jan Kara
2018-10-03 13:40                     ` Greg Kroah-Hartman
2018-10-03 13:44                       ` Jiri Kosina
2018-10-03 14:32                         ` Greg Kroah-Hartman
2018-10-03 14:33                           ` Greg Kroah-Hartman [this message]
2018-10-04 11:50                             ` Jiri Kosina
2018-10-03 14:53                       ` Jan Kara
2018-10-04 16:11                         ` Takashi Iwai
2018-10-03 14:11                     ` Shuah Khan
2018-10-03 10:06               ` Sudeep Holla
2018-10-03 13:13                 ` Mark Brown
2018-10-03 14:52                   ` Sudeep Holla
2018-10-02  8:40 ` Jani Nikula
2018-10-02 13:11   ` Steven Rostedt
2018-10-02 21:32   ` Mauro Carvalho Chehab
2018-10-03  6:23     ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181003143354.GB29980@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Ksummit-discuss@lists.linuxfoundation.org \
    --cc=jikos@kernel.org \
    --cc=mchehab+samsung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.