From: Peter Zijlstra <peterz@infradead.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: rafael@kernel.org, rjw@rjwysocki.net, linux-pm@vger.kernel.org,
Todd Kjos <tkjos@google.com>, Joel Fernandes <joelaf@google.com>,
Colin Cross <ccross@android.com>,
Ramesh Thomas <ramesh.thomas@intel.com>,
Mel Gorman <mgorman@suse.de>, Ingo Molnar <mingo@redhat.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Alex Shi <alex.shi@linaro.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] cpuidle/drivers/menu: Remove get_loadavg in the performance multiplier
Date: Thu, 4 Oct 2018 11:35:06 +0200 [thread overview]
Message-ID: <20181004093506.GK19272@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <e4cf9124-2dbb-45cb-6b45-f0b92a6ac88e@linaro.org>
On Thu, Oct 04, 2018 at 10:12:44AM +0200, Daniel Lezcano wrote:
>
> Hi Peter,
>
> On 04/10/2018 09:57, Peter Zijlstra wrote:
> > On Thu, Oct 04, 2018 at 09:42:07AM +0200, Daniel Lezcano wrote:
> >> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> >> index b88a145..5605f03 100644
> >> --- a/kernel/sched/core.c
> >> +++ b/kernel/sched/core.c
> >> @@ -2873,25 +2873,12 @@ unsigned long long nr_context_switches(void)
> >>
> >> return sum;
> >> }
> >> -/*
> >> - * Consumers of these two interfaces, like for example the cpufreq menu
> >> - * governor are using nonsensical data. Boosting frequency for a CPU that has
> >> - * IO-wait which might not even end up running the task when it does become
> >> - * runnable.
> >> - */
> >>
> >> unsigned long nr_iowait_cpu(int cpu)
> >
> > +static
>
> The function is exported in include/linux/sched/stat.h and used by
> drivers/cpuidle/governors/menu.c
>
> Do you want to declare it static inline in the stat.h file ?
No, but if there's a user left, that comment needs to stay. The number
it returns is utter crap.
next prev parent reply other threads:[~2018-10-04 9:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 7:42 [PATCH 1/2] sched: Factor out nr_iowait and nr_iowait_cpu Daniel Lezcano
2018-10-04 7:42 ` Daniel Lezcano
2018-10-04 7:42 ` [PATCH 2/2] cpuidle/drivers/menu: Remove get_loadavg in the performance multiplier Daniel Lezcano
2018-10-04 7:42 ` Daniel Lezcano
2018-10-04 7:57 ` Peter Zijlstra
2018-10-04 8:12 ` Daniel Lezcano
2018-10-04 9:35 ` Peter Zijlstra [this message]
2018-10-04 8:22 ` Rafael J. Wysocki
2018-10-04 8:40 ` Daniel Lezcano
2018-10-04 8:47 ` Rafael J. Wysocki
2018-10-04 9:36 ` Peter Zijlstra
2018-10-04 9:39 ` Rafael J. Wysocki
2018-10-04 17:16 ` Joe Perches
2018-10-04 7:46 ` [PATCH 1/2] sched: Factor out nr_iowait and nr_iowait_cpu Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181004093506.GK19272@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=alex.shi@linaro.org \
--cc=ccross@android.com \
--cc=daniel.lezcano@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=joelaf@google.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=pombredanne@nexb.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=ramesh.thomas@intel.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.