From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v2] event/dsw: fix icc build
Date: Thu, 4 Oct 2018 19:47:59 +0530
Message-ID: <20181004141758.GB10128@jerin>
References: <20180918124514.10615-2-mattias.ronnblom@ericsson.com>
 <20181004112113.21011-1-mattias.ronnblom@ericsson.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
To: Mattias =?iso-8859-1?Q?R=F6nnblom?= <mattias.ronnblom@ericsson.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM04-CO1-obe.outbound.protection.outlook.com
 (mail-eopbgr690042.outbound.protection.outlook.com [40.107.69.42])
 by dpdk.org (Postfix) with ESMTP id 22B8A1B107
 for <dev@dpdk.org>; Thu,  4 Oct 2018 16:18:23 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20181004112113.21011-1-mattias.ronnblom@ericsson.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Thu, 4 Oct 2018 13:21:13 +0200
> From: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> CC: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org, Mattias Rönnblom
>  <mattias.ronnblom@ericsson.com>
> Subject: [PATCH v2] event/dsw: fix icc build
> X-Mailer: git-send-email 2.17.1
> 
> Make the -Wno-format-nonliteral flag conditional, and only set in
> clang and gcc builds, since this flag is not supported (nor needed)
> when building dsw with icc.
> 
> Fixes: 46a186b1f0c5 ("event/dsw: add device registration and build system")
> 
> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---

Applied to dpdk-next-eventdev/master. Thanks.

>  drivers/event/dsw/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/event/dsw/Makefile b/drivers/event/dsw/Makefile
> index ea1e5259a..490ed0b98 100644
> --- a/drivers/event/dsw/Makefile
> +++ b/drivers/event/dsw/Makefile
> @@ -8,7 +8,9 @@ LIB = librte_pmd_dsw_event.a
>  CFLAGS += -DALLOW_EXPERIMENTAL_API
>  CFLAGS += -O3
>  CFLAGS += $(WERROR_FLAGS)
> +ifneq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
>  CFLAGS += -Wno-format-nonliteral
> +endif
> 
>  LDLIBS += -lrte_eal
>  LDLIBS += -lrte_mbuf
> --
> 2.17.1
>