From: Tony Lindgren <tony@atomide.com>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: t-kristo@ti.com, mturquette@baylibre.com, sboyd@kernel.org,
linux-omap@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, paul@pwsan.com,
letux-kernel@openphoenux.org
Subject: Re: [PATCH RFC 0/2] mach-omap2: handle autoidle denial
Date: Thu, 4 Oct 2018 07:25:58 -0700 [thread overview]
Message-ID: <20181004142558.GB5662@atomide.com> (raw)
In-Reply-To: <20181004055147.23048-1-andreas@kemnade.info>
* Andreas Kemnade <andreas@kemnade.info> [181004 05:56]:
> On the gta04 with a dm3730 omap_hdq does not work properly when the
> device enters lower power states. Idling uart1 and 2 is enough
> to show up that problem, if there are no other things enabled.
> Further research reveals that hdq iclk must not be turned off during
> transfers, also according to the TRM. That fact is also correctly described
> in the flags but the code to handle that is incomplete.
>
> Since the order is first disable all autoidles, then disable selected
> and then enable all, we need to either change that order or add
> a usecount. Since it is done only in init, we could think about changing
> order.
These patches look OK to me, assuming Tero will review them more
closely.
It seems we should just provide a generic interface for
clk_allow_autoidle() and clk_deny_autoidle()? Otherwise we'll
be forever stuck with pdata callbacks it seems.
Regards,
Tony
next prev parent reply other threads:[~2018-10-04 14:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 5:51 [PATCH RFC 0/2] mach-omap2: handle autoidle denial Andreas Kemnade
2018-10-04 5:51 ` [PATCH RFC 1/2] clk: ti: add a usecount for autoidle Andreas Kemnade
2018-10-04 14:40 ` Tero Kristo
2018-10-04 14:40 ` Tero Kristo
2018-10-04 19:34 ` Andreas Kemnade
2018-10-04 19:34 ` Andreas Kemnade
2018-10-04 5:51 ` [PATCH RFC 2/2] arm: mach-omap2: setup iclk autoidle according to flags Andreas Kemnade
2018-10-04 14:25 ` Tony Lindgren [this message]
2018-10-04 14:42 ` [PATCH RFC 0/2] mach-omap2: handle autoidle denial Tero Kristo
2018-10-04 14:42 ` Tero Kristo
2018-10-04 15:07 ` Tony Lindgren
2018-10-04 15:48 ` Tero Kristo
2018-10-04 15:48 ` Tero Kristo
2018-10-04 16:08 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181004142558.GB5662@atomide.com \
--to=tony@atomide.com \
--cc=andreas@kemnade.info \
--cc=letux-kernel@openphoenux.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=paul@pwsan.com \
--cc=sboyd@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.