From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linux PM <linux-pm@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/6] cpuidle: menu: Do not update last_state_idx in menu_select()
Date: Thu, 4 Oct 2018 16:57:32 +0200 [thread overview]
Message-ID: <20181004145732.GC1881@mai> (raw)
In-Reply-To: <1940908.mNKd7HXT40@aspire.rjw.lan>
On Tue, Oct 02, 2018 at 11:45:07PM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> It is not necessary to update data->last_state_idx in menu_select()
> as it only is used in menu_update() which only runs when
> data->needs_update is set and that is set only when updating
> data->last_state_idx in menu_reflect().
>
> Accordingly, drop the update of data->last_state_idx from
> menu_select() and get rid of the (now redundant) "out" label
> from it.
>
> No intentional behavior changes.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2018-10-04 14:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 21:41 [PATCH 0/6] cpuidle: menu: Fixes, optimizations and cleanups Rafael J. Wysocki
2018-10-02 21:42 ` [PATCH 1/6] cpuidle: menu: Fix wakeup statistics updates for polling state Rafael J. Wysocki
2018-10-04 8:19 ` Daniel Lezcano
2018-10-02 21:42 ` [PATCH 2/6] cpuidle: menu: Compute first_idx when latency_req is known Rafael J. Wysocki
2018-10-04 14:22 ` Daniel Lezcano
2018-10-02 21:44 ` [PATCH 3/6] cpuidle: menu: Get rid of first_idx from menu_select() Rafael J. Wysocki
2018-10-04 7:46 ` Peter Zijlstra
2018-10-04 7:53 ` Rafael J. Wysocki
2018-10-04 8:00 ` Peter Zijlstra
2018-10-04 14:51 ` Daniel Lezcano
2018-10-04 17:19 ` Rafael J. Wysocki
2018-10-05 8:35 ` Daniel Lezcano
2018-10-05 8:49 ` Rafael J. Wysocki
2018-10-02 21:45 ` [PATCH 4/6] cpuidle: menu: Do not update last_state_idx in menu_select() Rafael J. Wysocki
2018-10-04 14:57 ` Daniel Lezcano [this message]
2018-10-02 21:46 ` [PATCH 5/6] cpuidle: menu: Avoid computations for very close timers Rafael J. Wysocki
2018-10-04 15:50 ` Daniel Lezcano
2018-10-04 17:11 ` Rafael J. Wysocki
2018-10-02 21:47 ` [PATCH 6/6] cpuidle: menu: Move the latency_req == 0 special case check Rafael J. Wysocki
2018-10-04 6:55 ` [PATCH 0/6] cpuidle: menu: Fixes, optimizations and cleanups Rafael J. Wysocki
2018-10-04 7:51 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181004145732.GC1881@mai \
--to=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.