From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 08/13] drm/i915: Make shared dpll functions take crtc_state Date: Thu, 4 Oct 2018 18:24:26 +0300 Message-ID: <20181004152426.GR9144@intel.com> References: <20181004094604.2646-1-maarten.lankhorst@linux.intel.com> <20181004094604.2646-9-maarten.lankhorst@linux.intel.com> <20181004125755.GQ9144@intel.com> <8eddb830-516b-ce91-5da7-e6403881c4a2@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8638889D99 for ; Thu, 4 Oct 2018 15:24:31 +0000 (UTC) Content-Disposition: inline In-Reply-To: <8eddb830-516b-ce91-5da7-e6403881c4a2@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMDQsIDIwMTggYXQgMDM6MjU6NDJQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMDQtMTAtMTggb20gMTQ6NTcgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6 Cj4gPiBPbiBUaHUsIE9jdCAwNCwgMjAxOCBhdCAxMTo0NTo1OUFNICswMjAwLCBNYWFydGVuIExh bmtob3JzdCB3cm90ZToKPiA+PiBEbyBub3QgcmVseSBvbiBjcnRjLT5jb25maWcgYW55IG1vcmUu IFJlbW92ZSB0aGUgYXNzZXJ0aW9uIGZyb20KPiA+PiBpYnhfcGNoX2RwbGxfZGlzYWJsZSwgYmVj YXVzZSB3ZSB0aGUgZHBsbCBzdGF0ZSB0cmFja2luZyBzaG91bGQKPiA+PiBhbHJlYWR5IGhhbmRs ZSB0aGlzIGNhc2UgY29ycmVjdGx5Lgo+ID4+Cj4gPj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBM YW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiA+PiBSZXZpZXdl ZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+ PiAtLS0KPiA+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jICB8IDE0ICsr KysrKy0tLS0tLQo+ID4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jIHwg MzEgKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tCj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2RwbGxfbWdyLmggfCAgNiArKystLS0KPiA+PiAgMyBmaWxlcyBjaGFuZ2VkLCAyMiBp bnNlcnRpb25zKCspLCAyOSBkZWxldGlvbnMoLSkKPiA+Pgo+ID4+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMKPiA+PiBpbmRleCBmZThjY2JkZDRlYTEuLjRkZjQyOTNhNzkxNyAxMDA2 NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+PiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+PiBAQCAtNDc0OSw3 ICs0NzQ5LDcgQEAgc3RhdGljIHZvaWQgaXJvbmxha2VfcGNoX2VuYWJsZShjb25zdCBzdHJ1Y3Qg aW50ZWxfYXRvbWljX3N0YXRlICpzdGF0ZSwKPiA+PiAgCSAqIE5vdGUgdGhhdCBlbmFibGVfc2hh cmVkX2RwbGwgdHJpZXMgdG8gZG8gdGhlIHJpZ2h0IHRoaW5nLCBidXQKPiA+PiAgCSAqIGdldF9z aGFyZWRfZHBsbCB1bmNvbmRpdGlvbmFsbHkgcmVzZXRzIHRoZSBwbGwgLSB3ZSBuZWVkIHRoYXQg dG8gaGF2ZQo+ID4+ICAJICogdGhlIHJpZ2h0IExWRFMgZW5hYmxlIHNlcXVlbmNlLiAqLwo+ID4+ IC0JaW50ZWxfZW5hYmxlX3NoYXJlZF9kcGxsKGNydGMpOwo+ID4+ICsJaW50ZWxfZW5hYmxlX3No YXJlZF9kcGxsKGNydGNfc3RhdGUpOwo+ID4+ICAKPiA+PiAgCS8qIHNldCB0cmFuc2NvZGVyIHRp bWluZywgcGFuZWwgbXVzdCBhbGxvdyBpdCAqLwo+ID4+ICAJYXNzZXJ0X3BhbmVsX3VubG9ja2Vk KGRldl9wcml2LCBwaXBlKTsKPiA+PiBAQCAtNTU5MSw4ICs1NTkxLDggQEAgc3RhdGljIHZvaWQg aXJvbmxha2VfY3J0Y19lbmFibGUoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmln LAo+ID4+ICAJaW50ZWxfc2V0X2NwdV9maWZvX3VuZGVycnVuX3JlcG9ydGluZyhkZXZfcHJpdiwg cGlwZSwgZmFsc2UpOwo+ID4+ICAJaW50ZWxfc2V0X3BjaF9maWZvX3VuZGVycnVuX3JlcG9ydGlu ZyhkZXZfcHJpdiwgcGlwZSwgZmFsc2UpOwo+ID4+ICAKPiA+PiAtCWlmIChpbnRlbF9jcnRjLT5j b25maWctPmhhc19wY2hfZW5jb2RlcikKPiA+PiAtCQlpbnRlbF9wcmVwYXJlX3NoYXJlZF9kcGxs KGludGVsX2NydGMpOwo+ID4+ICsJaWYgKHBpcGVfY29uZmlnLT5oYXNfcGNoX2VuY29kZXIpCj4g Pj4gKwkJaW50ZWxfcHJlcGFyZV9zaGFyZWRfZHBsbChwaXBlX2NvbmZpZyk7Cj4gPj4gIAo+ID4+ ICAJaWYgKGludGVsX2NydGNfaGFzX2RwX2VuY29kZXIoaW50ZWxfY3J0Yy0+Y29uZmlnKSkKPiA+ PiAgCQlpbnRlbF9kcF9zZXRfbV9uKGludGVsX2NydGMsIE0xX04xKTsKPiA+PiBAQCAtNTcxMCw4 ICs1NzEwLDggQEAgc3RhdGljIHZvaWQgaGFzd2VsbF9jcnRjX2VuYWJsZShzdHJ1Y3QgaW50ZWxf Y3J0Y19zdGF0ZSAqcGlwZV9jb25maWcsCj4gPj4gIAo+ID4+ICAJaW50ZWxfZW5jb2RlcnNfcHJl X3BsbF9lbmFibGUoY3J0YywgcGlwZV9jb25maWcsIG9sZF9zdGF0ZSk7Cj4gPj4gIAo+ID4+IC0J aWYgKGludGVsX2NydGMtPmNvbmZpZy0+c2hhcmVkX2RwbGwpCj4gPj4gLQkJaW50ZWxfZW5hYmxl X3NoYXJlZF9kcGxsKGludGVsX2NydGMpOwo+ID4+ICsJaWYgKHBpcGVfY29uZmlnLT5zaGFyZWRf ZHBsbCkKPiA+PiArCQlpbnRlbF9lbmFibGVfc2hhcmVkX2RwbGwocGlwZV9jb25maWcpOwo+ID4+ ICAKPiA+PiAgCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDExKQo+ID4+ICAJCWljbF9tYXBf cGxsc190b19wb3J0cyhjcnRjLCBwaXBlX2NvbmZpZywgb2xkX3N0YXRlKTsKPiA+PiBAQCAtNjI4 Niw3ICs2Mjg2LDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfY3J0Y19kaXNhYmxlX25vYXRvbWljKHN0 cnVjdCBkcm1fY3J0YyAqY3J0YywKPiA+PiAgCj4gPj4gIAlpbnRlbF9mYmNfZGlzYWJsZShpbnRl bF9jcnRjKTsKPiA+PiAgCWludGVsX3VwZGF0ZV93YXRlcm1hcmtzKGludGVsX2NydGMpOwo+ID4+ IC0JaW50ZWxfZGlzYWJsZV9zaGFyZWRfZHBsbChpbnRlbF9jcnRjKTsKPiA+PiArCWludGVsX2Rp c2FibGVfc2hhcmVkX2RwbGwoY3J0Y19zdGF0ZSk7Cj4gPiBJIGd1ZXNzIHRoaXMgaXMgdGhlIGV4 cGxvc2lvbiBvbiBpOTE1Zy9pOTY1Zy4gV2UndmUgYWxyZWFkeSBmcmVlZCB0aGlzCj4gPiBjcnRj IHN0YXRlIGF0IHRoaXMgcG9pbnQuIFNvIEkgZ3Vlc3Mgcy9jcnRjX3N0YXRlL2NydGMtPnN0YXRl LyBhbmQgaXQKPiA+IHNob3VsZCBiZSBmaW5lPwo+ID4KPiBObywgdGhlIGV4cGxvc2lvbiBpcyBh dAo+IAo+IC0JaWYgKFdBUk5fT04ocGxsID09IE5VTEwpKQo+ICsJaWYgKCFXQVJOX09OKCFwbGwp KQo+ICAJCXJldHVybjsKPiAKPiBPb3BzISBTaG91bGQgYmUgZml4ZWQgaW4gdjIgSSdtIHNlbmRp bmcgbm93LgoKPDQ+WyAgIDExLjE4MTI1NF0gUjEwOiAwMDAwMDAwMDAwMDAwMDAwIFIxMTogMDAw MDAwMDAwMDAwMDAwMCBSMTI6IDZiNmI2YjZiNmI2YjZiNmIKPDQ+WyAgIDExLjE4MTE0MV0gUklQ OiAwMDEwOmludGVsX2Rpc2FibGVfc2hhcmVkX2RwbGwrMHgxMi8weDEzMCBbaTkxNV0KPDQ+WyAg IDExLjE4MTE1N10gQ29kZTogYzcgZTkgNjcgMjUgYTAgZTggOWUgZGEgZWMgZTAgMGYgMGIgZTkg MTggZmYgZmYgZmYgMGYgMWYgODAgMDAgMDAgMDAgMDAgNDEgNTYgNDEgNTUgNDEgNTQgNTUgNTMg NGMgOGIgMjcgNDggOGIgOWYgOTggMDIgMDAgMDAgPDRkPiA4YiAzNCAyNCA0MSA4MCBiZSA1YyAw ZCAwMCAwMCAwNCA3NiAwNSA0OCA4NSBkYiA3NSAwOSA1YiA1ZCA0MQoKNzJhOiAgIDRkIDhiIDM0 IDI0ICAgICAgICAgICAgIG1vdiAgICAoJXIxMiksJXIxNAoKTG9va3MgbGlrZSBpdCdzIHN0aWxs IHRyeWluZyB0byBkcmluayBwb2lzb24uCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=